llvm-project

Commit Graph

Author	SHA1	Message	Date
George Rimar	17a9204d0c	[LLD][ELF] - Fix BB after r350726. D56123 changed the llvm-objdump output format. Now we print the symbol address when dumping. llvm-svn: 350728	2019-01-09 15:06:57 +00:00
Fangrui Song	f5badf4905	[ELF] Write IPLT header in -static -z retpolineplt mode Summary: This fixes PR39711: -static -z retpolineplt does not produce retpoline PLT header. -z now is not relevant. Statically linked executable does not have PLT, but may have IPLT with no header. When -z retpolineplt is specified, however, the repoline PLT header should still be emitted. I've checked that this fixes the FreeBSD reproduce in PR39711 and a Linux program statically linked against glibc. The programm print "Hi" rather than SIGILL/SIGSEGV. getPltEntryOffset may look dirty after this patch, but it can be cleaned up later. Another possible improvement is that when there are non-preemptible IFUNC symbols (rare case, e.g. -Bsymbolic), both In.Plt and In.Iplt can be non-empty and we'll emit the retpoline PLT header twice. Reviewers: espindola, emaste, chandlerc, ruiu Reviewed By: emaste Subscribers: emaste, arichardson, krytarowski, llvm-commits Differential Revision: https://reviews.llvm.org/D54782 llvm-svn: 347404	2018-11-21 18:10:00 +00:00

Author

SHA1

Message

Date

George Rimar

17a9204d0c

[LLD][ELF] - Fix BB after r350726.

D56123 changed the llvm-objdump output format.
Now we print the symbol address when dumping.

llvm-svn: 350728

2019-01-09 15:06:57 +00:00

Fangrui Song

f5badf4905

[ELF] Write IPLT header in -static -z retpolineplt mode

Summary:
This fixes PR39711: -static -z retpolineplt does not produce retpoline PLT header.
-z now is not relevant.

Statically linked executable does not have PLT, but may have IPLT with no header. When -z retpolineplt is specified, however, the repoline PLT header should still be emitted.

I've checked that this fixes the FreeBSD reproduce in PR39711 and a Linux program statically linked against glibc. The programm print "Hi" rather than SIGILL/SIGSEGV.

getPltEntryOffset may look dirty after this patch, but it can be cleaned up later.

Another possible improvement is that when there are non-preemptible IFUNC symbols (rare case, e.g. -Bsymbolic), both In.Plt and In.Iplt can be non-empty and we'll emit the retpoline PLT header twice.

Reviewers: espindola, emaste, chandlerc, ruiu

Reviewed By: emaste

Subscribers: emaste, arichardson, krytarowski, llvm-commits

Differential Revision: https://reviews.llvm.org/D54782

llvm-svn: 347404

2018-11-21 18:10:00 +00:00

2 Commits