e2a3f75a12
Thread safety analysis: expand set of expressions that can be used to denote locks.
...
llvm-svn: 151956
2012-03-02 23:36:05 +00:00
bc638767f8
Reinstate r151879, r151880, reverted in r151922, along with a bugfix for
...
scalar emission of DeclRefExprs to const bools: emit scalar bools as i1,
not as i8.
In addition to the extra unit testing, this has successfully bootstrapped.
llvm-svn: 151955
2012-03-02 23:27:11 +00:00
b8b21e9b56
Unbreak the CMake builds following the CallGraph change.
...
llvm-svn: 151952
2012-03-02 23:18:45 +00:00
fc5dfe9f7c
[analyzer] Rename clang::CallGraph into clang::idx::CallGraph + rename
...
the corresponding files to avoid confusion.
This is a preparation to adding an AST-based call graph to Analysis. The
existing call graph works with indexer entries. We might be able to
refactor it to use the AST based graph in the future.
(Minimal testing here as the only example that uses the API has been
completely broken, does not compile.)
llvm-svn: 151950
2012-03-02 22:54:36 +00:00
611306eae6
Adding support for #pragma include_alias in MS compatibility mode. This implements PR 10705.
...
llvm-svn: 151949
2012-03-02 22:51:54 +00:00
71d6103295
Issue warning when late-parsed attributes have no declaration.
...
llvm-svn: 151947
2012-03-02 22:29:50 +00:00
bd2ee13e78
Make late-parsed attributes follow the conventions of ordinary
...
GNU attributes to a better extent, by allowing them in more
places on a declator.
llvm-svn: 151945
2012-03-02 22:12:59 +00:00
a2587ef26d
Thread safety analysis: handle CFG blocks which call functions marked as noreturn.
...
llvm-svn: 151944
2012-03-02 22:02:58 +00:00
ccec40d9b7
Add -Wstring-plus-int, which warns on "str" + int and int + "str".
...
It doesn't warn if the integer is known at compile time and within
the bounds of the string.
Discussion: http://comments.gmane.org/gmane.comp.compilers.clang.scm/47203
llvm-svn: 151943
2012-03-02 22:01:22 +00:00
7923ef41e1
objc: When issue diagnostic about deprecated method, also
...
issue the note if it is because message is sent to a forward class
declaration in delayed diagnostic. // rdar://10290322
llvm-svn: 151942
2012-03-02 21:50:02 +00:00
aa1f96add5
[analyzer diagnostics] flush locations *before* popping the current path when visiting a CallEnter.
...
Fixes <rdar://problem/10967815>
llvm-svn: 151938
2012-03-02 21:16:22 +00:00
2690838227
Fix an ABI problem with ptrdiff_t and intptr_t on PPC32
...
ptrdiff_t on PPC32 on Linux, etc. should be int not long.
This does not matter for C, but it does matter for C++ because of
name mangling.
The preprocessor test has been changed accordingly.
llvm-svn: 151935
2012-03-02 20:54:36 +00:00
4af2cb3355
[Sema] Fix crash-on-invalid-code issue:
...
@class I;
@implementation I(cat) // crashes here
@end
rdar://10968158
llvm-svn: 151931
2012-03-02 19:14:29 +00:00
265087721a
[analyzer] Bound the size of the functions being inlined + provide
...
command line options for inlining tuning.
This adds the option for stack depth bound as well as function size
bound.
+ minor doxygenification
llvm-svn: 151930
2012-03-02 19:05:03 +00:00
b0f3344b10
PR12094: Set the alignment of memory intrinsic instructions based on the
...
types of the pointer arguments.
llvm-svn: 151927
2012-03-02 18:34:30 +00:00
bf48281c25
Change diagnostic test for my last patch.
...
// rdar://10961370
llvm-svn: 151923
2012-03-02 17:05:03 +00:00
d01281fe0d
Revert r151879, r151880, "PR12145: Avoid emitting loads of constexpr variables in contexts where there" and "Fix buildbot: make this test less dependent on the value names in the produced IR."
...
They broke bootstrap.
llvm-svn: 151922
2012-03-02 16:24:25 +00:00
8fe5fc8521
Use tabs instead of spaces.
...
No, really, make doesn't work with spaces.
llvm-svn: 151920
2012-03-02 16:06:37 +00:00
5c302484e9
clang -v support for separate clang.git and llvm.git, patch by Andrew Trick.
...
llvm-svn: 151910
2012-03-02 14:37:41 +00:00
e04307e47c
Add the Solaris support directory to the header search when using libc++.
...
Unconditionally define __C99FEATURES__ when using C++ on Solaris. This is a
(hopefully temporary) work around for libc++ exposing C99-but-not-C++98
features in C++98 mode.
llvm-svn: 151889
2012-03-02 10:49:52 +00:00
35ecb36fcd
Ensure that we instantiate static reference data members of class templates
...
early, since their values can be used in constant expressions in C++11. For
odr-use checking, the opposite change is required, since references are
odr-used whether or not they satisfy the requirements for appearing in a
constant expression.
llvm-svn: 151881
2012-03-02 04:14:40 +00:00
a541a3bbee
PR12145: Avoid emitting loads of constexpr variables in contexts where there
...
is no odr-use of the variable. Go slightly beyond what the standard requires
for variables of reference type.
llvm-svn: 151879
2012-03-02 03:16:32 +00:00
f9e9d33019
[analyzer diagnostics] Change CompactPathDiagnostic to recursively compact diagnostics in calls into macro pieces.
...
Also fix handling of macros within calls in the HTMLDiagnostics.
This also adds a test case for r151774.
llvm-svn: 151872
2012-03-02 01:27:31 +00:00
3854a55a17
c/objc: problem originally reported as an objective-c bug.
...
But it is in the underlying c part of clang. clang crashes
in IRGen when passing an incomplete type argument to
variadic function (instead of diagnosing the bug).
// rdar://10961370
llvm-svn: 151862
2012-03-01 23:42:00 +00:00
57207d6074
Teach the analyzer to just ignore CXXBindTemporaryExpr. There's nothing special to do with it, since destructors are represented explicitly in the CFG.
...
llvm-svn: 151856
2012-03-01 23:06:04 +00:00
9466603322
Moving tagging of '__experimental_modules_import' IdentifierInfo out of
...
IndentifierTable::get() and into IdentifierTable's constructor.
This gets a 0.7% reducing on lexing time for Cocoa.h, and
about the same for PCH generation.
llvm-svn: 151854
2012-03-01 22:53:32 +00:00
c4e5d0ccda
Make CodeGenFunction::EmitBlockCopyAndAutorelease actually do what its name says.
...
llvm-svn: 151853
2012-03-01 22:52:28 +00:00
d5c3027473
[analyzer] Turn inlining on by default for better testing exposure.
...
Fix a test, which was most likely an unintended recursive call.
llvm-svn: 151848
2012-03-01 22:37:46 +00:00
28a7a1198b
Add a flag -fthread-sanitizer.
...
This flag enables ThreadSanitizer instrumentation committed to llvm as r150423.
The patch includes one test for -fthread-sanitizer and one similar test for -faddress-sanitizer.
This patch does not modify the linker flags (as we do it for -faddress-sanitizer) because the run-time library is not yet
committed and it's structure in compiler-rt is not 100% clear.
The users manual wil be changed in a separate commit.
llvm-svn: 151846
2012-03-01 22:27:08 +00:00
c1e4dd0e8e
Change @import to @__experimental_modules_import. We are not ready to commit to a particular syntax for modules,
...
and don't have time to push it forward in the near future.
llvm-svn: 151841
2012-03-01 22:07:04 +00:00
8dc53af5dc
[analyzer] Fix a regression introduced in malloc with
...
attributes, introduced in r151188.
+ the test to catch it.
Thanks to Ahmed Charles for pointing this out.
llvm-svn: 151840
2012-03-01 22:06:06 +00:00
4b6753cf10
Reapply r151702 with a small fix for a failure to cut and paste
...
correctly.
Still rdar://10900684
llvm-svn: 151838
2012-03-01 21:36:52 +00:00
23b1be991e
Fix the isReferenced bit on parameters in a couple of edge cases. PR12153.
...
llvm-svn: 151837
2012-03-01 21:32:56 +00:00
981a961d03
Move llvm/ADT/SaveAndRestore.h -> llvm/Support/SaveAndRestore.h.
...
Needs llvm update.
llvm-svn: 151829
2012-03-01 19:45:56 +00:00
cdb9f302d0
StmtProfiler: Add a null check for child statements.
...
llvm-svn: 151812
2012-03-01 16:34:31 +00:00
908f130d58
Implement double underscore names support in __has_attribute
...
llvm-svn: 151809
2012-03-01 14:53:16 +00:00
ebcd2357fb
Avoid examining the AST from the parser, and simplify somewhat.
...
llvm-svn: 151805
2012-03-01 07:10:06 +00:00
ead9a05596
Revert r151800, which was committed without review and has correctness issues.
...
llvm-svn: 151804
2012-03-01 06:49:39 +00:00
cd5092dfba
Implements support for #pragma include_alias in ms compatibility mode. Fixes PR10705.
...
llvm-svn: 151800
2012-03-01 04:18:49 +00:00
9ecff02a45
Added support for parsing declspecs on enumerations. Fixes PR8783
...
llvm-svn: 151798
2012-03-01 04:09:28 +00:00
98b01edc8c
Implement "optimization" for lambda-to-block conversion which inlines the generated block literal for lambdas which are immediately converted to block pointer type. This simplifies the AST, avoids an unnecessary copy of the lambda and makes it much easier to avoid copying the result onto the heap.
...
Note that this transformation has a substantial semantic effect outside of ARC: it gives the converted lambda lifetime semantics similar to a block literal. With ARC, the effect is much less obvious because the lifetime of blocks is already managed.
llvm-svn: 151797
2012-03-01 04:01:32 +00:00
5e0cac784a
Reject 'a = {0} = {0}' rather than parsing it as '(a = {0}) = {0}'. Also
...
improve the diagnostics for some attempts to use initializer lists in
expressions.
llvm-svn: 151794
2012-03-01 02:59:17 +00:00
05e916bc95
Fix regression from llvm-gcc where we should NOT emit a warning about __attribute__((NSObject)) on a property declaration. This is needed to have retain properties for non-object pointers. Fixes <rdar://problem/10930507>.
...
llvm-svn: 151786
2012-03-01 01:40:32 +00:00
ec9c4e487c
[analyzer] Diagnostics - do not try to cleanup the path with macros, it
...
will be done by the general cleanup later on.
A Patch by Ted.
llvm-svn: 151784
2012-03-01 01:30:58 +00:00
2fb8512888
Tighten type-checking a bit to make it clearer how BuildCXXMemberCallExpr is used.
...
llvm-svn: 151783
2012-03-01 01:30:04 +00:00
2c21c449d9
Move suport for redefining operator keywords from -fms-extensions to -fms-compatibility.
...
llvm-svn: 151776
2012-03-01 00:13:46 +00:00
0a8e00d493
Change if...else if...else if... to a switch.
...
llvm-svn: 151775
2012-03-01 00:05:06 +00:00
0f0cc35935
[analyzer] when scanning FIDs in a PathDiagnostic, correctly recurse calls and macros.
...
llvm-svn: 151774
2012-02-29 23:59:20 +00:00
2e686205e8
Allow operator keywords to be #defined in ms-ext mode.
...
Fixes PR10606.
I'm not sure if this is the best way to go about it, but
I locally enabled this code path without the msext conditional,
and all tests pass, except for test/Preprocessor/cxx_oper_keyword.cpp
which explicitly checks that operator keywords can't be redefined.
I also parsed chromium/win with a clang with and without this patch.
It introduced no new errors, but removes 43 existing errors.
llvm-svn: 151768
2012-02-29 22:54:43 +00:00
86c2f5cc70
objective-c: provide fixit hint when atomic property does not
...
have matching user defined setter/getter and a warning is issued.
In this case, a fixit note is displayed. // rdar://10267155
llvm-svn: 151766
2012-02-29 22:18:55 +00:00
381f431e28
Fix a couple -Wuninitialized warnings from gcc. Reported by David Greene.
...
llvm-svn: 151754
2012-02-29 20:59:56 +00:00
9a96386e6d
Serialization: Switch over to using the native SmallVector based BitstreamWriter
...
ctor.
llvm-svn: 151752
2012-02-29 20:31:23 +00:00
b1cfc6864f
Allocate TargetLibraryInfo for the CodeGen passes. Otherwise, it's instantiated
...
by the BAA pass, which uses the default TargetLibraryInfo constructor.
Unfortunately, the default TargetLibraryInfo constructor assumes all library
calls are available and thus ignores -fno-builtin.
rdar://10947759
llvm-svn: 151745
2012-02-29 20:14:59 +00:00
e0c03cab58
[analyzer] Malloc: A pointer might escape through CFContainers APIs,
...
funopen, setvbuf.
Teach the checker and the engine about these APIs to resolve malloc
false positives. As I am adding more of these APIs, it is clear that all
this should be factored out into a separate callback (for example,
region escapes). Malloc, KeyChainAPI and RetainRelease checkers could
all use it.
llvm-svn: 151737
2012-02-29 18:42:47 +00:00
c2f9dc91c1
Revert r151702, "Add support for handling captured variables in lambda debug
...
info.", which broke some -O0 -g tests.
llvm-svn: 151730
2012-02-29 16:28:29 +00:00
272a071d65
Add -C when linking on Solaris so that the error messages are understandable by actual humans.
...
llvm-svn: 151726
2012-02-29 15:06:12 +00:00
c7b718eb53
Tentatively fix PR12117. The test case from the bug now passes, and all existing tests still pass, but there may still be corner cases.
...
llvm-svn: 151716
2012-02-29 12:47:43 +00:00
6f8780bed1
Reapply r151638 and r151641.
...
The bug that was caught by Apple's internal buildbots was valid and also showed another bug in my implementation.
These are now fixed, with regression tests added to catch them both (not Darwin-specific).
Original log:
====================
Revert r151638 because it causes assertion hit on PCH creation for Cocoa.h
Original log:
---------------------
Correctly track tags and enum members defined in the prototype of a function, and ensure they are properly scoped.
This fixes code such as:
enum e {x, y};
int f(enum {y, x} n) {
return 0;
}
This finally fixes PR5464 and PR5477.
---------------------
I also reverted r151641 which was enhancement on top of r151638.
====================
llvm-svn: 151712
2012-02-29 10:24:19 +00:00
64aea6524d
Remove a recursive visitiation in ExprEngine that is no longer needed
...
because the CFG is fully linearized.
llvm-svn: 151711
2012-02-29 08:42:57 +00:00
ef5c554df4
[analyzer] Tweak the UnreachableCode checker to not warning about unreachable default blocks. Patch by Cyril Roelandt!
...
llvm-svn: 151709
2012-02-29 06:05:28 +00:00
e4f22dfa95
A couple minor bug-fixes for template instantiation for expressions which are sometimes potentially evaluated.
...
llvm-svn: 151707
2012-02-29 04:03:55 +00:00
3dbeb55874
[driver] Emit an error when trying to use ARC on macosx earlier than 10.6
...
rdar://10459258
llvm-svn: 151706
2012-02-29 03:43:52 +00:00
3203f6b9da
Add support for handling captured variables in lambda debug info.
...
This currently doesn't handle capturing the 'this' pointer for any
enclosing class.
Steal the lambda-expressions.cpp testcase and debugify it and try
to use more variables to proof it against random changes.
Part of rdar://10900684
llvm-svn: 151702
2012-02-29 03:25:30 +00:00
d47e0862b2
Formatting.
...
llvm-svn: 151700
2012-02-29 03:25:18 +00:00
c6237c6e05
Make the odr-use logic work correctly for constant-expressions. PR12006.
...
llvm-svn: 151699
2012-02-29 03:16:56 +00:00
d6d74c37ec
Sema/ObjC: Override search can generate a large search list, bump the base size
...
of the SmallPtrSet way up to avoid commonly reallocating the buffer size.
- I didn't see a good argument against it, so I bumped the limit to cover the
max size we see during parsing Cocoa.h.
llvm-svn: 151698
2012-02-29 03:04:05 +00:00
a5acaa3ca8
ASTWriter: Cache some DenseMaps we use repeatedly.
...
- This reduces our total # of allocations building a PCH for Cocoa.h by almost
a whopping 50%.
- A SmallPtrMap would be cleaner, but since we don't have one yet...
llvm-svn: 151697
2012-02-29 02:39:13 +00:00
340cf24be1
Parse: Change PragmaPackHandler to use the preprocessor allocator.
...
llvm-svn: 151689
2012-02-29 01:38:22 +00:00
1dc712f7cc
objective-c modern translator. Fixes misc. bug in writing
...
the ivar offset symbol.
llvm-svn: 151683
2012-02-29 00:26:20 +00:00
576cbd03b4
Make sure list-initialization of arrays works correctly in explicit type conversions. PR12121.
...
llvm-svn: 151674
2012-02-29 00:00:28 +00:00
5929ef2ee7
Revert r151638 because it causes assertion hit on PCH creation for Cocoa.h
...
Original log:
---------------------
Correctly track tags and enum members defined in the prototype of a function, and ensure they are properly scoped.
This fixes code such as:
enum e {x, y};
int f(enum {y, x} n) {
return 0;
}
This finally fixes PR5464 and PR5477.
---------------------
I also reverted r151641 which was enhancement on top of r151638.
llvm-svn: 151667
2012-02-28 23:39:14 +00:00
12edeb0899
Single- and zero-element initializer lists to scalars are list-initializations. Fixes PR12118.
...
llvm-svn: 151666
2012-02-28 23:36:38 +00:00
0f70a6f51e
[analyzer diagnostics] Refactor filtration for PathDiagnosticConsumers that don't support cross-file diagnostics
...
into a common place. Currently enable this filtration for Plist diagnostics as well.
llvm-svn: 151664
2012-02-28 23:27:39 +00:00
2429c6ffe7
[analyzer diagnostics] start prototyping stripping PathDiagnostics of unnecessary cruft caused by path inlining.
...
This introduces a concept of a "prunable" PathDiagnosticEvent. Currently this is a flag, but
we may evolve the concept to make this more dynamically inferred.
llvm-svn: 151663
2012-02-28 23:06:21 +00:00
265a421dd9
Modern objective-c translator. rewriting ivars of aggregate type.
...
llvm-svn: 151662
2012-02-28 22:45:07 +00:00
75de32322a
[analyzer] Leaks should be uniqued by the allocation point in the
...
closest function context (RetainCountChecker).
llvm-svn: 151661
2012-02-28 22:39:22 +00:00
8754926feb
Prefer bitcast+GEP over ptrtoint+sub+inttoptr: it's semantically equivalent here, and generally nicer to the optimizer.
...
llvm-svn: 151659
2012-02-28 22:07:56 +00:00
16f3831064
[analyzer] Retain release: drop the line number info from the leak
...
message.
llvm-svn: 151657
2012-02-28 21:49:08 +00:00
b6e2854f68
[analyzer] Stats: Add the stats about remove dead bindings, correct the
...
test.
llvm-svn: 151656
2012-02-28 21:49:04 +00:00
c73fb894af
Add -lm by default on Solaris.
...
llvm-svn: 151653
2012-02-28 20:06:45 +00:00
e0a7c28627
It turns out -fno-cxa-atexit just produces broken code, so disable it on Solaris and we'll ship a __cxa_atexit implementation...
...
llvm-svn: 151648
2012-02-28 19:15:06 +00:00
ecd2edf50c
Un-break clang based on r151638 - What was meant to be a trivial variable name change went horribly wrong and I forgot to retest afterwards.
...
llvm-svn: 151641
2012-02-28 18:23:49 +00:00
051390fffa
Correctly track tags and enum members defined in the prototype of a function, and ensure they are properly scoped.
...
This fixes code such as:
enum e {x, y};
int f(enum {y, x} n) {
return 0;
}
This finally fixes PR5464 and PR5477.
llvm-svn: 151638
2012-02-28 18:12:11 +00:00
3460880674
[AST] When we @synthesize a property with a user-defined ivar name,
...
make sure to record the source location of the ivar name.
[libclang] When indexing @synthesized objc methods, report the @implementation
as the lexical container.
Fixes rdar://10905472
llvm-svn: 151635
2012-02-28 17:50:39 +00:00
ceeb19cf18
[AST] Associate the getter/setter methods to a property of a objc class extension.
...
[libclang] Index the getter/setter methods of a property of a objc class extension.
Fixes rdar://10907597
llvm-svn: 151633
2012-02-28 17:50:28 +00:00
0c52c0f0fd
Some more Solaris fixes. Now successfully building libc++ on Solaris with clang (and linking clang against it).
...
llvm-svn: 151632
2012-02-28 17:10:04 +00:00
f3d3b0134d
Remove stray semi-colons.
...
llvm-svn: 151631
2012-02-28 15:36:15 +00:00
6ca4fd5b88
[analyzer] Leaks should be uniqued by the allocation point in the
...
closest function context (Keychain API).
llvm-svn: 151613
2012-02-28 03:07:06 +00:00
06a77fc1b9
[analyzer] Fix Malloc False Positive (PR 12100)
...
When allocated buffer is passed to CF/NS..NoCopy functions, the
ownership is transfered unless the deallocator argument is set to
'kCFAllocatorNull'.
llvm-svn: 151608
2012-02-28 01:54:22 +00:00
ec75fec805
Implement IRGen for the retain-autorelease in the lambda conversion-to-block-pointer outside of ARC. Testcases coming up soon.
...
llvm-svn: 151603
2012-02-28 01:08:45 +00:00
3bc5372fae
[analyzer] teach analyzer about ObjC literals, thus trimming out a false positive with the malloc() checker involving
...
comparing literal addresses to nil.
Fixes <rdar://problem/10579586>
llvm-svn: 151602
2012-02-28 00:56:05 +00:00
2e16624291
Re-enable the Darwin ARM integrated assembler.
...
All known nightly-test failures are fixed.
llvm-svn: 151595
2012-02-27 23:55:25 +00:00
43ffba2676
[analyzer] Leaks should be uniqued by the allocation point in the
...
closest function context.
This prevents us from uniqueing all leaks from the same allocation
helper. radar://10932226
llvm-svn: 151592
2012-02-27 23:40:55 +00:00
e0bce93e14
[analyzer] Don't generate an explicit ExplodedNode for StringLiterals; have the SVal lazily generated from Environment::getSVal().
...
llvm-svn: 151589
2012-02-27 23:34:19 +00:00
a235e2d8ad
Hack in a loud error for PR12086. Better than a silent miscompile.
...
llvm-svn: 151586
2012-02-27 23:20:01 +00:00
465e137558
When evaluating integer expressions include a check for sub-expressions
...
depth and error if we exceed a max value, to make sure we avoid a stack overflow.
This is a hacky temporary fix. rdar://10913206.
llvm-svn: 151585
2012-02-27 23:18:37 +00:00
59b10db2bc
After numerous requests, have Objective-C 'method declared here' notes mention the actual method. This looks better within an IDE, where text isn't always regurgitated in the presentation of a warning. Fixes radar 10914035.
...
llvm-svn: 151579
2012-02-27 22:55:11 +00:00
aa6feaa7ea
Implement a FIXME for conversion sequence distinction. Should fix PR12092.
...
llvm-svn: 151577
2012-02-27 22:38:26 +00:00
b028654031
[analyzer] Add -analyzer-stats, which hooks up LLVM stats tracking.
...
As in http://llvm.org/docs/ProgrammersManual.html#Statistic
llvm-svn: 151570
2012-02-27 21:33:16 +00:00
84e6e5cd1a
Fix a couple bugs in the way we handle array indexes in array bounds checking. Specifically, make sure we don't ignore explicit casts in indexes, and make sure we use unsigned extension/comparisons on indexes. Fixes <rdar://problem/10916006>.
...
llvm-svn: 151569
2012-02-27 21:21:40 +00:00
DeLesley Hutchins