4525be4ebc
clang-tidy: Add override before the first attribute.
...
Apparently attributes aren't sorted by source location.
llvm-svn: 222751
2014-11-25 10:45:23 +00:00
2d9e0b782c
clang-tidy: [use-override] Tweak messages.
...
It doesn't make sense to suggest 'virtual' as clang-tidy would complain
about that on the next iteration (we are never issuing warnings for the
base function).
llvm-svn: 214063
2014-07-28 07:29:29 +00:00
58ed9c9167
clang-tidy: [misc-use-override] Slightly tweak the wording of warning.
...
'final' should really be used with care.
llvm-svn: 213501
2014-07-21 06:06:38 +00:00
024ebf4a65
clang-tidy: [misc-use-override] Correctly handle defaulted destructors.
...
Also, minor implementation and test fixes.
llvm-svn: 211345
2014-06-20 09:12:46 +00:00
05bdb09da1
clang-tidy: [use-override] Remove 'override' if 'final' is also present.
...
Also, make warning more precise by distinguishing different cases.
llvm-svn: 210651
2014-06-11 12:18:24 +00:00
0ab7902755
clang-tidy use override: Don't generate incorrect warnings without fixes
...
Add basic testing for the emitted diagnostics.
llvm-svn: 210171
2014-06-04 08:26:02 +00:00
88996755cb
clang-tidy: Extend the use-override check to understand 'final'.
...
llvm-svn: 210031
2014-06-02 15:22:22 +00:00
a2332425c4
Revert "Remove redundant check discovered in post-commit review of r209505."
...
This breaks with MSVC.
With IsLateTemplateParsed, FunctionDecl::doesThisDeclarationHaveABody() returns true regardless of Body.
This reinstates what was fixed in r208985.
llvm-svn: 209896
2014-05-30 13:31:14 +00:00
5070c18928
Remove redundant check discovered in post-commit review of r209505.
...
llvm-svn: 209882
2014-05-30 09:21:17 +00:00
39f9f726bc
clang-tidy: Only add 'override' before inlined bodies.
...
llvm-svn: 209505
2014-05-23 08:52:10 +00:00
993a906af3
Address review comments on r208954. No functional changes.
...
llvm-svn: 209111
2014-05-19 07:23:03 +00:00
81774baf4d
Initializer list is unavailable. Use the constructor instead.
...
llvm-svn: 208986
2014-05-16 13:37:20 +00:00
2dd94635d4
clang-tidy/misc/UseOverride.cpp: Appease targeting msvc.
...
With IsLateTemplateParsed, FunctionDecl::doesThisDeclarationHaveABody() returns True regardless of Body.
llvm-svn: 208985
2014-05-16 13:37:08 +00:00
2378ebd537
Initial version of clang-tidy check to use override instead of virual.
...
Review: http://reviews.llvm.org/D3688
llvm-svn: 208954
2014-05-16 09:30:09 +00:00
Daniel Jasper