maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
383,198 Commits 23 Branches 0 Tags 2.2 GiB
Commit Graph

12 Commits

Author SHA1 Message Date
Warren Hunt fb00c88703 Complete Rewrite of CGRecordLayoutBuilder 
CGRecordLayoutBuilder was aging, complex, multi-pass, and shows signs of 
existing before ASTRecordLayoutBuilder.  It redundantly performed many 
layout operations that are now performed by ASTRecordLayoutBuilder and 
asserted that the results were the same.  With the addition of support 
for the MS-ABI, such as placement of vbptrs, vtordisps, different 
bitfield layout and a variety of other features, CGRecordLayoutBuilder 
was growing unwieldy in its redundancy.

This patch re-architects CGRecordLayoutBuilder to not perform any 
redundant layout but rather, as directly as possible, lower an 
ASTRecordLayout to an llvm::type.  The new architecture is significantly 
smaller and simpler than the CGRecordLayoutBuilder and contains fewer 
ABI-specific code paths.  It's also one pass.

The architecture of the new system is described in the comments. For the 
most part, the new system simply takes all of the fields and bases from 
an ASTRecordLayout, sorts them, inserts padding and dumps a record. 
Bitfields, unions and primary virtual bases make this process a bit more 
complicated.  See the inline comments.

In addition, this patch updates a few lit tests due to the fact that the 
new system computes more accurate llvm types than CGRecordLayoutBuilder. 
Each change is commented individually in the review.

Differential Revision: http://llvm-reviews.chandlerc.com/D2795

llvm-svn: 201907
 2014-02-21 23:49:50 +00:00
Peter Collingbourne 085095f1ac Move vtable dumper call to VTableBuilder ctor 
llvm-svn: 140508
 2011-09-26 01:57:00 +00:00
Anders Carlsson 151b062fee Don't add address points for virtual primary bases that aren't primary bases in the complete class. 
llvm-svn: 99555
 2010-03-25 21:45:14 +00:00
Anders Carlsson ca82a4fdba Improve vcall offset handling in construction vtables. With this we layout the construction vtables from the ABI examples correctly. 
llvm-svn: 98127
 2010-03-10 02:33:41 +00:00
Anders Carlsson 4d0729a7cc Figured out why the test was failing, this will hopefully fix it. 
llvm-svn: 97336
 2010-02-27 19:00:53 +00:00
Anders Carlsson ec27c49d6c XFAIL this for now. I have no idea why this test is failing on some machines. Looks like some sort of whitespace issue in FileCheck. 
llvm-svn: 97332
 2010-02-27 18:09:05 +00:00
Anders Carlsson a9f633b060 Generate correct vcall offsets when we have a primary virtual base that is not a primary base in the complete class hierarchy. 
llvm-svn: 97039
 2010-02-24 16:43:12 +00:00
Anders Carlsson 821095085b Add another test from the ABI spec. 
llvm-svn: 96659
 2010-02-19 05:59:40 +00:00
Anders Carlsson e5faca7cda Fix another bug and add another class. 
llvm-svn: 96590
 2010-02-18 17:32:33 +00:00
Anders Carlsson aa7444cd7d Add another class from cxx-vtable-ex.html 
llvm-svn: 96588
 2010-02-18 17:28:16 +00:00
Anders Carlsson 8847d9e40a More work on vcall offsets. 
llvm-svn: 96587
 2010-02-18 17:26:40 +00:00
Anders Carlsson 664b7d026e Add tests from the Itanium C++ ABI spec. 
llvm-svn: 96586
 2010-02-18 17:07:24 +00:00