Benjamin Kramer
bc90075629
[include-fixer] Add a missing .h.
...
llvm-svn: 270989
2016-05-27 12:49:58 +00:00
NAKAMURA Takumi
201c955fbc
clang-tools-extra/test/clang-tidy/cppcoreguidelines-pro-type-vararg.cpp: Tweak for r270775.
...
llvm-svn: 270841
2016-05-26 11:20:54 +00:00
Samuel Benzaquen
7663d3be15
Speed up check by using a recursive visitor.
...
Summary:
Use a recursive visitor instead of forEachDescendant() matcher.
The latter requires several layers of virtual function calls for each node and
it is more expensive than the visitor.
Benchmark results show improvement of ~6% walltime in clang-tidy.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20597
llvm-svn: 270714
2016-05-25 16:19:23 +00:00
Eric Liu
fff1335fce
[include-fixer] /usr/include/xlocal.h to include/xlocal.h in hardcoded map.
...
llvm-svn: 270703
2016-05-25 14:17:09 +00:00
Benjamin Kramer
0e871f0b66
Include local header with quotes instead of angle brackets.
...
This works by accident because we pass '-I.'
llvm-svn: 270701
2016-05-25 14:14:52 +00:00
Haojian Wu
218febb8eb
[include-fixer] Simplify the code since we won't handle multiple includes at once.
...
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20581
llvm-svn: 270700
2016-05-25 14:06:12 +00:00
Eric Liu
748308ad35
[include-fixer] moved STLPostfixMap into findAllSymbols library and make it a static variable in function.
...
Summary: [include-fixer] moved STLPostfixMap into findAllSymbols library and make it a static variable in function.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20619
llvm-svn: 270696
2016-05-25 13:53:33 +00:00
Benjamin Kramer
c85e14e0d6
[clang-tidy] Fix typo in test file name.
...
polo
llvm-svn: 270682
2016-05-25 09:44:35 +00:00
Miklos Vajna
10e25748b0
clang-rename: fix renaming non-members variables when referenced as macro arguments
...
The second check failed, FOO(C::X) wasn't renamed to FOO(C::Y).
Reviewers: klimek
Differential Revision: http://reviews.llvm.org/D20537
llvm-svn: 270599
2016-05-24 19:08:53 +00:00
Benjamin Kramer
e78ace55df
[clang-tidy] Don't rely on <array> being available.
...
The STL isn't necessarily around when running tests. Make our own fake
std::array to test this.
llvm-svn: 270581
2016-05-24 16:54:26 +00:00
Eric Liu
54b68779b2
[include-fixer][find-all-symbols] added missing dependencies.
...
llvm-svn: 270578
2016-05-24 16:35:24 +00:00
Mads Ravn
ef88dc8fe4
[clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
...
Adding to revision 270567. The lit-style test was wrong. This is being fixed by this commit.
This is the bug on bugzilla: https://llvm.org/bugs/show_bug.cgi?id=27731
This is the code review on phabricator: http://reviews.llvm.org/D20365
llvm-svn: 270575
2016-05-24 16:09:24 +00:00
Eric Liu
0a28e680f7
[include-fixer][find-all-symbols] removed unused const member from YamlReporter to fix build bot failure.
...
llvm-svn: 270571
2016-05-24 15:34:37 +00:00
Mads Ravn
28cc243930
[clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
...
Adding to revision 270565. The lit-style test was wrong. This is being fixed by this commit.
This is the bug on bugzilla: https://llvm.org/bugs/show_bug.cgi?id=27731
This is the code review on phabricator: http://reviews.llvm.org/D20365
llvm-svn: 270567
2016-05-24 15:13:44 +00:00
Eric Liu
a7d19414da
[find-all-symbols] Added hardcode header mapping from header postfix to header name for STL symbols.
...
Summary: [find-all-symbols] Added hardcode header mapping from header postfix to header name for STL symbols.
Reviewers: klimek, bkramer
Subscribers: cfe-commits, hokein
Differential Revision: http://reviews.llvm.org/D20566
llvm-svn: 270566
2016-05-24 15:10:58 +00:00
Mads Ravn
7175c2ce4d
[clang-tidy] modernize-pass-by-value bugfix
...
Modified the clang-tidy PassByValue check. It now stops adding std::move to type which is trivially copyable because that caused the clang-tidy MoveConstArg to complain and revert, thus creating a cycle.
I have also added a lit-style test to verify the bugfix.
This is the bug on bugzilla: https://llvm.org/bugs/show_bug.cgi?id=27731
This is the code review on phabricator: http://reviews.llvm.org/D20365
llvm-svn: 270565
2016-05-24 15:00:16 +00:00
Mads Ravn
86d5f8ad4c
Commiting for http://reviews.llvm.org/D20365
...
llvm-svn: 270473
2016-05-23 18:27:05 +00:00
Mads Ravn
dfa3b3d3ee
Commiting for http://reviews.llvm.org/D20365
...
llvm-svn: 270472
2016-05-23 18:15:40 +00:00
Mads Ravn
d01743a3f7
Commiting for http://reviews.llvm.org/D20365
...
llvm-svn: 270470
2016-05-23 18:06:29 +00:00
Alexander Kornienko
1c6d827015
Fix docs
...
llvm-svn: 270288
2016-05-20 22:42:03 +00:00
Alexander Kornienko
5d08bb72d9
[clang-tidy] Switch to a more common way of customizing check behavior.
...
This should have been done this way from the start, however I somehow missed
r257177.
llvm-svn: 270215
2016-05-20 13:42:40 +00:00
Haojian Wu
cc0c10e300
[find-all-symbols] Some cleanups in unittest.
...
llvm-svn: 270211
2016-05-20 12:47:56 +00:00
Haojian Wu
a23ac3d249
[find-all-symbol] Ignore inline namespace context.
...
Reviewers: bkramer
Subscribers: cfe-commits, ioeric
Differential Revision: http://reviews.llvm.org/D20465
llvm-svn: 270206
2016-05-20 12:04:56 +00:00
Miklos Vajna
ed28d41b1a
clang-rename: fix renaming members when referenced as macro arguments
...
The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y).
Reviewers: klimek
Differential Revision: http://reviews.llvm.org/D20446
llvm-svn: 270204
2016-05-20 11:43:59 +00:00
Eric Liu
6c9472c57f
[find-all-symbols] fix failing unittest for Windows build bot.
...
llvm-svn: 270202
2016-05-20 11:14:36 +00:00
Haojian Wu
20dec208e9
[find-all-symbol] Try to fix the failure windows unittest.
...
llvm-svn: 270199
2016-05-20 10:36:53 +00:00
Haojian Wu
17baf85e41
[clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.
...
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20463
llvm-svn: 270197
2016-05-20 09:38:25 +00:00
Eric Liu
81554e7257
[find-all-symbols] fixed FindAllMacros compilation error.
...
llvm-svn: 270196
2016-05-20 09:23:19 +00:00
Eric Liu
83a4d7fbba
[find-all-symbols] make HeaderMapCollector optional in FindAllSymbols and FindAllMacros.
...
llvm-svn: 270193
2016-05-20 09:12:01 +00:00
Haojian Wu
1cea6e5531
[clang-tidy] Handle using-decls with more than one shadow decl.
...
Reviewers: alexfh
Subscribers: cfe-commits, djasper
Differential Revision: http://reviews.llvm.org/D20429
llvm-svn: 270191
2016-05-20 08:34:32 +00:00
Haojian Wu
5e4f0255a1
[find-all-symbol] Add macro support.
...
Reviewers: bkramer
Subscribers: cfe-commits, ioeric
Differential Revision: http://reviews.llvm.org/D20420
llvm-svn: 270189
2016-05-20 08:04:36 +00:00
Benjamin Kramer
ee4e522c26
[include-fixer] Fix unused variable warning in Release builds.
...
llvm-svn: 270082
2016-05-19 16:57:57 +00:00
Haojian Wu
0de7226236
[include-fixer] Remove an unused local variable ExistingHeaders.
...
llvm-svn: 270059
2016-05-19 13:23:27 +00:00
Benjamin Kramer
9b15b6f2d7
[include-fixer] Make search handle fully qualified names correctly.
...
If a search string starts with "::" we don't want to return any results
for suffixes of that string.
Differential Revision: http://reviews.llvm.org/D20424
llvm-svn: 270055
2016-05-19 12:41:56 +00:00
Benjamin Kramer
04666a2d5d
[include-fixer] Remove obsolete windows hack.
...
llvm-svn: 270045
2016-05-19 11:39:56 +00:00
Alexander Kornienko
a20bab46cd
[clang-tidy] Fix/add style guide links.
...
Thanks to Tim Halloran for the initial patch (http://reviews.llvm.org/D15089 )!
llvm-svn: 270033
2016-05-19 09:31:30 +00:00
Alexander Kornienko
77c8b2ed9f
[clang-tidy] Fix doc titles.
...
llvm-svn: 270032
2016-05-19 09:29:46 +00:00
Eric Liu
702cfd1b2b
[include-fixer] Sort headers after inserting new headers.
...
Summary: [include-fixer] Sort headers after inserting new headers.
Reviewers: bkramer
Subscribers: klimek, djasper, hokein, cfe-commits
Differential Revision: http://reviews.llvm.org/D20370
llvm-svn: 270031
2016-05-19 08:21:09 +00:00
Benjamin Kramer
5e6b35f4d1
[include-fixer] Also look up prefixes of queries.
...
This is used to find nested classes. For a nested name foo::bar::qux we
will first look up foo::bar::qux, then foo::bar, then foo unless we find
a result. This is used to support nested classes which are not part of
the index but can only be used if the header for the parent context is
included.
Differential Revision: http://reviews.llvm.org/D20372
llvm-svn: 269956
2016-05-18 16:42:38 +00:00
Miklos Vajna
5a6d2985d7
clang-rename: handle non-inline ctor definitions when renaming classes
...
The result of the test was C::D(), not D::D().
Reviewers: cfe-commits, klimek
Differential Revision: http://reviews.llvm.org/D20356
llvm-svn: 269952
2016-05-18 16:12:48 +00:00
Haojian Wu
1bc05a681e
[clang-tidy] Use unresolvedLookupExpr node matcher from ASTMatcher.
...
Reviewers: alexfh, aaron.ballman
Subscribers: aaron.ballman, cfe-commits
Differential Revision: http://reviews.llvm.org/D20367
llvm-svn: 269928
2016-05-18 14:11:20 +00:00
Eric Liu
c7f3b108e2
[clang-include-fixer] Added Vim integration for clang-include-fixer.
...
Summary: [clang-include-fixer] Added Vim integration for clang-include-fixer.
Reviewers: hokein, bkramer
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20329
llvm-svn: 269927
2016-05-18 14:10:16 +00:00
Benjamin Kramer
6b5160a369
[include-fixer] Don't insert #includes if a fatal error occurred.
...
This typically happens when the user didn't setup include paths correctly
and the fixer starts adding garbage includes. Avoid that. Disable the error
limit though, as we might hit that easily with missing includes and still
want to fix those cases.
llvm-svn: 269923
2016-05-18 13:32:38 +00:00
Haojian Wu
4405d5b2cc
[clang-tidy] Fix misc-unused-using-decls test failure in windows
...
buildbot.
llvm-svn: 269918
2016-05-18 13:07:13 +00:00
Haojian Wu
47ea5424d2
[clang-tidy] Fix a template function false positive in misc-unused-using-decls check.
...
Summary: Ignore warning uninstantiated template function usages.
Reviewers: djasper, alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D20326
llvm-svn: 269906
2016-05-18 11:49:34 +00:00
Benjamin Kramer
8b55a2b76c
[clang-tidy] Fix a functional change from r269656.
...
Instead of forming char ranges that patch made us form token ranges,
which behave subtly different. Sadly I'm only seeing this as part of a
larger test case that I haven't fully reduced yet.
llvm-svn: 269896
2016-05-18 09:48:46 +00:00
Benjamin Kramer
2ecd0902c7
[include-fixer] Run tests with -fno-ms-compatibility.
...
Something behind that flag makes us get fewer typo correction callbacks,
unbreak the tests on windows for now.
llvm-svn: 269894
2016-05-18 09:28:45 +00:00
Haojian Wu
ff6d195c2d
[include-fixer] Ignore non-scoped enum declaration during search.
...
Reviewers: bkramer
Subscribers: cfe-commits, ioeric
Differential Revision: http://reviews.llvm.org/D20354
llvm-svn: 269890
2016-05-18 09:04:43 +00:00
NAKAMURA Takumi
e1f0ed0a1f
findAllSymbols: Prune unused libdeps.
...
llvm-svn: 269875
2016-05-18 00:53:31 +00:00
NAKAMURA Takumi
ea46e8b674
FindAllSymbolsTests doesn't require clangToolingCore.
...
llvm-svn: 269874
2016-05-18 00:53:27 +00:00