Daniel Jasper
cf452e5501
Replace callback-if with isExpansionInMainFile as suggested in post
...
commit review.
llvm-svn: 243871
2015-08-03 10:52:27 +00:00
Daniel Jasper
0aeed7c0b8
Add missing 'override'.
...
llvm-svn: 243773
2015-07-31 18:32:38 +00:00
Daniel Jasper
bb42b03021
Add misc-unused-alias-decls check that currently finds unused namespace
...
alias declarations. In the future, we might want to reuse it to also
fine unsed using declarations and such.
llvm-svn: 243754
2015-07-31 16:08:10 +00:00
Alexander Kornienko
b4fbb173f0
[clang-tidy] Support replacements in macro arguments in misc-inefficient-algorithm
...
Summary:
Support replacements in macro arguments in the
misc-inefficient-algorithm check.
Reviewers: klimek
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D11677
llvm-svn: 243747
2015-07-31 13:34:58 +00:00
NAKAMURA Takumi
0dae64a554
Move an extra switch to clang-tools-extra/test/clang-tidy/misc-unused-parameters.cpp from check_clang_tidy.sh.
...
It also rolls back r242984 and r242985.
llvm-svn: 243491
2015-07-28 22:41:04 +00:00
Daniel Jasper
542482e63d
misc-unused-parameters: Only remove parameters in the main source file.
...
In headers, they might always be pulled in to different TUs, even if
they are declared static or nested in an unnamed namespace.
llvm-svn: 243414
2015-07-28 13:19:12 +00:00
Daniel Jasper
718029ba6b
misc-unused-parameters: Properly handle static class members.
...
Not sure why I wrote what I wrote before.
llvm-svn: 243403
2015-07-28 10:39:25 +00:00
Alexander Kornienko
102d2c252a
[clang-tidy] Set current main file name in tests.
...
llvm-svn: 243272
2015-07-27 14:54:31 +00:00
Aaron Ballman
6db02dd8f0
Trying again to a failing test the bots found with r243266.
...
llvm-svn: 243269
2015-07-27 13:59:24 +00:00
Aaron Ballman
84b1b00926
Fixing a failing test the bots found with r243266.
...
llvm-svn: 243268
2015-07-27 13:47:35 +00:00
Daniel Jasper
9fe55a32b7
misc-unused-parameters: Don't warn on ParmVarDecls in the return type.
...
As there don't seem to be a good way of formulating a matcher that
finds all pairs of functions and their ParmVarDecls, just match on
functionDecls and iterate over their parameters. This should also be
more efficient as some checks are only performed once per function.
llvm-svn: 243267
2015-07-27 13:46:37 +00:00
Aaron Ballman
5a4892b4fa
Updating the documentation for clang-tidy. Removes some non-ASCII characters from the documentation, and removes shell-specific single quote characters as they cause issues for some shells (such as on Windows).
...
llvm-svn: 243266
2015-07-27 13:41:30 +00:00
Alexander Kornienko
ae8f23efa8
[clang-tidy] Don't duplicate the leading slash.
...
llvm-svn: 243265
2015-07-27 13:07:50 +00:00
Daniel Jasper
1c6fc3b8f0
misc-unused-parameters: Fix bug where the check was looking at
...
ParmVarDecls of function types.
llvm-svn: 243026
2015-07-23 17:26:36 +00:00
NAKAMURA Takumi
4c8342b73e
Fix the shell script check_clang_tidy.sh in r242984.
...
llvm-svn: 242985
2015-07-23 06:03:40 +00:00
NAKAMURA Takumi
d4ed83aae7
Appease test/clang-tidy/misc-unused-parameters.cpp for targeting *-win32, to add -fno-delayed-template-parsing.
...
Note, clang-tidy tests wouldn't run on Windows hosts since they are disabled with REQUIRES:shell.
The failure would be raised with cross building.
llvm-svn: 242984
2015-07-23 05:52:02 +00:00
Daniel Jasper
9b46e9c5de
misc-unused-parameters: Fix handling of parameters in template functions.
...
The parameters of the function templates were being marked as
incorrectly be marked as unused. Added a test for this and changed the
check to use the same
isReferenced() || !getDeclName()
logic as Sema::DiagnoseUnusedParameters.
Patch Scott Wallace, thank you!
llvm-svn: 242912
2015-07-22 17:30:35 +00:00
Daniel Jasper
82efabbb27
Extend misc-unused-parameters to delete parameters of local functions.
...
Also see: llvm.org/PR24180.
llvm-svn: 242659
2015-07-20 03:42:38 +00:00
Daniel Jasper
9c6df889c4
Initial version of clang-tidy check to find and fix unused parameters.
...
Also see: llvm.org/PR24180.
llvm-svn: 242654
2015-07-20 01:06:44 +00:00
Benjamin Kramer
3204a105e3
[clang-modernize] Don't rely on iterator auto-dereferencing.
...
llvm-svn: 242607
2015-07-18 14:35:41 +00:00
Hans Wennborg
0b1f36e2c8
docs/conf.py: bump version to 3.8
...
llvm-svn: 242247
2015-07-14 23:37:08 +00:00
John Thompson
4018c62428
Added mechanism to modularize for doing a compilation precheck
...
to determine files that have comnpilation or dependency problems.
A new -display-file-lists option use this to display lists of good files
(no compile errors), problem files, and a combined list with
problem files preceded by a '#'. The problem files list can be
used in the module map generation assistant mode to exclude
problem files. The combined files list can be used during module
map development. See added docs.
llvm-svn: 241880
2015-07-10 00:37:25 +00:00
John Thompson
8b629f585d
Fixed line-endings.
...
llvm-svn: 241744
2015-07-08 22:00:56 +00:00
John Thompson
91656d2db6
Fixed erroneous comments.
...
llvm-svn: 241726
2015-07-08 21:05:57 +00:00
John Thompson
ddd7dea4b1
Fixed erroneous comment.
...
llvm-svn: 241724
2015-07-08 20:57:32 +00:00
Yaron Keren
40178c352e
Revert r241330. It compiled with Visual C++ 2013 and gcc 4.9.1 (mingw) but now fails the bots.
...
llvm-svn: 241335
2015-07-03 09:30:33 +00:00
Yaron Keren
452670165c
Replace some const std::string & with llvm::StringRef or std::string
...
and std::move to avoid implicit std::string construction.
Patch by Eugene Kosov.
llvm-svn: 241330
2015-07-03 09:16:20 +00:00
Daniel Marjamaki
e0384e51b0
[clang-tidy] Enhance clang-tidy misc-macro-repeated-side-effects...
...
Enhance clang-tidy misc-macro-repeated-side-effects to handle ? and : better.
When ? is used in a macro, there are 2 possible control flow paths through the macro.
These paths are tracked separately so problems can be detected properly.
http://reviews.llvm.org/D10653
llvm-svn: 241245
2015-07-02 07:49:55 +00:00
Daniel Marjamaki
bf5e59c78b
[clang-tidy] minor coding style tweak. make functions static.
...
llvm-svn: 241160
2015-07-01 13:29:27 +00:00
Alexander Kornienko
6ae400d122
[clang-tidy] Enhance clang-tidy readability-simplify-boolean-expr...
...
Enhance clang-tidy readability-simplify-boolean-expr to handle 'if (e) return
true; return false;' and improve replacement expressions.
This changeset extends the simplify boolean expression check in clang-tidy to
simplify if (e) return true; return false; to return e; (note the lack of an
else clause on the if statement.) By default, chained conditional assignment is
left unchanged, unless a configuration parameter is set to non-zero to override
this behavior.
It also improves the handling of replacement expressions to apply
static_cast<bool>(expr) when expr is not of type bool.
http://reviews.llvm.org/D9810
Patch by Richard Thomson!
llvm-svn: 241155
2015-07-01 12:39:40 +00:00
Daniel Marjamaki
4a38b0b493
[clang-tidy] Fix false positives in the macro parentheses checker
...
Summary:
There were false positives in C++ code where macro argument was a type.
Reviewers: alexfh
Differential Revision: http://reviews.llvm.org/D10801
llvm-svn: 240938
2015-06-29 12:18:11 +00:00
Daniel Marjamaki
91d35a5e22
[clang-tidy] Fix false positives in misc-macro-parentheses checker
...
llvm-svn: 240399
2015-06-23 12:45:14 +00:00
David Blaikie
1f02f962f5
Update for LLVM API change to return by InputArgList directly (rather than by pointer) from ParseArgs
...
llvm-svn: 240348
2015-06-22 22:06:58 +00:00
David Blaikie
faa9280bdc
Update for ParseARgs ArrayRef-ification
...
llvm-svn: 240239
2015-06-21 06:58:19 +00:00
Adrian Prantl
db8ef097be
Add missing dependency clangFrontend to clangQuery.
...
llvm-svn: 240227
2015-06-20 19:28:07 +00:00
Adrian Prantl
51540daec6
Add missing dependency clangFrontend to unit test.
...
llvm-svn: 240226
2015-06-20 19:21:04 +00:00
Justin Bogner
7b92cac037
clang-tidy: Remove an unused private field. NFC
...
Clang was warning on this.
llvm-svn: 239988
2015-06-18 04:15:04 +00:00
Daniel Marjamaki
71c9257f07
clang-tidy: Add checker that warn when macro argument with side effects is repeated in the macro
...
llvm-svn: 239909
2015-06-17 14:19:35 +00:00
Alexander Kornienko
50d7f4617f
[clang-tidy] Move user-defined matches to unnamed namespaces to prevent ODR violations.
...
llvm-svn: 239904
2015-06-17 13:11:37 +00:00
Daniel Marjamaki
302275a938
clang-tidy: Add checker that warns about missing parentheses in macros
...
* calculations in the replacement list should be inside parentheses
* macro arguments should be inside parentheses
llvm-svn: 239820
2015-06-16 14:27:31 +00:00
John Thompson
96f5551b03
Fixed modularize to warn about missing headers referenced in a module map.
...
llvm-svn: 239122
2015-06-04 23:35:19 +00:00
Samuel Benzaquen
cfacf8ae9e
[clang-tidy] Force braces around leaf 'else if' for consistency.
...
Summary:
Force braces around leaf 'else if' for consistency.
This complements r233697.
Reviewers: alexfh
Subscribers: curdeius, cfe-commits
Differential Revision: http://reviews.llvm.org/D10245
llvm-svn: 239054
2015-06-04 16:36:58 +00:00
John Thompson
81cf1e8931
Fixed option description. '=' is required.
...
llvm-svn: 238998
2015-06-04 01:12:56 +00:00
John Thompson
cf777e9f05
Fixed option comment. '=' is required.
...
llvm-svn: 238997
2015-06-04 01:10:19 +00:00
Rafael Espindola
d218565c04
Update for clang API change.
...
Patch by Косов Евгений.
llvm-svn: 238775
2015-06-01 20:00:20 +00:00
Szabolcs Sipos
43a298cb36
[clang-tidy] Fix for llvm.org/PR23355
...
misc-static-assert and misc-assert-side-effect will handle __builtin_expect based asserts correctly.
llvm-svn: 238548
2015-05-29 09:49:59 +00:00
Alexander Kornienko
7ed89bcd3b
[clang-tidy] Renamed misc-noexcept-move-ctors to misc-noexcept-move-constructor
...
llvm-svn: 238326
2015-05-27 14:24:11 +00:00
Alexander Kornienko
bf5bd94142
[clang-tidy] misc-noexcept-move-ctors should ignore implicit constructors and assignments.
...
llvm-svn: 238202
2015-05-26 14:35:09 +00:00
Alexander Kornienko
2b56649cd2
[clang-tidy] Don't issue most google-readability-casting warnings on .c files included in other files.
...
This is done sometimes for testing purposes, and the check needs to handle this
consistently.
llvm-svn: 238193
2015-05-26 10:47:48 +00:00
Szabolcs Sipos
0acf19ed53
[clang-tidy] Fix for llvm.org/PR23572
...
misc-static-assert won't report asserts whose conditions contain calls to non constexpr functions.
llvm-svn: 238098
2015-05-23 14:21:01 +00:00