5 Commits

Author	SHA1	Message	Date
Roman Lebedev	6aa34aadd1	[Sema] -Wtautological-compare: handle comparison of unsigned with 0S. ... Summary: This is a first half(?) of a fix for the following bug: https://bugs.llvm.org/show_bug.cgi?id=34147 (gcc -Wtype-limits) GCC's -Wtype-limits does warn on comparison of unsigned value with signed zero (as in, with 0), but clang only warns if the zero is unsigned (i.e. 0U). Also, be careful not to double-warn, or falsely warn on comparison of signed/fp variable and signed 0. Yes, all these testcases are needed. Testing: $ ninja check-clang-sema check-clang-semacxx Also, no new warnings for clang stage-2 build. Reviewers: rjmccall, rsmith, aaron.ballman Reviewed By: rjmccall Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D37565 llvm-svn: 312750	2017-09-07 22:14:25 +00:00
David Majnemer	6a42665f9f	Revert "Properly consider the range of enum for range comparisons in C mode" ... The approach r183084 took was wrong, back it out. llvm-svn: 183575	2013-06-07 22:07:20 +00:00
David Majnemer	3fbb763a92	Properly consider the range of enum for range comparisons in C mode ... In some cases, clang applies the C++ rules for computing the range of a value when said value is an enum. Instead, apply C semantics when in C mode. llvm-svn: 183084	2013-06-02 08:11:22 +00:00
Fariborz Jahanian	2f4e33aba2	Improvements to my patch in r164143 per ... Richard's comments. // rdar://12202422 llvm-svn: 164316	2012-09-20 19:36:41 +00:00
Fariborz Jahanian	b1885425c4	c: warn when an integer value comparison with an ... integral expression have the obvious result. Patch reviewed by John McCall off line. // rdar://12202422 llvm-svn: 164143	2012-09-18 17:37:21 +00:00