3 Commits

Author	SHA1	Message	Date
Reid Kleckner	bd6942eb21	Re-land "[MS] Fix assert handling enum forward decls in hasVisibleDefinition" ... This reverts commit 9b2ab41037 and reinstates e62dc1f625 with changes. This fix is speculative, since I don't have access to a crashing test case for the old code, and fixing the crash bug on Windows when C++20 is enabled seems more important than running it down.	2020-04-23 16:22:01 -07:00
Rumeet Dhindsa	9b2ab41037	Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition" ... This reverts commit e62dc1f625. Reverting as per discussion with the patch author. This patch causes module import error, but there was no intended behavior change for code that does not use Microsoft extensions.	2020-04-20 10:40:27 -07:00
Reid Kleckner	e62dc1f625	[MS] Fix assert handling enum forward decls in hasVisibleDefinition ... An enum may be considered to be a complete type if it was forward declared. It may be declared with a fixed underlying type, or, in MSVC compatiblity mode, with no type at all. Previously, the code was written with special handling for fixed enums. I generalized the code to check if the underlying integer type is known, which should be the case when targetting the MSVC C++ ABI. Fixes PR45409	2020-04-03 16:46:07 -07:00