19701458d4
[clang][nearly-NFC] Remove some superfluous uses of NamedDecl::getNameAsString
...
`OS << ND->getDeclName();` is equivalent to `OS << ND->getNameAsString();`
without the extra temporary string.
This is not quite a NFC since two uses of `getNameAsString` in a
diagnostic are replaced, which results in the named entity being
quoted with additional "'"s (ie: 'var' instead of var).
2020-08-05 13:54:37 +01:00
86565c1309
Avoid SourceManager.h include in RawCommentList.h, add missing incs
...
SourceManager.h includes FileManager.h, which is expensive due to
dependencies on LLVM FS headers.
Remove dead BeforeThanCompare specialization.
Sink ASTContext::addComment to cpp file.
This reduces the time to compile a file that does nothing but include
ASTContext.h from ~3.4s to ~2.8s for me.
Saves these includes:
219 - ../clang/include/clang/Basic/SourceManager.h
204 - ../clang/include/clang/Basic/FileSystemOptions.h
204 - ../clang/include/clang/Basic/FileManager.h
165 - ../llvm/include/llvm/Support/VirtualFileSystem.h
164 - ../llvm/include/llvm/Support/SourceMgr.h
164 - ../llvm/include/llvm/Support/SMLoc.h
161 - ../llvm/include/llvm/Support/Path.h
141 - ../llvm/include/llvm/ADT/BitVector.h
128 - ../llvm/include/llvm/Support/MemoryBuffer.h
124 - ../llvm/include/llvm/Support/FileSystem.h
124 - ../llvm/include/llvm/Support/Chrono.h
124 - .../MSVCSTL/include/stack
122 - ../llvm/include/llvm-c/Types.h
122 - ../llvm/include/llvm/Support/NativeFormatting.h
122 - ../llvm/include/llvm/Support/FormatProviders.h
122 - ../llvm/include/llvm/Support/CBindingWrapping.h
122 - .../MSVCSTL/include/xtimec.h
122 - .../MSVCSTL/include/ratio
122 - .../MSVCSTL/include/chrono
121 - ../llvm/include/llvm/Support/FormatVariadicDetails.h
118 - ../llvm/include/llvm/Support/MD5.h
109 - .../MSVCSTL/include/deque
105 - ../llvm/include/llvm/Support/Host.h
105 - ../llvm/include/llvm/Support/Endian.h
Reviewed By: aaron.ballman, hans
Differential Revision: https://reviews.llvm.org/D75279
2020-02-27 13:49:40 -08:00
7264a474b7
Change std::{lower,upper}_bound to llvm::{lower,upper}_bound or llvm::partition_point. NFC
...
llvm-svn: 365006
2019-07-03 08:13:17 +00:00
bdc000ea50
[clang][index-while-building][NFC] Comment about implementation detail in FileIndexRecord
...
llvm-svn: 355061
2019-02-28 01:12:27 +00:00
67a1deaa0a
[clang][index-while-building][NFC] FileIndexRecord - Comments, replace auto with type
...
Differential Revision: https://reviews.llvm.org/D58478
llvm-svn: 355036
2019-02-27 21:48:02 +00:00
edbbe470f6
[clang][index-while-building] FileIndexRecord
...
Basic data structures for index
Tests are missing from this patch - will be covered properly by tests for the whole feature.
I'm just trying to split into smaller patches to make it easier for reviewers.
Differential Revision: https://reviews.llvm.org/D58478
llvm-svn: 355035
2019-02-27 21:47:40 +00:00
Bruno Ricci