llvm-project

Commit Graph

Author	SHA1	Message	Date
Reid Kleckner	75b4be9a11	[WinEH] Fix ESP management with 32-bit __CxxFrameHandler3 The C++ EH personality automatically restores ESP from the C++ EH registration node after a catchret. I mistakenly thought it was like SEH, which does not restore ESP. It makes sense for C++ EH to differ from SEH here because SEH does not use funclets for catches, and does not allow catching inside of finally. C++ EH may need to unwind through multiple catch funclets and eventually catchret to some outer funclet. Therefore, the runtime has to keep track of which ESP to use with catchret, rather than having the compiler reload it manually. llvm-svn: 253084	2015-11-13 21:27:00 +00:00
Reid Kleckner	7f84a939ed	[WinEH] Insert the MBB for EH_RESTORE after the catchret Inserting it before the target block could be bad, we might already have a fallthrough edge to it. llvm-svn: 252670	2015-11-10 23:22:20 +00:00

Author

SHA1

Message

Date

Reid Kleckner

75b4be9a11

[WinEH] Fix ESP management with 32-bit __CxxFrameHandler3

The C++ EH personality automatically restores ESP from the C++ EH
registration node after a catchret. I mistakenly thought it was like
SEH, which does not restore ESP.

It makes sense for C++ EH to differ from SEH here because SEH does not
use funclets for catches, and does not allow catching inside of finally.
C++ EH may need to unwind through multiple catch funclets and eventually
catchret to some outer funclet. Therefore, the runtime has to keep track
of which ESP to use with catchret, rather than having the compiler
reload it manually.

llvm-svn: 253084

2015-11-13 21:27:00 +00:00

Reid Kleckner

7f84a939ed

[WinEH] Insert the MBB for EH_RESTORE after the catchret

Inserting it before the target block could be bad, we might already have
a fallthrough edge to it.

llvm-svn: 252670

2015-11-10 23:22:20 +00:00

2 Commits