llvm-project

Commit Graph

Author	SHA1	Message	Date
Rafael Espindola	32483a7641	Make "@name =" mandatory for globals in .ll files. An oddity of the .ll syntax is that the "@var = " in @var = global i32 42 is optional. Writing just global i32 42 is equivalent to @0 = global i32 42 This means that there is a pretty big First set at the top level. The current implementation maintains it manually. I was trying to refactor it, but then started wondering why keep it a all. I personally find the above syntax confusing. It looks like something is missing. This patch removes the feature and simplifies the parser. llvm-svn: 269096	2016-05-10 18:22:45 +00:00
David Majnemer	8b576a579a	IR: SrcTy == DstTy doesn't imply that a cast is valid Cast validity depends on the cast's kind, not just its types. llvm-svn: 229366	2015-02-16 09:37:35 +00:00

Author

SHA1

Message

Date

Rafael Espindola

32483a7641

Make "@name =" mandatory for globals in .ll files.

An oddity of the .ll syntax is that the "@var = " in

@var = global i32 42

is optional. Writing just

global i32 42

is equivalent to

@0 = global i32 42

This means that there is a pretty big First set at the top level. The
current implementation maintains it manually. I was trying to refactor
it, but then started wondering why keep it a all. I personally find the
above syntax confusing. It looks like something is missing.

This patch removes the feature and simplifies the parser.

llvm-svn: 269096

2016-05-10 18:22:45 +00:00

David Majnemer

8b576a579a

IR: SrcTy == DstTy doesn't imply that a cast is valid

Cast validity depends on the cast's kind, not just its types.

llvm-svn: 229366

2015-02-16 09:37:35 +00:00

2 Commits