5 Commits

Author	SHA1	Message	Date
Tom Stellard	c17a04c6c8	ELF: Only unlink regular files ... Summary: If the output file is a character file (e.g. /dev/null) unlinking it could potentially destabilize the user's system. For example, unlinking causes `lld %input -o /dev/null` to replace /dev/null with a regular file, which will lead to unexpected behavior in other programs that read from /dev/null, and worse than expected peformance for programs that write to /dev/null. This makes it possible to run the test-release.sh script as root. Prior to this patch, the ELF/basic.s test would replace /dev/null with a regular file, which would cause crashes in llvm test-suite programs that piped /dev/null to stdin. For example, if you run the test-relase.sh script as root, Reviewers: ruiu Reviewed By: ruiu Subscribers: emaste, llvm-commits Differential Revision: https://reviews.llvm.org/D34917 llvm-svn: 307092	2017-07-04 16:03:34 +00:00
Rui Ueyama	d283eb7091	Make LLD work even if the current directory is not writable. ... llvm-svn: 301423	2017-04-26 16:15:07 +00:00
Rui Ueyama	7163027884	Move code to emit error messages from Filesystem.cpp to Driver.cpp. ... isFileWritable() checked if a file is writable and then emitted an error message if it is not writable. So it did more than the name says. This patch moves error() calls to Driver. llvm-svn: 301422	2017-04-26 16:14:46 +00:00
James Henderson	b7a90ef48e	[ELF] Fail the link early if the map file path is invalid ... As with the changes made in r297645, we do not want a potentially long link to be run, if it will ultimately fail because the map file is not writable. This change reuses the same functionality as the output file path check. See https://reviews.llvm.org/D30449 for further justification and explanations. Reviewers: ruiu Differential Revision: https://reviews.llvm.org/D31603 llvm-svn: 299420	2017-04-04 09:42:24 +00:00
Rui Ueyama	9b55e92a7f	Move a few functions to a new file Filesystem.{cpp,h}. ... llvm-svn: 298667	2017-03-24 00:15:16 +00:00