llvm-project

Commit Graph

Author	SHA1	Message	Date
Dmitry Vyukov	29093488d8	tsan: fix flaky test See the comment for explanation. llvm-svn: 240943	2015-06-29 13:56:31 +00:00
Dmitry Vyukov	7c63340586	tsan: fix handling of dup2 Previously tsan modelled dup2(oldfd, newfd) as write on newfd. We hit several cases where the write lead to false positives: 1. Some software dups a closed pipe in place of a socket before closing the socket (to prevent races actually). 2. Some daemons dup /dev/null in place of stdin/stdout. On the other hand we have not seen cases when write here catches real bugs. So model dup2 as read on newfd instead. llvm-svn: 240687	2015-06-25 20:32:04 +00:00

Author

SHA1

Message

Date

Dmitry Vyukov

29093488d8

tsan: fix flaky test

See the comment for explanation.

llvm-svn: 240943

2015-06-29 13:56:31 +00:00

Dmitry Vyukov

7c63340586

tsan: fix handling of dup2

Previously tsan modelled dup2(oldfd, newfd) as write on newfd.
We hit several cases where the write lead to false positives:
1. Some software dups a closed pipe in place of a socket before closing
   the socket (to prevent races actually).
2. Some daemons dup /dev/null in place of stdin/stdout.
On the other hand we have not seen cases when write here catches real bugs.
So model dup2 as read on newfd instead.

llvm-svn: 240687

2015-06-25 20:32:04 +00:00

2 Commits