llvm-project

Commit Graph

Author	SHA1	Message	Date
Artem Dergachev	a3b22da4e0	[CFG] Fix a flaky crash in CFGBlock::getLastCondition(). Using an end iterator of an empty CFG block was causing a garbage pointer dereference. Differential Revision: https://reviews.llvm.org/D69962	2019-11-21 21:55:58 -08:00
Artem Dergachev	6bbca3411b	[CFG] Add a test for a flaky crash in CFGBlock::getLastCondition(). Push the test separately ahead of time in order to find out whether our Memory Sanitizer bots will be able to find the problem. If not, I'll add a much more expensive test that repeats the current test multiple times in order to show up on normal buildbots. I really apologize for the potential temporary inconvenience! I'll commit the fix as soon as I get the signal. Differential Revision: https://reviews.llvm.org/D69962	2019-11-21 18:11:15 -08:00

Author

SHA1

Message

Date

Artem Dergachev

a3b22da4e0

[CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Using an end iterator of an empty CFG block was causing
a garbage pointer dereference.

Differential Revision: https://reviews.llvm.org/D69962

2019-11-21 21:55:58 -08:00

Artem Dergachev

6bbca3411b

[CFG] Add a test for a flaky crash in CFGBlock::getLastCondition().

Push the test separately ahead of time in order to find out whether
our Memory Sanitizer bots will be able to find the problem.

If not, I'll add a much more expensive test that repeats the current
test multiple times in order to show up on normal buildbots.
I really apologize for the potential temporary inconvenience!
I'll commit the fix as soon as I get the signal.

Differential Revision: https://reviews.llvm.org/D69962

2019-11-21 18:11:15 -08:00

2 Commits