c5928afb69
In the override search for Objective-C methods, protect against ASTs that have NULL interfaces behind a category, which can happen in invalid code. Fixes <rdar://problem/11478173>, a recent regression
...
llvm-svn: 157021
2012-05-17 22:39:14 +00:00
0ebc0fa974
objective-c: perform strict type checking on property
...
type and its accessor type and issue error if types
are incompatible, instead of crashing in IRgen.
// rdar://1105153
llvm-svn: 156871
2012-05-15 22:37:04 +00:00
8e6951d81b
Allow objc @() syntax for enum types.
...
Previously we would reject it as illegal using a value of
enum type and on ObjC++ it was illegal to use an enumerator
as well.
rdar://11454917
llvm-svn: 156843
2012-05-15 19:17:44 +00:00
3da7775a6d
objc: avoid duplicate diagnostics on certain type mismatches
...
between property and its backing ivar.
llvm-svn: 156832
2012-05-15 18:12:51 +00:00
e1ada58ef4
Remove word 'block' from option and diagnostic I added
...
in r156825.
llvm-svn: 156831
2012-05-15 17:43:16 +00:00
80297b1d90
objective-c nonfragile abi: discourage ivar declarations
...
in @interface by issuing warning (off by default) under
opt'ed in flag -Winterface-block-ivar. // rdar://10763173
llvm-svn: 156825
2012-05-15 16:33:04 +00:00
16d71bb834
objc: allow typedef'ing an id to a pointer to a c-struct only.
...
// rdar://11356439
llvm-svn: 156788
2012-05-14 22:48:56 +00:00
4af4487ba4
Only check NSArray/NSDictionary boxing method params once.
...
Once we've found a "good" method, we don't need to check its argument types
again. (Even if we might have later found a "bad" method, we were already
caching the method we first looked up.)
llvm-svn: 156719
2012-05-12 17:32:56 +00:00
890f4577b1
Don't crash on boxed strings when +stringWithUTF8String: is missing.
...
Also, unify some diagnostics for boxed expressions that have the same form.
Fixes PR12804.
llvm-svn: 156713
2012-05-12 15:53:41 +00:00
9b4fe35689
Don't crash when using objc boxed expression with parsing error.
...
rdar://11426994
llvm-svn: 156565
2012-05-10 20:02:36 +00:00
0bd3e404af
Bind cleanups after doing l2r conversion on the operand of a
...
@throw expression; l2r conversion can introduce new cleanups
in certain cases, like when the expression is an ObjC property
reference of retainable type in ARC.
llvm-svn: 156425
2012-05-08 21:41:25 +00:00
2b7da83759
Inhibit ObjC format warning only in system headers (NSLocalizedString).
...
Add a test case for the related NSAssert workaround.
llvm-svn: 156205
2012-05-04 21:08:08 +00:00
d5f34f9fee
objective-c: warn for properties being default synthesized
...
under -Wobjc-missing-property-synthesis which must be
opted-in. // rdar://11295716
llvm-svn: 156078
2012-05-03 16:43:30 +00:00
169ec35bb3
Add a missing RequireCompleteType call when synthesizing properties. <rdar://problem/11333367>.
...
While I'm here, fix source locations for other diagnostics related to property synthesis.
llvm-svn: 155953
2012-05-01 22:26:06 +00:00
afd3d0ba40
Fix test cases broken by 155936.
...
llvm-svn: 155948
2012-05-01 21:29:03 +00:00
124066c5cb
Place several uncovered warnings under warning flags, and tweak diagnostic output including the term "gc" (in lowercase).
...
llvm-svn: 155892
2012-05-01 05:56:02 +00:00
08a1eb77c5
with -Wdeprecated, include a note to its deprecated declaration
...
location. // rdar://10893232
llvm-svn: 155385
2012-04-23 20:30:52 +00:00
344d65c248
objective-c arc: With currnt documentation,
...
objc_returns_inner_pointer attribute can be applied to
methods only. Diagnsose otherwise, instead of
crashing. // rdar://11253688
llvm-svn: 155245
2012-04-20 22:00:46 +00:00
d155c78d18
objective-arc: Retune my previous patch so warning
...
is issued on weak property as receiver and not on
any other use of a weak property. // rdar://10225276
llvm-svn: 155169
2012-04-19 23:49:39 +00:00
fce89c609d
objective-c arc: Issue warning under -Wreceiver-is-weak
...
if receiver is a 'weak' property, by type or by attribute.
// rdar://10225276
llvm-svn: 155159
2012-04-19 21:44:57 +00:00
0caa39474b
Implements boxed expressions for Objective-C. <rdar://problem/10194391>
...
llvm-svn: 155082
2012-04-19 00:25:12 +00:00
b525b52987
objective-c: Issue diagnostic when an implicit
...
property accessor (getter) missing, instead of crashing.
// rdar://11273060
llvm-svn: 155036
2012-04-18 19:13:23 +00:00
29898f4565
objective-c modern translator: buildit objc bool
...
type for rewriter project will be BoolTy.
// rdar://11231426.
llvm-svn: 154861
2012-04-16 21:03:30 +00:00
d239387098
When we're flagging a protected scope to prevent jumps into the
...
shadow of a block expression with non-trivial destructed cleanups,
we should flag that in the enclosing function, not in the block
that we're about to pop.
llvm-svn: 154646
2012-04-13 01:08:17 +00:00
e2b037d6ea
objective-c literals: Issue warning and ignore
...
when BOOL is not of an intergal type when
boolean literals are used. // rdar://11231426
llvm-svn: 154619
2012-04-12 21:24:56 +00:00
acfbe9e1f2
Added a new attribute, objc_root_class, which informs the compiler when a root class is intentionally declared.
...
The warning this inhibits, -Wobjc-root-class, is opt-in for now. However, all clang unit tests that would trigger
the warning have been updated to use -Wno-objc-root-class. <rdar://problem/7446698>
llvm-svn: 154187
2012-04-06 18:12:22 +00:00
c806b90717
objective-c: Don't warn when a category does not implement a method
...
declared in its adopted protocol when another category declares it
because that category will implement it. // rdar://11186449
llvm-svn: 154132
2012-04-05 22:14:12 +00:00
6bd2226037
objc-arc: provide a warning when 'receiver' of a message is 'weak'
...
in arc mode and opted-in with -Wreceiver-is-weak flag.
// rdar://10225276
llvm-svn: 154042
2012-04-04 20:05:25 +00:00
bc15335e58
Handle placeholder expressions in an ObjC for-collection loop.
...
The way we handle this implicitly removes the ability to use
property l-values in this position, but that's really okay.
llvm-svn: 153729
2012-03-30 05:43:39 +00:00
67cd5e094e
Forbid the block and lambda copy-capture of __autoreleasing variables
...
in ARC, under the usual reasoning limiting the use of __autoreleasing.
llvm-svn: 153725
2012-03-30 05:23:48 +00:00
410fc7ae89
Make sure we perform the relevant implied conversions correctly for ObjC methods with related result types. PR12384.
...
llvm-svn: 153716
2012-03-30 01:13:43 +00:00
e798ba4b67
Fix typo in my last patch.
...
llvm-svn: 153602
2012-03-28 21:13:53 +00:00
ba0afde486
objective-c: Improve diagnostics and
...
provide 'fixit' hint when dictionary index
is not of proper type. // rdar://11062080
llvm-svn: 153584
2012-03-28 17:56:49 +00:00
822c433a27
Make sure we don't accept an @interface inside another objc container
...
just because there was an attribute in front of it.
llvm-svn: 153355
2012-03-23 23:24:23 +00:00
c08c475fe0
Support '%p' format specifier with block pointers.
...
llvm-svn: 152839
2012-03-15 21:22:27 +00:00
3b60cffa22
Fix crash at @implementation with a forward reference as base class.
...
rdar://11020003
llvm-svn: 152596
2012-03-13 01:09:36 +00:00
c5b0552055
Fix parsing of type-specifier-seq's. Types are syntactically allowed to be
...
defined here, but not semantically, so
new struct S {};
is always ill-formed, even if there is a struct S in scope.
We also had a couple of bugs in ParseOptionalTypeSpecifier caused by it being
under-loved (due to it only being used in a few places) so merge it into
ParseDeclarationSpecifiers with a new DeclSpecContext. To avoid regressing, this
required improving ParseDeclarationSpecifiers' diagnostics in some cases. This
also required teaching ParseSpecifierQualifierList about constexpr... which
incidentally fixes an issue where we'd allow the constexpr specifier in other
bad places.
llvm-svn: 152549
2012-03-12 07:56:15 +00:00
c8a322a407
lldb support: under debugger support flag, when sending message
...
to forward class, and assigning to an 'id' type var, message
sends default to 'id'. // rdar"//10988847
llvm-svn: 152420
2012-03-09 18:47:16 +00:00
85110b47c8
Don't crash when a statement in a block is ill-formed but
...
introduces cleanups anyway.
llvm-svn: 152345
2012-03-08 22:00:17 +00:00
d6cb4a858d
objective-c lldb support: don't perform ivar access control check
...
when debugging. // rdar://10997647
llvm-svn: 152187
2012-03-07 00:58:41 +00:00
5022f1dffe
Fix horrific CFG bug where '@autoreleasepool' would be put in a dangling block in the CFG.
...
llvm-svn: 152163
2012-03-06 23:40:47 +00:00
e65b086e07
Add clang support for new Objective-C literal syntax for NSDictionary, NSArray,
...
NSNumber, and boolean literals. This includes both Sema and Codegen support.
Included is also support for new Objective-C container subscripting.
My apologies for the large patch. It was very difficult to break apart.
The patch introduces changes to the driver as well to cause clang to link
in additional runtime support when needed to support the new language features.
Docs are forthcoming to document the implementation and behavior of these features.
llvm-svn: 152137
2012-03-06 20:05:56 +00:00
7923ef41e1
objc: When issue diagnostic about deprecated method, also
...
issue the note if it is because message is sent to a forward class
declaration in delayed diagnostic. // rdar://10290322
llvm-svn: 151942
2012-03-02 21:50:02 +00:00
4af2cb3355
[Sema] Fix crash-on-invalid-code issue:
...
@class I;
@implementation I(cat) // crashes here
@end
rdar://10968158
llvm-svn: 151931
2012-03-02 19:14:29 +00:00
05e916bc95
Fix regression from llvm-gcc where we should NOT emit a warning about __attribute__((NSObject)) on a property declaration. This is needed to have retain properties for non-object pointers. Fixes <rdar://problem/10930507>.
...
llvm-svn: 151786
2012-03-01 01:40:32 +00:00
86c2f5cc70
objective-c: provide fixit hint when atomic property does not
...
have matching user defined setter/getter and a warning is issued.
In this case, a fixit note is displayed. // rdar://10267155
llvm-svn: 151766
2012-02-29 22:18:55 +00:00
59b10db2bc
After numerous requests, have Objective-C 'method declared here' notes mention the actual method. This looks better within an IDE, where text isn't always regurgitated in the presentation of a warning. Fixes radar 10914035.
...
llvm-svn: 151579
2012-02-27 22:55:11 +00:00
8a78a58188
Improve the diagnostic in ARC mode when a conditional with an Objective-C type and void* is used. <rdar://problem/10486347>.
...
llvm-svn: 151416
2012-02-25 00:23:44 +00:00
ec52f92db3
Handle "#pragma GCC visibility" in a few more places. Switch over "#pragma pack" to use the same handling that gcc does. Fixes <rdar://problem/10871094> and <rdar://problem/10893316>.
...
(Hopefully, common usage of these pragmas isn't irregular enough to break our current handling. Doug has ideas for a more crazy approach if necessary.)
llvm-svn: 151307
2012-02-23 23:47:16 +00:00
86f8266b9f
objective-c++: Type of an objc string literal is NSString, not 'id'.
...
// rdar://10907410
llvm-svn: 151296
2012-02-23 22:51:36 +00:00
24992371a5
Don't crash on attempts to synthesize an invalid property.
...
rdar://problem/10904479
llvm-svn: 151089
2012-02-21 21:48:05 +00:00
58dab6829a
When calling a non variadic format function(vprintf, vscanf, NSLogv, …), warn if the format string argument is a parameter that is not itself declared as a format string with compatible format.
...
llvm-svn: 151080
2012-02-21 20:00:53 +00:00
084e1b48a1
Change wording of warning about using __bridge casts in non-ARC.
...
llvm-svn: 150868
2012-02-18 04:42:38 +00:00
6eb25628c5
Revert r145999. This turned out to be a bad idea. Unfortunately, 'id' is used so profusely
...
in many APIs and large codebases that this made the deprecated warning trigger happy to
the point of not being useful.
llvm-svn: 150223
2012-02-10 02:45:47 +00:00
29082a5f1d
objc: If a method is not implemented in the category implementation but
...
has been declared in its primary class, superclass,
or in one of their protocols, no need to issue unimplemented method.
// rdar://10823023
llvm-svn: 150206
2012-02-09 21:30:24 +00:00
5ece54ce3f
Only complain about __strong __strong id, not __strong SomeStrongTypedef
...
or __strong __typeof__(some.strong.thing).
llvm-svn: 150029
2012-02-08 00:46:41 +00:00
b6c6a58366
Make parsing of objc @implementations more robust.
...
Parsing of @implementations was based on modifying global state from
the parser; the logic for late parsing of methods was spread in multiple places
making it difficult to have a robust error recovery.
-it was difficult to ensure that we don't neglect parsing the lexed methods.
-it was difficult to setup the original objc container context for parsing the lexed methods
after completing ParseObjCAtImplementationDeclaration and returning to top level context.
Enhance parsing of @implementations by centralizing it in Parser::ParseObjCAtImplementationDeclaration().
ParseObjCAtImplementationDeclaration now returns only after an @implementation is fully parsed;
all the data and logic for late parsing of methods is now in one place.
This allows us to provide code-completion for late parsed methods with mis-matched braces.
rdar://10775381
llvm-svn: 149987
2012-02-07 16:50:53 +00:00
2beed114ba
Fix a couple of nasty bugs involving negative enum constants. <rdar://problem/10760113>.
...
llvm-svn: 149965
2012-02-07 04:34:38 +00:00
d22b98aad2
Tweak format string checking to work with %@ and ObjC toll-free bridging. <rdar://problem/10814120>
...
llvm-svn: 149907
2012-02-06 21:45:29 +00:00
adfe905145
objc: fixes a problem in block type comparison involving
...
enums with underlying type explicitly specified
(feature which is on by default in objective-c).
// rdar://10798770
llvm-svn: 149888
2012-02-06 19:06:20 +00:00
8870a32408
Fixed some testsuite problems introduced by my
...
last commit. Sorry for the outage.
llvm-svn: 149744
2012-02-04 02:28:18 +00:00
d1928cb912
Revert r149721. chapuni tells me akyrtzi already fixed the test
...
by adding a triple, and the typedef makes things worse on windows.
llvm-svn: 149740
2012-02-04 01:50:30 +00:00
1ce3a6b650
Clang has existing support for debuggers that
...
want to provide "po"-like functionality which
treats the result of an expression implicitly as
"id" (if it is not otherwise known) and prints
it as an Objective-C object.
This has in the past been gated by the
"DebuggerSupport" language option, but that is
too general. Debuggers also provide other commands
like "print" that do not make any assumptions
about whether the object is an Objective-C object.
This patch makes the assumption conditional on a
new language option: DebuggerCastResultToId. I
have also made corresponding modifications to the
testsuite.
llvm-svn: 149735
2012-02-04 01:29:37 +00:00
bf5e6442e7
Try to get test passing on windows.
...
Idea by Jean-Daniel Dupas.
llvm-svn: 149721
2012-02-03 23:36:13 +00:00
e340deedbf
Add a triple to test/SemaObjC/format-strings-objc.m to make it pass in windows hosts.
...
llvm-svn: 149696
2012-02-03 17:13:43 +00:00
60bbeb345b
Further downgrade -Warc-bridge-casts-disallowed-in-nonarc to a warning (not mapped to an error). We can consider mapping it back to an error later.
...
llvm-svn: 149670
2012-02-03 05:01:51 +00:00
172039a89c
Make error about using bridge casts in non-ARC mode a warning that is default mapped to an error. This is to ease the transition of large apps moving from non-ARC to ARC.
...
llvm-svn: 149659
2012-02-03 01:30:34 +00:00
c934de67e0
objc: Issue diagnostic when receiver type is a forward class declaration and
...
it is treated as of 'id' type resulting in multiple method lookup.
// rdar://10686120
llvm-svn: 149653
2012-02-03 01:02:44 +00:00
6a73384b53
objective-c: When redeclaraing in continuation class a 'readonly'
...
property to 'readwrite', also allow redeclaration of
property type to a narrowring object type.
// rdar://10790488
llvm-svn: 149614
2012-02-02 18:54:58 +00:00
17612b1dbf
objc: don't crash if primary class is missing and continuation class
...
is declaring ivars. // rdar://10752081
llvm-svn: 149573
2012-02-02 00:49:12 +00:00
ccded6e447
objc2: add __has_feature(objc_default_synthesize_properties).
...
// rdar://10770497
llvm-svn: 149565
2012-02-02 00:15:51 +00:00
30febeb224
Look for declaration of CFBridgingRetain/CFBridgingRetain before
...
changing the diagnostic. Also use correct spelling for both.
llvm-svn: 149554
2012-02-01 22:56:20 +00:00
bcdc282d85
objc-arc: In various diagnostics mention
...
CFBridgingRetain/CFBridgingRelease calls instead
of __bridge_retained/__bridge_transfer casts as preferred
way of moving cf objects to arc land. // rdar://10207950
llvm-svn: 149449
2012-01-31 23:42:37 +00:00
496cdc2cb7
Let %S, %ls, %C match 16bit types in NSStrings.
...
As discussed at http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120130/052200.html
llvm-svn: 149325
2012-01-31 01:43:25 +00:00
537aa1ac68
Disable "non literal format string" for NSString that result from a macro expansion.
...
This is to prevent diagnostic when using NSLocalizedString or CFCopyLocalizedString
macros which are usually used in place of NS and CF strings literals.
llvm-svn: 149268
2012-01-30 19:46:17 +00:00
028573e794
Update on format attribute handling.
...
- Remove the printf0 special handling as we treat it as printf anyway.
- Perform basic checks (non-literal, empty) for all formats and not only printf/scanf.
llvm-svn: 149236
2012-01-30 08:46:47 +00:00
400dd1c3d0
Remove the "C" in "implicitly declaring C library function" diagnostic
...
because all functions are not C functions (i.e. NSLog).
llvm-svn: 149150
2012-01-27 23:21:02 +00:00
18a962bab5
Don't suppress access-control or invalid-type diagnostics from a
...
declarator just because we were able to build an invalid decl
for it. The invalid-type diagnostics, in particular, are still useful
to know, and may indicate something about why the decl is invalid.
Also, recover from an illegal pointer/reference-to-unqualified-retainable
type using __strong instead of __autoreleasing; in general, a random
object is much more likely to be __strong, so this avoids unnecessary
cascading errors in the most common case.
llvm-svn: 149074
2012-01-26 20:04:03 +00:00
194904e499
objc: 'id' and block pointer compare in mergeTypes is
...
made symmetrical. // rdar://10734265
llvm-svn: 149065
2012-01-26 17:08:50 +00:00
26d8371b07
objc: allow block pointer matching 'id' type when
...
they show up as argument types of two block pointers.
// rdar://10734265
llvm-svn: 149007
2012-01-26 00:45:38 +00:00
d5f7ef48e2
Add support for const pointer to literal-objc string as format attribute.
...
llvm-svn: 148948
2012-01-25 10:35:33 +00:00
9aa95b16e1
Fix test on cygwin (where va_list expands to a different type)
...
llvm-svn: 148892
2012-01-25 01:02:26 +00:00
9b1f3d46d0
Fix NSLog format string checking for %@.
...
llvm-svn: 148885
2012-01-25 00:04:09 +00:00
78536ae5b5
Replace a hack to handle NSLog/NSLogv in sema by declaring them as Library Builtins.
...
llvm-svn: 148873
2012-01-24 22:32:46 +00:00
5778cb8e06
Remove trailing slash in front of header name of ObjC builtins.
...
llvm-svn: 148872
2012-01-24 22:29:27 +00:00
e2a7776eff
objc: Issue a generic diagnostic assigning to
...
an objc object in any abi mode.
llvm-svn: 148847
2012-01-24 19:40:13 +00:00
04c4455dd4
objective-c: Ignore with warning forward class declaration whose name
...
matches a typedef declaring an object type. // rdar://10733000
llvm-svn: 148760
2012-01-24 00:40:15 +00:00
e7b9d4342b
Tighten format string diagnostic and make it a bit clearer (and a bit closer to GCC's).
...
llvm-svn: 148579
2012-01-20 21:52:58 +00:00
28324b0066
objc: deprecate direct usage of 'isa' of objc objects
...
in favor of usage of api's intended for.
// rdar://8290002
llvm-svn: 148404
2012-01-18 19:08:56 +00:00
c72a807039
objc-arc: when 'assign' attribute is unspecified,
...
rely on property's type for its life-time to avoid
bogus warning with -Warc-unsafe-retained-assign.
// rdar://10694932
llvm-svn: 148355
2012-01-17 22:58:16 +00:00
206e2302eb
Disable -Wduplicate-method-match by default. <rdar://problem/10663536>
...
llvm-svn: 148343
2012-01-17 22:24:32 +00:00
0ae6e671cc
Fix a couples of issues in format strings checking.
...
PR 10274: format function attribute with the NSString archetype yields no compiler warnings
PR 10275: format function attribute isn't checked in Objective-C methods
llvm-svn: 148324
2012-01-17 20:03:31 +00:00
9d7cf2baaf
objc: fixes a bug where struct used inside an
...
objc class was not being exported to parent decl
context resulting in bogus mismatch warning later on.
// rdar://10655530
llvm-svn: 148320
2012-01-17 18:52:07 +00:00
52d02f68e5
objc: disallow __block attribute on method params.
...
llvm-svn: 148197
2012-01-14 18:44:35 +00:00
372030b2a1
objc parsing. Fixes a crash when parsing array initialization
...
inside a class implementation with parse errors. // rdar://10633434
llvm-svn: 148074
2012-01-13 00:14:12 +00:00
e74d47ed03
objc: do not warn when converting to a const id qualfied by its
...
list of protools. // rdar://10669694
llvm-svn: 148051
2012-01-12 22:12:08 +00:00
4f8cb1e83a
objective-c: fixes a regression in looking up names
...
in class extensions and categories by recent refactoring
of objc class ASTs. // rdar://1066654
llvm-svn: 147982
2012-01-12 00:18:35 +00:00
39ba639f9d
objc-arc: evaluate 'readonly' property with no known
...
life-time to that of its backing 'ivar's lifetime.
// rdar://10558871
llvm-svn: 147956
2012-01-11 18:26:06 +00:00
9b80c2186f
Do placeholder conversions on array bounds in both declarators and
...
new-expressions.
llvm-svn: 147900
2012-01-11 00:14:46 +00:00
edbc345170
objc-arc: fixes a crash when trying to find out retaining cycle
...
ownership of property sent to 'super'. // rdar://10640891
llvm-svn: 147868
2012-01-10 19:28:26 +00:00
Douglas Gregor