llvm-project

Commit Graph

Author	SHA1	Message	Date
Florian Hahn	8eeabbaf5d	[ConstantFold] Handle identity folds at top of ConstantFoldBinaryInst Currently we miss folds with undef and identity values for binary ops that do not fold to undef in general. We can generalize the identity simplifications and do them before checking for undef in particular. Alive checks: * OR - https://rise4fun.com/Alive/8OsK * AND - https://rise4fun.com/Alive/e3tE This will also allow us to remove some now redundant cases throughout the function, but I would like to do this as follow-up. That should make tracking down potential issues easier. Reviewers: spatel, RKSimon, lebedev.ri Reviewed By: spatel Differential Revision: https://reviews.llvm.org/D70169	2019-11-17 21:30:14 +00:00
Florian Hahn	28c183859a	[ConstantFold] Add some tests for binops with constants and undefs. Precommit tests for D70169.	2019-11-17 21:10:45 +00:00

Author

SHA1

Message

Date

Florian Hahn

8eeabbaf5d

[ConstantFold] Handle identity folds at top of ConstantFoldBinaryInst

Currently we miss folds with undef and identity values for binary ops
that do not fold to undef in general.

We can generalize the identity simplifications and do them before
checking for undef in particular.

Alive checks:
 * OR - https://rise4fun.com/Alive/8OsK
 * AND - https://rise4fun.com/Alive/e3tE

This will also allow us to remove some now redundant cases throughout
the function, but I would like to do this as follow-up. That should make
tracking down potential issues easier.

Reviewers: spatel, RKSimon, lebedev.ri

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D70169

2019-11-17 21:30:14 +00:00

Florian Hahn

28c183859a

[ConstantFold] Add some tests for binops with constants and undefs.

Precommit tests for D70169.

2019-11-17 21:10:45 +00:00

2 Commits