llvm-project

Commit Graph

Author	SHA1	Message	Date
Benjamin Kramer	bc1ea2a2c5	Replicate attributes on definition to make MSVC less noisy warning C4565: 'llvm::allocate_buffer': redefinition; the symbol was previously declared with __declspec(restrict)	2020-04-25 02:02:00 +02:00
Benjamin Kramer	7aaff8fd2d	[ADT] Move allocate_buffer to MemAlloc.h and out of line There's an ABI breakage here if LLVM is compiled in C++14 without aligned allocation and a user tries to use the result with aligned allocation. If DenseMap or unique_function is used across that ABI boundary it will break (PR45413). Moving it out of line is a bit of a band-aid and LLVM doesn't really give ABI guarantees at this level, but given the number of complaints I've received over this it still seems worth fixing.	2020-04-24 13:32:50 +02:00

Author

SHA1

Message

Date

Benjamin Kramer

bc1ea2a2c5

Replicate attributes on definition to make MSVC less noisy

warning C4565: 'llvm::allocate_buffer': redefinition; the symbol was previously declared with __declspec(restrict)

2020-04-25 02:02:00 +02:00

Benjamin Kramer

7aaff8fd2d

[ADT] Move allocate_buffer to MemAlloc.h and out of line

There's an ABI breakage here if LLVM is compiled in C++14 without
aligned allocation and a user tries to use the result with aligned
allocation. If DenseMap or unique_function is used across that ABI
boundary it will break (PR45413). Moving it out of line is a bit of
a band-aid and LLVM doesn't really give ABI guarantees at this level,
but given the number of complaints I've received over this it still
seems worth fixing.

2020-04-24 13:32:50 +02:00

2 Commits