llvm-project

Commit Graph

Author	SHA1	Message	Date
Michael Jones	8a4ee3550b	[libc] Make more of the libc unit testing llvm independent (WIP, hopefully I'll add more to this patch before submitting) Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D91665	2020-11-21 00:27:08 +00:00
Paula Toth	bf6f3894c4	[libc] Fix warnings on release build. Summary: These warnings were present when building llvm-libc in release mode. ``` workspace/llvm-project/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp:50:34: warning: 'None' is deprecated: Use Align() or Align(1) instead [-Wdeprecated-declarations] Conf.AddressAlignment = Align::None(); workspace/llvm-project/libc/utils/testutils/FDReaderUnix.cpp:19:7: warning: unused variable 'err' [-Wunused-variable] int err = ::pipe(pipefd); ``` For test-utils it seems in general we should use `report_fatal_error` instead of asserts as these are turned off when building in release mode. https://llvm.org/docs/CodingStandards.html#assert-liberally Reviewers: abrachet, sivachandra Reviewed By: abrachet, sivachandra Subscribers: tschuett, libc-commits Tags: #libc-project Differential Revision: https://reviews.llvm.org/D79469	2020-05-07 11:56:11 -07:00
Alex Brachet	5793c84925	[libc] Add write(2) implementation for Linux and FDReader test utility Summary: Adds `write` for Linux and FDReader utility which should be useful for some stdio tests as well. Reviewers: sivachandra, PaulkaToast Reviewed By: sivachandra Subscribers: mgorny, tschuett, libc-commits Differential Revision: https://reviews.llvm.org/D78184	2020-04-17 13:21:05 -04:00

Author

SHA1

Message

Date

Michael Jones

8a4ee3550b

[libc] Make more of the libc unit testing llvm independent

(WIP, hopefully I'll add more to this patch before submitting)

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D91665

2020-11-21 00:27:08 +00:00

Paula Toth

bf6f3894c4

[libc] Fix warnings on release build.

Summary:
These warnings were present when building llvm-libc in release mode.

```
workspace/llvm-project/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp:50:34: warning: 'None' is deprecated: Use Align() or Align(1) instead [-Wdeprecated-declarations]
  Conf.AddressAlignment = Align::None();

workspace/llvm-project/libc/utils/testutils/FDReaderUnix.cpp:19:7: warning: unused variable 'err' [-Wunused-variable]
  int err = ::pipe(pipefd);
```

For test-utils it seems in general we should use `report_fatal_error` instead of asserts as these are turned off when building in release mode.
https://llvm.org/docs/CodingStandards.html#assert-liberally

Reviewers: abrachet, sivachandra

Reviewed By: abrachet, sivachandra

Subscribers: tschuett, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D79469

2020-05-07 11:56:11 -07:00

Alex Brachet

5793c84925

[libc] Add write(2) implementation for Linux and FDReader test utility

Summary: Adds `write` for Linux and FDReader utility which should be useful for some stdio tests as well.

Reviewers: sivachandra, PaulkaToast

Reviewed By: sivachandra

Subscribers: mgorny, tschuett, libc-commits

Differential Revision: https://reviews.llvm.org/D78184

2020-04-17 13:21:05 -04:00

3 Commits