5 Commits

Author	SHA1	Message	Date
Jordan Rose	b1e3e5f553	-Warc-repeated-use-of-weak: fix a use-of-uninitialized and add a test case. ... Fix-up for r165718, should get the buildbots back online. llvm-svn: 165723	2012-10-11 17:02:00 +00:00
Jordan Rose	2248765591	-Warc-repeated-use-of-weak: Check messages to property accessors as well. ... Previously, [foo weakProp] was not being treated the same as foo.weakProp. Now, for every explicit message send, we check if it's a property access, and if so, if the property is weak. Then for every assignment of a message, we have to do the same thing again. This is a potentially expensive increase because determining whether a method is a property accessor requires searching through the methods it overrides. However, without it -Warc-repeated-use-of-weak will miss cases from people who prefer not to use dot syntax. If this turns out to be too expensive, we can try caching the result somewhere, or even lose precision by not checking superclass methods. The warning is off-by-default, though. <rdar://problem/12407765> llvm-svn: 165718	2012-10-11 16:06:21 +00:00
Jordan Rose	e723a27ffe	-Warc-repeated-use-of-weak: look through explicit casts on assigned values. ... Reading from a weak property, casting the result, and assigning to a strong pointer should still be considered safe. llvm-svn: 165629	2012-10-10 16:43:06 +00:00
Anna Zaks	97c7ce3368	Move isObjCSelf into Expr. ... llvm-svn: 164966	2012-10-01 20:34:04 +00:00
Jordan Rose	62b379873d	Pull ScopeInfo implementation into its own file. ... The infrastructure for -Warc-repeated-use-of-weak got a little too heavy to leave sitting at the top of Sema.cpp. No functionality change. llvm-svn: 164856	2012-09-28 22:21:39 +00:00