6f85ef300d
[msan] Mostly disable msan-handle-icmp-exact.
...
It is way too slow. Change the default option value to 0.
Always do exact shadow propagation for unsigned ICmp with constants, it is
cheap (under 1% cpu time) and required for correctness.
llvm-svn: 173682
2013-01-28 11:42:28 +00:00
fac8403249
[msan] Implement exact shadow propagation for relational ICmp.
...
Only for integers, pointers, and vectors of those. No floats.
Instrumentation seems very heavy, and may need to be replaced
with some approximation in the future.
llvm-svn: 173452
2013-01-25 15:31:10 +00:00
87191f6221
[asan] adaptive redzones for globals (the larger the global the larger is the redzone)
...
llvm-svn: 173335
2013-01-24 10:35:40 +00:00
c4415591ed
[msan] Do not insert check on volatile store.
...
Volatile bitfields can cause valid stores of uninitialized bits.
llvm-svn: 173153
2013-01-22 12:30:52 +00:00
1345d35e40
ASan: wrap mapping scale and offset in a struct and make it a member of ASan passes. Add test for non-default mapping scale and offset. No functionality change
...
llvm-svn: 172610
2013-01-16 13:23:28 +00:00
701d2b861e
[msan] Temporarily remove ICmpEQ tests.
...
They are failing on the bots.
llvm-svn: 172540
2013-01-15 17:12:04 +00:00
d14e47b146
[msan] Fix handling of equality comparison of pointer vectors.
...
Also improve test coveration of the handling of relational comparisons.
llvm-svn: 172539
2013-01-15 16:44:52 +00:00
f7d65c43d0
[msan] Change va_start/va_copy shadow memset alignment to 8.
...
This fixes va_start/va_copy of a va_list field which happens to not
be laid out at a 16-byte boundary.
Differential Revision: http://llvm-reviews.chandlerc.com/D276
llvm-svn: 172128
2013-01-10 22:36:33 +00:00
29dd7f2090
[ASan] Fix lifetime intrinsics handling. Now for each intrinsic we check if it describes one of 'interesting' allocas. Assume that allocas can go through casts and phi-nodes before apperaring as llvm.lifetime arguments
...
llvm-svn: 171153
2012-12-27 08:50:58 +00:00
5eb5bf8b46
[msan] Raise alignment of origin stores/loads when possible.
...
Origin alignment is as high as the alignment of the corresponding application
location, but never less than 4.
llvm-svn: 171110
2012-12-26 11:55:09 +00:00
f19c086d1e
[msan] Fix handling of vectors of pointers.
...
VectorType::getInteger() can not be used with them, because pointer size
depends on the target.
llvm-svn: 171070
2012-12-25 16:04:38 +00:00
ec8371283b
[msan] Fix handling of select with vector condition.
...
llvm-svn: 171069
2012-12-25 14:56:21 +00:00
4fbc0d08bf
[msan] Remove unreachable blocks before instrumenting a function.
...
llvm-svn: 170883
2012-12-21 11:18:49 +00:00
d7571cd4bc
[msan] Heuristically instrument unknown intrinsics.
...
This changes adds shadow and origin propagation for unknown intrinsics
by examining the arguments and ModRef behaviour. For now, only 3 classes
of intrinsics are handled:
- those that look like simple SIMD store
- those that look like simple SIMD load
- those that don't have memory effects and look like arithmetic/logic/whatever
operation on simple types.
llvm-svn: 170530
2012-12-19 11:22:04 +00:00
49175b237d
[msan] Origin stores and loads do not need explicit alignment.
...
Origin address is always 4 byte aligned, and the access type is always i32.
llvm-svn: 170199
2012-12-14 13:43:11 +00:00
3d43b63a6e
Improve debug info generated with enabled AddressSanitizer.
...
When ASan replaces <alloca instruction> with
<offset into a common large alloca>, it should also patch
llvm.dbg.declare calls and replace debug info descriptors to mark
that we've replaced alloca with a value that stores an address
of the user variable, not the user variable itself.
See PR11818 for more context.
llvm-svn: 169984
2012-12-12 14:31:53 +00:00
4f220d96c5
[msan] Do not store origin for clean values.
...
Instead of unconditionally storing origin with every application store,
only do this when the shadow of the stored value is != 0.
This change also delays instrumentation of stores until after the walk over
function's instructions, because adding new basic blocks confuses InstVisitor.
We only keep 1 origin value per 4 bytes of application memory. This change
fixes the bug when a store of a single clean byte wiped the origin for the
whole 4-byte area.
Since stores of uninitialized values are relatively uncommon, this change
improves performance of track-origins mode by 5% median and by up to 47% on
specs.
llvm-svn: 169490
2012-12-06 11:41:03 +00:00
8b51bab495
[msan] Instrument bswap intrinsic.
...
llvm-svn: 169383
2012-12-05 14:39:55 +00:00
474cb3b3b5
[msan] Change linkage type of __msan_track_origins.
...
LinkOnceODRLinkage globals may be removed in GlobalOpt if not used in the
current module.
llvm-svn: 169377
2012-12-05 12:49:41 +00:00
64bc1ab349
Improve MSan tests.
...
llvm-svn: 169256
2012-12-04 11:42:05 +00:00
261177a1e1
ASan: add initial support for handling llvm.lifetime intrinsics in ASan - emit calls into runtime library that poison memory for local variables when their lifetime is over and unpoison memory when their lifetime begins.
...
llvm-svn: 169200
2012-12-04 01:34:23 +00:00
5a16af8638
[msan] Tests for vector manipulation instructions.
...
llvm-svn: 168997
2012-11-30 12:12:20 +00:00
857d9d2a59
[msan] Propagate shadow through (x<0) and (x>=0) comparisons.
...
This is a special case of signed relational comparison where result
only depends on the sign of x.
llvm-svn: 168881
2012-11-29 14:25:47 +00:00
eeb8b7c391
[msan] Fix shadow & origin store & load alignment.
...
This change ensures that shadow memory accesses have the same alignment
as corresponding app memory accesses.
llvm-svn: 168880
2012-11-29 14:05:53 +00:00
c3b579e5ac
[msan] Add a test for r168873.
...
llvm-svn: 168877
2012-11-29 13:11:09 +00:00
4f9240d7e3
[msan] Update tests (broken in r168873).
...
llvm-svn: 168874
2012-11-29 12:43:56 +00:00
d4bd7b73e3
Initial commit of MemorySanitizer.
...
Compiler pass only.
llvm-svn: 168866
2012-11-29 09:57:20 +00:00
633bf93fb8
[asan] when checking the noreturn attribute on the call, also check it on the callee
...
llvm-svn: 168861
2012-11-29 08:57:20 +00:00
dfe9e7933e
[asan] Split AddressSanitizer into two passes (FunctionPass, ModulePass), LLVM part. This requires a clang part which will follow.
...
llvm-svn: 168781
2012-11-28 10:31:36 +00:00
a878e74351
tsan: instrument atomic nand operation
...
llvm-svn: 168684
2012-11-27 08:09:25 +00:00
12b5cb9a0a
[tsan] add fail order to compare_exchange
...
llvm-svn: 168586
2012-11-26 11:36:19 +00:00
dc4cb2b736
[asan] don't instrument linker-initialized globals even with external linkage in -asan-initialization-order mode
...
llvm-svn: 168367
2012-11-20 13:11:32 +00:00
b3bd605ffa
[asan] make sure that linker-initialized globals (non-extern) are not instrumented even in -asan-initialization-order mode. This time with a test
...
llvm-svn: 168366
2012-11-20 13:00:01 +00:00
0044e386e9
tsan: switch to new memory_order constants (ABI compatible)
...
llvm-svn: 167615
2012-11-09 14:12:16 +00:00
92b9e1dbfd
tsan: instrument all atomics (including fetch_add, exchange, cas, etc)
...
llvm-svn: 167612
2012-11-09 12:55:36 +00:00
28d0694c27
[asan] don't instrument globals that we've created ourselves (reduces the binary size a bit)
...
llvm-svn: 167230
2012-11-01 13:42:40 +00:00
0995994989
[asan] make sure asan erases old unused allocas after it created a new one. This became important after the recent move from ModulePass to FunctionPass because no cleanup is happening after asan pass any more.
...
llvm-svn: 166267
2012-10-19 06:20:53 +00:00
19ab3d1f6a
[asan] fix a test
...
llvm-svn: 165938
2012-10-15 14:30:30 +00:00
84d75cdffd
tsan: update the test for new atomic enums
...
llvm-svn: 165109
2012-10-03 13:19:20 +00:00
68845093dd
tsan: update the test for new atomic enums
...
llvm-svn: 165108
2012-10-03 13:13:54 +00:00
91ce36c986
Revert 'Fix a typo 'iff' => 'if''. iff is an abreviation of if and only if. See: http://en.wikipedia.org/wiki/If_and_only_if Commit 164767
...
llvm-svn: 164768
2012-09-27 10:14:43 +00:00
721cffd53a
Fix a typo 'iff' => 'if'
...
llvm-svn: 164767
2012-09-27 09:59:43 +00:00
f4be019fba
[asan] add code to detect global initialization fiasco in C/C++. The sub-pass is off by default for now. Patch by Reid Watson. Note: this patch changes the interface between LLVM and compiler-rt parts of asan. The corresponding patch to compiler-rt will follow.
...
llvm-svn: 162268
2012-08-21 08:24:25 +00:00
bf479714f9
[asan] insert crash basic blocks inline as opposed to inserting them at the end of the function. This doesn't seem to fix or break anything, but is considered to be more friendly to downstream passes (test change)
...
llvm-svn: 161871
2012-08-14 14:05:50 +00:00
f0626f2205
revert r160742: it's breaking CMake build
...
original commit msg:
MemoryBuiltins: add support to determine the size of strdup'ed non-constant strings
llvm-svn: 160751
2012-07-25 18:49:28 +00:00
f0441e04bd
MemoryBuiltins: add support to determine the size of strdup'ed non-constant strings
...
llvm-svn: 160742
2012-07-25 17:29:22 +00:00
705141d4df
baby steps toward fixing some problems with inbound GEPs that overflow, as discussed 2 months ago or so.
...
Make sure we do not emit index computations with NSW flags so that we dont get an undef value if the GEP overflows
llvm-svn: 160589
2012-07-20 23:07:40 +00:00
20ea62527a
move the bounds checking pass to the instrumentation folder, where it belongs. I dunno why in the world I dropped it in the Scalar folder in the first place.
...
No functionality change.
llvm-svn: 160587
2012-07-20 22:39:33 +00:00
f02c6069ac
[asan] make sure that the crash callbacks do not get merged (Chandler's idea: insert an empty InlineAsm). Change the order in which the new BBs are inserted: the slow path BB is insert between old BBs, the crash BB is inserted at the end. Don't create an empty BB (introduced by recent commits). Update the test. The experimental code that does manual crash callback merge will most likely be deleted later.
...
llvm-svn: 160544
2012-07-20 09:54:50 +00:00
874dae6119
[asan] refactor instrumentation to allow merging the crash callbacks (not fully implemented yet, no functionality change except the BB order)
...
llvm-svn: 160284
2012-07-16 16:15:40 +00:00
8b540ab337
Revert r160254 temporarily.
...
It turns out that ASan relied on the at-the-end block insertion order to
(purely by happenstance) disable some LLVM optimizations, which in turn
start firing when the ordering is made more "normal". These
optimizations in turn merge many of the instrumentation reporting calls
which breaks the return address based error reporting in ASan.
We're looking at several different options for fixing this.
llvm-svn: 160256
2012-07-16 10:01:02 +00:00
3dd6c81492
Teach AddressSanitizer to create basic blocks in a more natural order.
...
This is particularly useful to the backend code generators which try to
process things in the incoming function order.
Also, cleanup some uses of IRBuilder to be a bit simpler and more clear.
llvm-svn: 160254
2012-07-16 08:58:53 +00:00
663943e23e
Add a basic test for AddressSanitizer. This is just a bare-bones
...
functionality test.
In general, unless the functionality is substantially separated, we
should lump more basic testing into this file. The test running
infrastructure likes having a few test files with more comprehensive
testing within them.
llvm-svn: 160253
2012-07-16 08:56:46 +00:00
9024160439
[asan] instrument cmpxchg and atomicrmw
...
llvm-svn: 157683
2012-05-30 09:04:06 +00:00
a1259778b4
[tsan] Atomic support for ThreadSanitizer, patch by Dmitry Vyukov
...
llvm-svn: 155698
2012-04-27 07:31:53 +00:00
5ba61ac651
[tsan] two more compile-time optimizations:
...
- don't isntrument reads from constant globals.
Saves ~1.5% of instrumented instructions on CPU2006
(counting static instructions, not their execution).
- don't insrument reads from vtable (which is a global constant too).
Saves ~5%.
I did not measure the run-time impact of this,
but it is certainly non-negative.
llvm-svn: 154444
2012-04-10 22:29:17 +00:00
bf2de80be6
[tsan] compile-time instrumentation: do not instrument a read if
...
a write to the same temp follows in the same BB.
Also add stats printing.
On Spec CPU2006 this optimization saves roughly 4% of instrumented reads
(which is 3% of all instrumented accesses):
Writes : 161216
Reads : 446458
Reads-before-write: 18295
llvm-svn: 154418
2012-04-10 18:18:56 +00:00
6f8a776041
[tsan] treat vtable pointer updates in a special way (requires tbaa); fix a bug (forgot to return true after instrumenting); make sure the tsan tests are run
...
llvm-svn: 153448
2012-03-26 17:35:03 +00:00
afbb65dee7
[asan] move x86-specific test to a separate X86 directory with a custom lit.local.cfg file
...
llvm-svn: 152567
2012-03-12 18:49:11 +00:00
924f9a671d
Replace all instances of dg.exp file with lit.local.cfg, since all tests are run with LIT now and now Dejagnu. dg.exp is no longer needed.
...
Patch reviewed by Daniel Dunbar. It will be followed by additional cleanup patches.
llvm-svn: 150664
2012-02-16 06:28:33 +00:00
dc84eae1e0
[asan] fix asan-vs-gvn.ll test (it did not actually check much before this change)
...
llvm-svn: 150441
2012-02-14 00:02:35 +00:00
e2a0e4163a
ThreadSanitizer, a race detector. First LLVM commit.
...
Clang patch (flags) will follow shortly.
The run-time library will also follow, but not immediately.
llvm-svn: 150423
2012-02-13 22:50:51 +00:00
154a54d972
[asan] unpoison the stack before every noreturn call. Fixes asan issue 37. llvm part
...
llvm-svn: 150102
2012-02-08 21:36:17 +00:00
9e0d377400
The patch resolves the conflict between AddressSanitizer and load widening (GVN).
...
The problem initially reported by Mozilla folks (http://code.google.com/p/address-sanitizer/issues/detail?id=20 ),
but it also prevents us from enabling LLVM bootstrap with AddressSanitizer.
llvm-svn: 149925
2012-02-06 22:48:56 +00:00
c11d1dd133
[asan] enable asan only for the functions that have Attribute::AddressSafety
...
llvm-svn: 148846
2012-01-24 19:34:43 +00:00
842ae27ae3
[asan] one more test for asan instrumentation: (*a)++ should be instrumented only once.
...
llvm-svn: 147509
2012-01-04 01:02:14 +00:00
561dade58d
[asan] add a test for instrumenting globals
...
llvm-svn: 146718
2011-12-16 01:28:19 +00:00
8b5c7a56a3
[asan] do not instrument threadlocal globals, this is buggy
...
llvm-svn: 145092
2011-11-23 02:10:54 +00:00
1cdc6e9567
[asan] workaround for reg alloc bug 11395: don't instrument functions with large chunks of inline assembler
...
llvm-svn: 144962
2011-11-18 01:41:06 +00:00
65e2211b95
fall back to explicit list of allowed linkages when instrumenting globals in asan; add a test check that asan does not touch linkonce_odr
...
llvm-svn: 144933
2011-11-17 23:14:59 +00:00
6e6b03ec46
AddressSanitizer, first commit (compiler module only)
...
llvm-svn: 144758
2011-11-16 01:35:23 +00:00
Evgeniy Stepanov