Commit Graph

144 Commits

Author SHA1 Message Date
Jonathan Peyton b689dede58 Have CMake error out on Windows when user wants OMPT support
Currently, OMPT support requires the weak attribute which isn't supported
on Windows.  This patch has CMake error out when LIBOMP_OMPT_SUPPORT=true
and the users is building on Windows.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000692.html

Patch by Jonas Hahnfeld

llvm-svn: 239912
2015-06-17 15:43:34 +00:00
Jonathan Peyton 9919dfc3b6 Remove unused variables '__kmp_build_check_*' for non assert builds.
Add new LIBOMP_ENABLE_ASSERTIONS macro which can be set in a standalone build
or takes the value of LLVM_ENABLE_ASSERTIONS when inside llvm/projects.  This
change also defines the KMP_BUILD_ASSERT() macro to do nothing when ENABLE_ASSERTIONS
is off.  This means the __kmp_build_check_* types won't be defined and thus, no warnings.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000719.html

Patch by Jack Howarth and Jonathan Peyton

llvm-svn: 239546
2015-06-11 17:36:16 +00:00
Jonathan Peyton 5215890cae Implement recursive CMake.
Most CMake build systems put CMakeLists.txt files inside source directories where 
items need to get built. This change follows that convention by adding a new 
runtime/src/CMakeLists.txt file. An additional benefit is this helps logically 
seperate configuring with building as well. This change is mostly just copying and 
pasting the bottom half of runtime/CMakeLists.txt into runtime/src/CMakeLists.txt, 
but a few changes had to be made to get it to work. Most of those changes were to 
directory prefixes.

Differential Revision: http://reviews.llvm.org/D10344

llvm-svn: 239542
2015-06-11 17:23:57 +00:00
Jonathan Peyton cf82a16b8c Remove unused variables '__kmp_build_check_*'
As an ongoing effort to sanitize the openmp code, this one word change
eliminates creating 1 byte arrays named __kmp_build_check_* and instead
creates one byte array types.  The KMP_BUILD_ASSERT macro still offers the same
functionality; array types with negative number of elements is illegal 
and will cause a compiler failure.

llvm-svn: 239337
2015-06-08 20:18:10 +00:00
Jonathan Peyton 7c4d66d217 Remove unused variable warnings by deletion.
As an ongoing effort to sanitize the openmp code, these changes delete 
variables that aren't used at all.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000701.html

Patch by Jack Howarth

llvm-svn: 239334
2015-06-08 20:01:14 +00:00
Jonathan Peyton 91b7870f42 Remove unused variable warnings by moving variables.
As an ongoing effort to sanitize the openmp code, these changes move
variables under already existing macro guards.

Patch by Jack Howarth

llvm-svn: 239331
2015-06-08 19:39:07 +00:00
Jonathan Peyton 2321d57f8b Remove unused variable warnings by adding proper macro guards.
As an ongoing effort to sanitize the openmp code, these changes remove unused variables
by adding proper macros around both variables and functions.

Patch by Jack Howarth

llvm-svn: 239330
2015-06-08 19:25:25 +00:00
Jonathan Peyton e8104ad0e8 Remove unused variable warnings by fooling compiler.
Some variables are convenient to keep around even if they aren't
really used in a release build.  This is often seen in DEBUG guarded code where the variable
is only used in a DEBUG build.

Patch by Jack Howarth

llvm-svn: 239326
2015-06-08 18:56:33 +00:00
Jonathan Peyton bfb29f6c48 Removed unused functions.
As an ongoing effort to sanitize the openmp code, these changes remove unused functions.
The unused functions are:
__kmp_fini_allocator_thread(), __kmp_env_isDefined(), __kmp_strip_quotes(),
__kmp_convert_to_seconds(), and __kmp_convert_to_nanoseconds(). 

Patch by Jack Howarth

llvm-svn: 239323
2015-06-08 18:38:23 +00:00
Jonathan Peyton 4959fda719 Fix extern warnings produced by ittnotify_static.c
when compiling with gcc or clang numerous warnings concerning the usage 
of extern "C" linkage.  All the __kmp_itt_sync* variables are declared
like: extern "C" type __kmp_itt_sync... = definition; through various macros.
This note from cppreference.com explains why this is a problem.
// From http://en.cppreference.com/w/cpp/language/language_linkage
extern "C" int x; // a declaration and not a definition
// The above line is equivalent to extern "C" { extern int x; }
extern "C" { int x; } // a declaration and definition
Since the __kmp_itt_* variables are being declared and defined, these variables 
should use the bracketed version instead.

llvm-svn: 239184
2015-06-05 20:24:13 +00:00
Jonathan Peyton 1e7a1ddcee Fix some sign compare warnings.
This change changes kmp_bstate.old_tid to sign integer instead of unsigned integer.
It also defines two new macros KMP_NSEC_PER_SEC and KMP_USEC_PER_SEC which lets us take
control of the sign (we want them to be longs).  Also, in kmp_wait_release.h, the byteref()
function's return type is changed from char to unsigned char.

llvm-svn: 239057
2015-06-04 17:29:13 +00:00
Jonathan Peyton 5de1d47ef5 Suppress uninitialized-variable-is-used warning in kmp_csupport.c
The following change is needed to suppress the "variable 'retval' is used 
uninitialized whenever 'if' condition is false" warnings in runtime/src/kmp_csupport.c.
This change just initializes 'retval' to 0.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000667.html

Patch by Jack Howarth

llvm-svn: 238954
2015-06-03 19:31:39 +00:00
Jonathan Peyton 1c9e643248 Remove conditional parameters from KA_TRACE macro.
It's undefined behavior to have arguments to macros be conditionally preprocessed.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000669.html

Patch by Jack Howarth and Jonathan Peyton

llvm-svn: 238950
2015-06-03 18:24:02 +00:00
Jonathan Peyton c98d03011e Reorder C++ initialization lists to appease compiler.
in kmp_wait_release.h, there were some constructors where the initialization
lists were out of order with the member declarations inside the class.  This
patch just reorders the initialization list so the compiler doesn't complain.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000670.html

Patch by Jack Howarth and Jonathan Peyton

llvm-svn: 238946
2015-06-03 17:26:47 +00:00
Jonathan Peyton 2f249bab07 Remove unused variable anonym from kmp_atomic.c
There is an anonym variable inside a macro that is declared and defined
but never used.  This patch removes it.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000666.html

Patch by Jack Howarth and Jonathan Peyton

llvm-svn: 238934
2015-06-03 16:23:36 +00:00
Jonathan Peyton 021cad043a Get rid of some dead code.
Some old references to RML and IOMP which aren't used anywhere are deleted.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000664.html

Patch by Jack Howarth and Jonathan Peyton

llvm-svn: 238878
2015-06-02 22:21:37 +00:00
Jonathan Peyton 0591d53c88 Remove unused KMP_IOMP_NAME macro from kmp.h
Getting rid of more iomp references.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-June/000659.html

llvm-svn: 238847
2015-06-02 16:19:44 +00:00
Jonathan Peyton 6e8917bce1 Change Intel(R) OpenMP* to LLVM* OpenMP* in libomp.rc.var
Missed some places that referenced the Intel(R) OpenMP* Runtime Library.

llvm-svn: 238840
2015-06-02 15:06:08 +00:00
Jonathan Peyton 476679aee4 Apply name change to testsuite file.
This change has the llvm-lit part of the testsuite have clang
link to libomp instead of libiomp5.

llvm-svn: 238721
2015-06-01 04:24:23 +00:00
Jonathan Peyton 32be447d55 Apply name change to Makefile build system.
This change produces a dynamic library named libomp instead of
libiomp5.  Similar to the CMake change, it produces symlinks of libiomp5
in the exports/ directory for Unix systems and copies for Windows.

llvm-svn: 238720
2015-06-01 04:21:22 +00:00
Jonathan Peyton 227e1aeb13 Apply name change to CMake build system.
This change has the CMake build system create a dynamic library named
libomp instead of libiomp5.  Also any reference to libiomp is replaced
with libomp.  One can still use the LIBOMP_LIB_NAME variable to enforce
a different name, and everything will still work as expected.  An important
note is that libiomp5 and libgomp symlinks are created at install time when
on Unix systems.  On Windows, copies are created with the legacy names.

llvm-svn: 238715
2015-06-01 03:05:13 +00:00
Jonathan Peyton f0efbb5410 Apply name change to tools/* files.
These changes are all in comments.  Change libiomp references to
libomp.

llvm-svn: 238713
2015-06-01 02:41:44 +00:00
Jonathan Peyton 663382950d Apply name change to src/* files.
These changes are mostly in comments, but there are a few
that aren't.  Change libiomp5 => libomp everywhere.  One internal
function name is changed in kmp_gsupport.c, and in kmp_i18n.c, the
static char[] variable 'name' is changed to "libomp".

llvm-svn: 238712
2015-06-01 02:37:28 +00:00
Jonathan Peyton 469dcc63fb Apply name change to doxygen files.
This change only affects the doxygen file that contains a
reference to libiomp5.  change libiomp5 to libomp.

llvm-svn: 238711
2015-06-01 02:32:03 +00:00
Jonathan Peyton 1fdcb8b5d7 Adding libomp.rc.var for name change
Adding a new file libomp.rc.var in anticipation of more
name change commits.  This file is a copy of libiomp.rc.var.

llvm-svn: 238710
2015-06-01 02:26:08 +00:00
Jonathan Peyton 92907c2ab9 Allow CMAKE_OSX_ARCHITECTURES to build fat library.
The CMAKE_OSX_ARCHITECTURES CMake variable allows users to build
universal fat libraries that contain both i386 and x86_64 code.  These
changes allow this build by having the z_Linux_asm.s file detect the architecture
itself instead of receiving it through the build system.

Also, there was a LIBOMP_OSX_ARCHITECTURES CMake variable added to allow
people to only build libomp as a fat library and not the entire LLVM/Clang system.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2015-May/000626.html

llvm-svn: 238566
2015-05-29 16:13:56 +00:00
Jonathan Peyton caf09fe022 Fix comment about balanced affinity
A while back, Hal mentioned fixing a comment concerning balanced affinity.
http://lists.cs.uiuc.edu/pipermail/openmp-dev/2014-December/000358.html
I forgot about fixing it until now, but now is better than never.

llvm-svn: 238378
2015-05-27 23:27:33 +00:00
Jonathan Peyton 6bfc9190f1 Allow gcc 5.x to compile library.
Change check of __GNUC__ macro from:
__GNUC__ == 4 to __GNUC__ >= 4

llvm-svn: 238347
2015-05-27 18:57:33 +00:00
Jonathan Peyton 9901699970 Change macro GUIDEDLL_EXPORTS to KMP_DYNAMIC_LIB
A while back, Hal suggested updating the GUIDEDLL_EXPORTS macro guard to 
a more descriptive name.  It represents a dynamic library build so 
KMP_DYNAMIC_LIB is a more suitable name.

Differential Revision: http://reviews.llvm.org/D9899

llvm-svn: 238221
2015-05-26 17:32:53 +00:00
Jonathan Peyton fbb1514805 Change CMake file formatting
Removing unnecessary spaces. For CACHE variables, putting the description string
on its own line which mimics libcxx. There are no logic changes.

Differential Revision: http://reviews.llvm.org/D9945

llvm-svn: 238219
2015-05-26 17:27:01 +00:00
Jonathan Peyton 9e6eb48f77 One line fix for possible out-of-bounds issue in kmp_runtime.c
The variable j is now checked so there is no possible
out-of-bounds issue when accessing __kmp_nested_nth.nth[] array.

llvm-svn: 238216
2015-05-26 16:38:26 +00:00
Jonathan Peyton ff8007711a One line fix for possible out-of-bounds issue in kmp_error.c
This off-by-one error could lead to an out-of-bounds access on the
cons_text_c[] array.

llvm-svn: 238215
2015-05-26 16:30:41 +00:00
Andrey Churbanov 7af7c8df31 fixed missed arch renaming (from C.Bergstrom)
llvm-svn: 238153
2015-05-25 20:01:16 +00:00
Jonathan Peyton 81f9cd1335 Fix doxygen comments
These fixes make doxygen happy.

llvm-svn: 238061
2015-05-22 22:37:22 +00:00
Jonathan Peyton 1406f014fd Fix spelling errors
These spelling errors are in comments and some debug messages.

llvm-svn: 238060
2015-05-22 22:35:51 +00:00
Jonathan Peyton 7881aa1b3a One line fix - bug with final clause of task construct
Should be looking at parent_task->td_flags.final instead of the recently allocated task.

llvm-svn: 237959
2015-05-21 21:16:38 +00:00
Jonathan Peyton 057d77d8c1 Fix task team synchronization
The fix simply syncs up the new threads to have the same task_state and
task_team as the old threads.  The master thread is skipped,
because it shouldn't at this point have the team's task_team value yet
-- it should still have parent_team's task_team.  It gets pointed at
the new team's task_team later, after __kmp_allocate_team returns, and
the master has stored a memo of it's old task_state.

llvm-svn: 237916
2015-05-21 17:20:01 +00:00
Jonathan Peyton 7979a07611 Change CMake variable prefix to LIBOMP
Cached CMake variables need to have a prefix so they don't collide with other
projects. This change (a lot of simple changes) simply prefixes cached variables
with LIBOMP_ and sets all of these variables to UPPERCASE which is convention.
e.g., os => LIBOMP_OS, ompt_support => LIBOMP_OMPT_SUPPORT.

Differential Revision: http://reviews.llvm.org/D9829

llvm-svn: 237845
2015-05-20 22:33:24 +00:00
Jonathan Peyton dee6ce71ac Makefile fix for testsuite -- Follow up to r237618
This changes INCLUDE_PATH to C_INCLUDE_PATH and misspelled CLASH to SLASH

Patch by Sunita Chandrasekaran

llvm-svn: 237727
2015-05-19 21:28:33 +00:00
Jonathan Peyton 41216393a4 Fix for testsuite including omp.h
When calling the testsuite, clang could not locate omp.h.  The
proper environment variable was modified to include:
exports/common/omp.h.  Documentation was also updated to be more
clear.

Patch by Sunita Chandrasekaran

llvm-svn: 237618
2015-05-18 21:38:50 +00:00
Jonathan Peyton f91cebf7c5 Delete old CMake build system
Remove runtime/CMakeLists.txt.old and runtime/src/CMakeLists.txt as
they no longer worked and were not being kept up to date.

Differential Revision: http://reviews.llvm.org/D9756

llvm-svn: 237615
2015-05-18 21:21:25 +00:00
Jonathan Peyton e70f810378 Small fix to allow FreeBSD build to work.
Add xexpand macro to the FTN_IS_INITIAL_DEVICE api function

Patch by Davide Italiano

Differential Revision: http://reviews.llvm.org/D9798

llvm-svn: 237472
2015-05-15 19:57:36 +00:00
Jonathan Peyton 38b54cb67b Testing commit privilege
Added comment to CMakeLists.txt about library install directory suffix option.

llvm-svn: 237384
2015-05-14 19:54:56 +00:00
Andrey Churbanov 708fa8e899 Cross compiler build fix [Important] - from J.Peyton, initial version from C.Bergstrom.
llvm-svn: 237360
2015-05-14 12:54:08 +00:00
Andrey Churbanov e3ebce6bdf Removed mentioning of OpenMP as unsupported feature (patch2 from A.Bokhanko)
llvm-svn: 237253
2015-05-13 13:42:59 +00:00
Andrey Churbanov 5a7a5d1dab patch to allow lib name at configure time (from C.Bergstrom)
llvm-svn: 237130
2015-05-12 13:31:57 +00:00
Andrey Churbanov 5c8f90b1ad Missing file runtime/src/include/41/ompt.h.var added; fixed build to optionally use added file.
llvm-svn: 237125
2015-05-12 13:10:54 +00:00
Andrey Churbanov 4dc2a6b704 D9576: Updates documentation to include all possible architecture builds, synchronizes runtime/README.txt and www/README.txt, updates the building-with-CMake documentation. This change also changes references of Intel(R) OpenMP Library to LLVM OpenMP Library.
llvm-svn: 237124
2015-05-12 12:52:43 +00:00
Andrey Churbanov 820b25550b Change some text areas from saying Intel(R) OpenMP runtime library to LLVM OpenMP runtime library.
llvm-svn: 236884
2015-05-08 17:41:32 +00:00
Andrey Churbanov 535b6faaf0 D9306 omp 4.1 async offload support (partial): code changes
llvm-svn: 236753
2015-05-07 17:41:51 +00:00