llvm-project

Commit Graph

Author	SHA1	Message	Date
Rui Ueyama	025bb56a86	Always add a .note.GNU-stack section if -r. With this patch, lld creates a .note.GNU_stack and adds that to an output file if it is creating a re-linkable object file (i.e. if -r is given). If we don't do this, and if you use GNU linkers as a final linker, they create an executable whose stack area is executable, which is considered pretty bad these days. Differential Revision: https://reviews.llvm.org/D51400 llvm-svn: 340902	2018-08-29 07:27:09 +00:00
Alexander Shaposhnikov	f59ab35b1b	[lld] Fix comdat tests This diff adjusts the comdat tests after changing the format of llvm-readobj output for .group sections. llvm-svn: 327353	2018-03-13 00:07:53 +00:00
George Rimar	072a43b501	[ELF] - Do not merge sections from SHT_GROUP when -relocatable This is PR34506. Imagine we have 2 sections the same name but different COMDAT groups: .section .foo,"axG",@progbits,bar,comdat .section .foo,"axG",@progbits,zed,comdat When linking relocatable we do not merge SHT_GROUP sections. But still would merge both input sections .foo into single output section .foo. As a result we will have 2 different SHT_GROUPs containing the same section, what is wrong. Patch fixes the issue, preventing merging SHF_GROUP sections with any others. Differential revision: https://reviews.llvm.org/D37574 llvm-svn: 313621	2017-09-19 09:40:31 +00:00

Author

SHA1

Message

Date

Rui Ueyama

025bb56a86

Always add a .note.GNU-stack section if -r.

With this patch, lld creates a .note.GNU_stack and adds that to an
output file if it is creating a re-linkable object file (i.e. if -r
is given). If we don't do this, and if you use GNU linkers as a final
linker, they create an executable whose stack area is executable,
which is considered pretty bad these days.

Differential Revision: https://reviews.llvm.org/D51400

llvm-svn: 340902

2018-08-29 07:27:09 +00:00

Alexander Shaposhnikov

f59ab35b1b

[lld] Fix comdat tests

This diff adjusts the comdat tests after changing the format
of llvm-readobj output for .group sections.

llvm-svn: 327353

2018-03-13 00:07:53 +00:00

George Rimar

072a43b501

[ELF] - Do not merge sections from SHT_GROUP when -relocatable

This is PR34506.

Imagine we have 2 sections the same name but different COMDAT groups:

.section        .foo,"axG",@progbits,bar,comdat
.section        .foo,"axG",@progbits,zed,comdat
When linking relocatable we do not merge SHT_GROUP sections. But still would merge
both input sections .foo into single output section .foo.
As a result we will have 2 different SHT_GROUPs containing the same section, what
is wrong.

Patch fixes the issue, preventing merging SHF_GROUP sections with any others.

Differential revision: https://reviews.llvm.org/D37574

llvm-svn: 313621

2017-09-19 09:40:31 +00:00

3 Commits