4 Commits

Author	SHA1	Message	Date
River Riddle	f8479d9de5	[mlir] Set the namespace of the BuiltinDialect to 'builtin' ... Historically the builtin dialect has had an empty namespace. This has unfortunately created a very awkward situation, where many utilities either have to special case the empty namespace, or just don't work at all right now. This revision adds a namespace to the builtin dialect, and starts to cleanup some of the utilities to no longer handle empty namespaces. For now, the assembly form of builtin operations does not require the `builtin.` prefix. (This should likely be re-evaluated though) Differential Revision: https://reviews.llvm.org/D105149	2021-07-28 21:00:10 +00:00
Rahul Joshi	b7382ed3fe	[MLIR] Extend Symbol verification to reject public symbol declarations. ... - Extend the Symbol interface with `isDeclaration` to identify operations that declare a symbol as opposed to define it. - Extend verification to disallow public declarations as per the discussion in https://llvm.discourse.group/t/rfc-symbol-definition-declaration-x-visibility-checks/2140 - Adopt the new interface for `FuncOp` and fix test and code to not have/create public function declarations. Differential Revision: https://reviews.llvm.org/D91456	2020-11-16 16:05:32 -08:00
Rahul Joshi	8b5a3e4632	[MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict. ... - Change syntax for FuncOp to be `func <visibility>? @name` instead of printing the visibility in the attribute dictionary. - Since printFunctionLikeOp() and parseFunctionLikeOp() are also used by other operations, make the "inline visibility" an opt-in feature. - Updated unit test to use and check the new syntax. Differential Revision: https://reviews.llvm.org/D90859	2020-11-09 11:08:08 -08:00
River Riddle	43cf489cf5	[mlir][SymbolDCE][NFC] Fix the visibility of the symbols within the test and ... move it to test/Transforms/	2020-04-13 00:33:11 -07:00