Kazu Hirata
fc2b09a744
[ADT] Remove ImmutableSet::foreach and ImmutableMap::foreach (NFC)
...
These functions seem to be unused for at least 1 year.
2022-01-01 22:05:14 -08:00
Craig Topper
4602f4169a
[RISCV] Prune unnecessary vector pseudo instructions. NFC
...
For .vf instructions, we don't need MF8 pseudos for f16. We don't
need MF8 or MF4 pseudos for f32. Or MF8, MF4, MF2 for f64.
Reviewed By: khchen
Differential Revision: https://reviews.llvm.org/D116437
2022-01-01 19:53:53 -08:00
Mehdi Amini
6786d7e4f5
Apply clang-tidy fixes for readability-simplify-boolean-expr to MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116253
2022-01-02 01:59:31 +00:00
Mehdi Amini
5a1f6077ec
Apply clang-tidy fixes for readability-container-size-empty for MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116252
2022-01-02 01:56:38 +00:00
Mehdi Amini
f0fff1dfde
Remove unused applyPad function from TosaToLinalg.cpp (NFC)
2022-01-02 01:53:18 +00:00
Mehdi Amini
ad5d7ace34
Apply clang-tidy fixes for readability-const-return-type to MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116251
2022-01-02 01:51:39 +00:00
Mehdi Amini
1fc096af1e
Apply clang-tidy fixes for performance-unnecessary-value-param to MLIR (NFC)
...
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D116250
2022-01-02 01:45:18 +00:00
Mehdi Amini
b11510d5df
Apply clang-tidy fixes for modernize-use-using to MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116357
2022-01-02 01:25:14 +00:00
Mehdi Amini
0ae2e9580c
Apply clang-tidy fixes for modernize-use-override to MLIR (NFC)
...
Reviewed By: rriddle, jpienaar
Differential Revision: https://reviews.llvm.org/D116356
2022-01-02 01:24:02 +00:00
Mehdi Amini
513463b589
Apply clang-tidy fixes for llvm-qualified-auto to MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116355
2022-01-02 01:21:40 +00:00
Mehdi Amini
a86b957fd7
Apply clang-tidy fixes for bugprone-macro-parentheses to MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116354
2022-01-02 01:20:01 +00:00
Mehdi Amini
ee1fcb2fb6
Apply clang-tidy fixes for performance-move-const-arg to MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116249
2022-01-02 01:16:15 +00:00
Mehdi Amini
89de9cc8a7
Apply clang-tidy fixes for performance-for-range-copy to MLIR (NFC)
...
Differential Revision: https://reviews.llvm.org/D116248
2022-01-02 01:13:42 +00:00
Mehdi Amini
322c891483
Apply clang-tidy fixes for modernize-use-equals-default to MLIR (NFC)
...
Differential Revision: https://reviews.llvm.org/D116247
2022-01-02 01:13:27 +00:00
Mehdi Amini
3bab9d4eb0
Apply clang-tidy fixes for bugprone-copy-constructor-init to MLIR (NFC)
...
Reviewed By: rriddle, Mogball
Differential Revision: https://reviews.llvm.org/D116245
2022-01-02 01:05:30 +00:00
Mehdi Amini
ced8690d84
Apply clang-tidy fixes for bugprone-argument-comment to MLIR (NFC)
...
Differential Revision: https://reviews.llvm.org/D116244
2022-01-02 01:05:06 +00:00
Mehdi Amini
ab6502ea67
Enable a few clang-tidy checks in MLIR
...
The dry-run of clang-tidy on the codebase with these enable were
well receive, and the codebase is "clean" (or almost) with respect
to these right now.
2022-01-02 01:05:06 +00:00
Kazu Hirata
fd4808887e
[llvm] Remove redundant member initialization (NFC)
...
Identified with readability-redundant-member-init.
2022-01-01 16:18:18 -08:00
Mehdi Amini
104a827ea6
Move LinalgDetensorize pass option from .cpp file to the .td declaration (NFC)
2022-01-01 21:19:31 +00:00
Mehdi Amini
a978847e3a
Use const reference for diagnostic in callback (NFC)
...
This isn't a "small" struct, flagged by Coverity.
2022-01-01 21:15:50 +00:00
Kazu Hirata
8b649f98f6
[lldb] Add NOLINT(modernize-use-nullptr)
...
thread_result_t is defined as unsigned on Windows.
This patch prevents clang-tidy from replacing 0 with nullptr.
2022-01-01 13:14:59 -08:00
Kazu Hirata
f4ffcab178
Remove redundant string initialization (NFC)
...
Identified by readability-redundant-string-init.
2022-01-01 12:34:11 -08:00
David Green
319e77592f
[ARM] Verify addressing immediates
...
This adds at extra check into ARMBaseInstrInfo::verifyInstruction to
verify the offsets used in addressing mode immediates using
isLegalAddressImm. Some tests needed fixing up as a result, adjusting
the opcode created from CMSE stack adjustments.
Differential Revision: https://reviews.llvm.org/D114939
2022-01-01 20:08:45 +00:00
Kazu Hirata
b8336280d8
[lldb] Use nullptr instead of 0 or NULL (NFC)
...
This is a re-submission of 24d2405588
without the hunks in HostNativeThreadBase.{h,cpp}, which break builds
on Windows.
Identified with modernize-use-nullptr.
2022-01-01 11:54:25 -08:00
Kazu Hirata
95f7112be8
Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)"
...
This reverts commit 913457acf0
.
It again broke builds on Windows:
lldb/source/Host/common/HostNativeThreadBase.cpp(37,14): error:
assigning to 'lldb::thread_result_t' (aka 'unsigned int') from
incompatible type 'std::nullptr_t'
2022-01-01 11:15:14 -08:00
Kazu Hirata
913457acf0
[lldb] Use nullptr instead of 0 or NULL (NFC)
...
This is a re-submission of 24d2405588
without the hunk in HostNativeThreadBase.h, which breaks builds on
Windows.
Identified with modernize-use-nullptr.
2022-01-01 10:48:56 -08:00
Kazu Hirata
69ccc96162
[llvm] Use the default constructor for SDValue (NFC)
2022-01-01 10:36:59 -08:00
Nico Weber
4f2eeb6a65
Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)"
...
This reverts commit 24d2405588
.
Breaks building on Windows:
../../lldb/include\lldb/Host/HostNativeThreadBase.h(49,36): error:
cannot initialize a member subobject of type 'lldb::thread_result_t'
(aka 'unsigned int') with an rvalue of type 'std::nullptr_t'
lldb::thread_result_t m_result = nullptr;
^~~~~~~
1 error generated.
2022-01-01 13:35:54 -05:00
Kazu Hirata
dd2ad7fa47
[Target] Use range-based for loops (NFC)
2022-01-01 10:14:05 -08:00
Nuno Lopes
b23669123a
[docs] Mark @llvm.sideeffect() as willreturn
...
Changed by https://reviews.llvm.org/D65455
2022-01-01 18:04:04 +00:00
John Ericson
b3af9fbcc9
Set the path to the shared cmake modules based on the llvm directory
...
It’s still possible to build parts of the main llvm build (lld, clang etc) by symlinking them into llvm/tools.
Reviewed By: Ericson2314
Differential Revision: https://reviews.llvm.org/D116472
2022-01-01 17:59:08 +00:00
Kazu Hirata
f1d562952e
[Aarch64] Remove redundant declaration initializeSVEIntrinsicOptsPass (NFC)
...
The function is declared in AArch64.h.
Identified with readability-redundant-declaration.
2022-01-01 09:14:25 -08:00
Kazu Hirata
683e6ee7d0
[CodeGen] Remove redundant string initialization (NFC)
...
Identified with readability-redundant-string-init.
2022-01-01 09:14:23 -08:00
Kazu Hirata
491b4e1faa
[IR] Remove redundant return statements (NFC)
...
Identified by readability-redundant-control-flow.
2022-01-01 09:14:21 -08:00
Kazu Hirata
63846a634d
[mlir] Remove unused "using" (NFC)
...
Identified by misc-unused-using-decls.
2022-01-01 09:14:19 -08:00
Kazu Hirata
24d2405588
[lldb] Use nullptr instead of 0 or NULL (NFC)
...
Identified with modernize-use-nullptr.
2022-01-01 08:54:05 -08:00
Kazu Hirata
f85c91f1e5
[Transforms] Remove unused forward declarations (NFC)
2022-01-01 08:45:35 -08:00
Florian Hahn
7305798049
[VPlan] Remove VPWidenPHIRecipe constructor without start value (NFC).
...
This was suggested as a separate cleanup in recent reviews.
2022-01-01 13:53:48 +00:00
Markus Böck
eb6b2efe4e
[mlir][NFC] Fully qualify use of SmallVector in generated C++ code of mlir-tblgen
2022-01-01 14:52:32 +01:00
LLVM GN Syncbot
ed56007ac5
[gn build] Port 2edcde00cb
2022-01-01 02:17:49 +00:00
Mehdi Amini
07b264d1f0
Pass the LLVMTypeConverter by reference in UnrankedMemRefBuilder (NFC)
...
This is a fairly large structure (952B according to Coverity), it was
already passed by reference in most places but not consistently.
2022-01-01 02:01:41 +00:00
Mehdi Amini
bb6109aae6
Pass the LLVMTypeConverter by reference in MemRefBuilder (NFC)
...
This is a fairly large structure (952B according to Coverity), it was
already passed by reference in most places but not consistently.
2022-01-01 01:56:50 +00:00
Mehdi Amini
36a6e56bff
Fix possible memory leak in a MLIR unit-test
...
Flagged by Coverity
2022-01-01 01:42:26 +00:00
Mehdi Amini
a9f13f8065
Fix a few unitialized class members in MLIR (NFC)
...
Flagged by Coverity.
2022-01-01 01:40:36 +00:00
Craig Topper
243b7aaf51
[SelectionDAG] Use KnownBits::countMinSignBits() to simplify the end of ComputeNumSignBits.
...
This matches what is done in ValueTracking.cpp
Reviewed By: RKSimon, foad
Differential Revision: https://reviews.llvm.org/D116423
2021-12-31 17:29:57 -08:00
Craig Topper
d00e438cfe
[RISCV][LegalizeIntegerTypes] Teach PromoteSetCCOperands not to sext i32 comparisons for RV64 if the promoted values are already zero extended.
...
This is similar to what is done for targets that prefer zero extend
where we avoid using a zero extend if the promoted values are sign
extended.
We'll also check for zero extended operands for ugt, ult, uge, and ule when the
target prefers sign extend. This is different than preferring zero extend, where
we only check for sign bits on equality comparisons.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D116421
2021-12-31 17:15:20 -08:00
Mehdi Amini
8637be74a0
Remove redundant return after return in CodegenStrategy (NFC)
...
Reported by Coverity
2022-01-01 01:14:27 +00:00
Markus Böck
3536d24a1a
[mlir][LLVMIR] Add `llvm.eh.typeid.for` intrinsic
...
MLIR already exposes landingpads, the invokeop and the personality function on LLVM functions. With this intrinsic it should be possible to implement exception handling via the exception handling mechanisms provided by the Itanium ABI.
Differential Revision: https://reviews.llvm.org/D116436
2022-01-01 02:03:00 +01:00
Kazu Hirata
bc360fd83a
[AMDGPU] Remove unused declarations fold_exp* and fold_log* (NFC)
2021-12-31 16:50:18 -08:00
Kazu Hirata
5c4b9ea4a7
[AMDGPU] Remove replaceWithNative (NFC)
...
The function was introduced without any use on Aug 11, 2017 in commit
7f37794ebd
.
2021-12-31 16:43:06 -08:00