593f833e9b
[ASan][OSX] Fix the incorrect malloc_create_zone() implementation that led to out-of-bounds mprotect()s
...
(https://code.google.com/p/address-sanitizer/issues/detail?id=203 )
Add a test.
llvm-svn: 185138
2013-06-28 09:21:31 +00:00
28e84fc53e
Revert hack that omits errno on Darwin platforms. We now have an acceptable 'errno' header.
...
llvm-svn: 185106
2013-06-27 21:17:53 +00:00
9450108430
[sanitizer] Support padding with spaces in Printf.
...
llvm-svn: 185082
2013-06-27 15:30:44 +00:00
1c34897887
[lsan] Fix flaky test.
...
llvm-svn: 185079
2013-06-27 14:24:07 +00:00
d2cd2d018f
tsan: revert dynamic symbols file to the old incorrect one
...
full proper list of dynamic symbols crashes old gold (see bug 16468).
the culprit is 'memcpy' function, if it's added to syms file, gold crashes
llvm-svn: 185078
2013-06-27 13:56:37 +00:00
b7c6f49364
tsan: remove non-existent functions from syms file
...
llvm-svn: 185077
2013-06-27 13:52:50 +00:00
f5cae53057
[msan] Optionally disable 2 tests (dlopen & gethostbyname).
...
llvm-svn: 185076
2013-06-27 13:21:00 +00:00
815d3232a7
[sanitizer] Fix dirent interceptors.
...
The new version reads d_reclen for (struct dirent) size.
llvm-svn: 185067
2013-06-27 09:37:27 +00:00
895784a5b0
[LSan] Add the way to disable LSan at link time
...
llvm-svn: 185066
2013-06-27 09:35:50 +00:00
ecdcf11bd6
[TSan] try to fix Go build
...
llvm-svn: 185063
2013-06-27 07:57:53 +00:00
ed4594b76a
[MSan] Rename __msan_unpoision_param to __msan::UnpoisonParam - it shouldn't be in interface
...
llvm-svn: 185062
2013-06-27 07:50:56 +00:00
0b2ffe30e4
[tsan] Fix build.
...
llvm-svn: 184963
2013-06-26 16:49:34 +00:00
d109eb052b
[tsan] Move some suppressions-related code to common.
...
Factor out code to be reused in LSan. Also switch from linked list to vector.
llvm-svn: 184957
2013-06-26 15:37:14 +00:00
06d6c25141
[sanitizer] readdir and readdir_r interceptors.
...
llvm-svn: 184950
2013-06-26 15:00:53 +00:00
6a068a715d
[asan] initialize fake_stack lazily and increase its maximal size. This makes -fsanitize=address,use-after-return more robust: all SPEC tests pass now. In the default mode thread stacks become a bit smaller.
...
llvm-svn: 184934
2013-06-26 12:16:05 +00:00
b598c0b527
[sanitizer] Reformat line >80 chars.
...
llvm-svn: 184926
2013-06-26 09:16:45 +00:00
2c7d4d379e
[sanitizer] Fix build with OSS4 kernel headers.
...
This fixes PR16453.
llvm-svn: 184925
2013-06-26 08:16:38 +00:00
fa95cc916f
Fix a use after free I introduced and that Bill caught in code review
...
(thanks!) by deferring the free of the filename until we finish writing
the coverage data to that file.
Bill, let me know if you'd prefer a different approach!
llvm-svn: 184895
2013-06-26 00:26:16 +00:00
90c38bcf58
Don't use 'errno.h' on Apple just yet. This breaks for some of our buildbots.
...
llvm-svn: 184878
2013-06-25 21:08:40 +00:00
eb95448245
tsan: add missing __attribute__((visibility("default"))) to interface functions
...
llvm-svn: 184858
2013-06-25 15:36:25 +00:00
c3332bc8c3
[lsan] Define interceptors more correctly. Also, always clear allocated memory.
...
llvm-svn: 184849
2013-06-25 14:05:52 +00:00
982d56abb8
[sanitizer] Move log_path to common flag and use it in MSan.
...
llvm-svn: 184836
2013-06-25 13:50:44 +00:00
a26c814953
Address a few of the issues in GCDAProfiling I noted when looking
...
through Bill's patch:
1) Correctly test the file descriptor after the sceond attempt at
creating the file.
2) Make the filename a global so that we can issue error messages from
other routines.
3) Check errno in several places and print it out so that errors are
easier to track down.
I don't really expect any of these to fix the current failures I'm
seeing, but I'm hopeful they'll at least let me debug them.
llvm-svn: 184799
2013-06-25 00:37:32 +00:00
9fcb41d0fa
Remove the sysroot restriction from building GCDAProfiling.c.
...
We really need the C standard library to be available to implement the
profiling runtime library reasonably, and replicating everything in the
SDKs tree really isn't addressing any problems we have. Notably, all of
the sanitizer runtimes take the same approach, and this isn't a library
which could end up in a bootstrapping problem where the system headers
aren't even available.
This will hopefully prevent subsequent changes which start using various
other bits of C standard library to make things more debuggable.
llvm-svn: 184798
2013-06-25 00:37:28 +00:00
5001d43dcb
tsan: make the test more robust
...
currently it episodically fails
the hypothesis it is due to racy race detection algorithm
the sleep should make it more robust
llvm-svn: 184752
2013-06-24 16:28:02 +00:00
b4711b2c24
tsan: update dynamic export syms file
...
now it includes proper functions (including interceptors)
and does not include local functions that lead to build failures
llvm-svn: 184747
2013-06-24 15:17:36 +00:00
60d964d4f2
[sanitizer] Intercept sysinfo.
...
llvm-svn: 184739
2013-06-24 14:25:33 +00:00
8fb2c264a2
[sanitizer] Fix TSan build.
...
llvm-svn: 184736
2013-06-24 14:03:13 +00:00
02a7460d12
[sanitizer] Intercept inet_aton.
...
llvm-svn: 184735
2013-06-24 13:56:14 +00:00
830550ce4c
[msan] Unpoison param-tls in signal handler wrapper.
...
This an entry point from uninstrumented code.
llvm-svn: 184734
2013-06-24 13:48:42 +00:00
0e8053af08
[sanitizer] Intercept readv, preadv, writev, pwritev.
...
llvm-svn: 184717
2013-06-24 10:43:23 +00:00
b8cd986b5d
[lsan] Fix android build.
...
llvm-svn: 184704
2013-06-24 09:12:11 +00:00
4e0215a71c
Revert to C-style callbacks for iteration over allocator chunks.
...
Also clean up LSan code, fix some comments and replace void* with uptr
to bring down the number of reinterpret_casts.
llvm-svn: 184700
2013-06-24 08:34:50 +00:00
43937b3758
Add cmake rules for building LSan common on Mac OS
...
llvm-svn: 184639
2013-06-22 16:33:52 +00:00
38fa1ff710
[lsan] Try REALLY hard to fix Win build.
...
llvm-svn: 184557
2013-06-21 15:50:49 +00:00
85f1fffdfb
[lsan] This time really fix Win build.
...
llvm-svn: 184556
2013-06-21 15:22:12 +00:00
7ed5c687ed
[lsan] Fix win build.
...
llvm-svn: 184555
2013-06-21 15:14:57 +00:00
d28c03c03a
[lsan] Increase allocator space; minor fixes.
...
llvm-svn: 184554
2013-06-21 15:10:20 +00:00
b94d5e2d1c
[asan] Move lsan_disabled out of thread context.
...
Fix for the case where disabler is used in pthread key destructor.
llvm-svn: 184553
2013-06-21 14:51:52 +00:00
a9db3f9757
[ASan] reimplement strdup() interceptor to get nicer stack traces for memory chunks allocated there
...
llvm-svn: 184546
2013-06-21 14:41:59 +00:00
b58b72e151
[msan] Intercept (v)asprintf.
...
llvm-svn: 184545
2013-06-21 13:32:26 +00:00
ae4e1ec4e6
[msan] Add keep_going runtime flag.
...
llvm-svn: 184542
2013-06-21 12:37:58 +00:00
f9e6624663
[ASan] make test for LSan annotations Linux-only for now
...
llvm-svn: 184541
2013-06-21 12:18:52 +00:00
ad25b50a89
[ASan] Check that ASan user may include and use LSan headers
...
llvm-svn: 184540
2013-06-21 11:11:44 +00:00
57a40e5a94
[santizer] Disable several EVIOxxx ioctls on older kernels.
...
llvm-svn: 184539
2013-06-21 10:54:57 +00:00
03ec9545f5
tsan: fix potential false positive race on fd
...
llvm-svn: 184430
2013-06-20 14:32:12 +00:00
5e6b9eccce
[asan] Define LSan annotations as no-ops if leak detection is not supported.
...
llvm-svn: 184422
2013-06-20 13:39:42 +00:00
673cf23d06
Fix unused function warning w/o changing compiler flags.
...
We have way too many different build systems.
llvm-svn: 184409
2013-06-20 09:45:36 +00:00
3ce228faf3
[sanitizer] Fix Mac build.
...
llvm-svn: 184407
2013-06-20 09:39:34 +00:00
d271563e5a
Remove an outdated comment.
...
llvm-svn: 184406
2013-06-20 09:21:25 +00:00
fbea5b95c6
[sanitizer] Handle EVIOxxxx ioctls.
...
llvm-svn: 184405
2013-06-20 09:19:28 +00:00
686c229b03
[ASan] Clear allocation magic value before recycling the chunk. This led to spurious crashes in LSan when it walked through reused chunks. Don't know how to create not-brittle test case for this.
...
llvm-svn: 184404
2013-06-20 08:13:06 +00:00
7014179ccb
[lsan] Prevent inlining of WipeStack().
...
llvm-svn: 184312
2013-06-19 15:39:13 +00:00
dac35c24c0
[lsan] Move symbolization and reporting out of StopTheWorld callback.
...
llvm-svn: 184303
2013-06-19 14:04:11 +00:00
49b4314cfd
[sanitizer] Fix struct ifconf definition on Mac and restore the size checks.
...
llvm-svn: 184296
2013-06-19 13:21:38 +00:00
29b9fcf0a8
[ASan] Delete excessive 'extern "C"' around mlock* interceptors.
...
llvm-svn: 184294
2013-06-19 11:36:51 +00:00
41060fd728
[sanitizer] Fix Android build.
...
llvm-svn: 184293
2013-06-19 10:36:31 +00:00
f9cfe76526
[sanitizer] Fix build on RHEL 6.3, 6.4.
...
linux/if_ppp.h is broken in certain kernels.
llvm-svn: 184290
2013-06-19 08:55:28 +00:00
63d84f8149
[asan] fix a rare failure in fast unwinder, found by asan/clang bootstrap
...
llvm-svn: 184190
2013-06-18 14:47:40 +00:00
2717e7be06
[lsan] Set current_thread_tid correctly for main thread.
...
llvm-svn: 184189
2013-06-18 14:44:45 +00:00
394b09b00f
[sanitizer] Fix Android build.
...
llvm-svn: 184187
2013-06-18 13:56:12 +00:00
fc3f61fcf0
[sanitizer] Remove a set of deprecated ioctls.
...
llvm-svn: 184185
2013-06-18 10:37:17 +00:00
b9c1020696
[sanitizer] Replace ext2_ ioctls with generic fs_ ioctls.
...
They are actually the same, but ext2_fs.h header is not available in userspace
with newer kernels.
llvm-svn: 184184
2013-06-18 09:49:04 +00:00
8fa046e288
[sanitizer] Symbolic ioctl names.
...
Replace hardcoded ioctl request ids with symbolic names.
Disable certain ioctls on platforms where such names are not found in the
system headers.
Fix a bug in ioctl_lookup.
Reenable ioctl test on Mac.
llvm-svn: 184183
2013-06-18 09:22:24 +00:00
5cf581a8d4
tsan: consistently use return pc as top frame pc
...
always substract 1 from the top pc
this allows to get correct stacks with -O2
llvm-svn: 184112
2013-06-17 19:57:03 +00:00
7e325fb477
Properly install LSan interface header, rely on sanitizer header presence in lit tests
...
llvm-svn: 183977
2013-06-14 11:45:36 +00:00
0d7012debb
[TSan] use InternalMmapVector to store fired suppressions
...
llvm-svn: 183974
2013-06-14 11:18:58 +00:00
bd0428b81a
[LSan] Use a typedef for frontier vector
...
llvm-svn: 183973
2013-06-14 10:07:56 +00:00
b0d92b3312
[Sanitizer] Rename InternalVector to InternalMmapVector
...
llvm-svn: 183972
2013-06-14 09:59:40 +00:00
26daccaddb
tsan: fix Windows Go crash
...
llvm-svn: 183898
2013-06-13 10:15:44 +00:00
5e520c5e09
[LSan] fix link flags for building unit tests
...
llvm-svn: 183891
2013-06-13 07:23:18 +00:00
5685aa6845
Fix broken header guard.
...
llvm-svn: 183873
2013-06-12 22:37:22 +00:00
978460c12c
[lsan] Harmonized some naming inconsistencies.
...
llvm-svn: 183748
2013-06-11 15:26:20 +00:00
a8570d38fe
tsan: add -Wno-maybe-uninitialized to Go build script
...
this is how the rest of the codebase is built
llvm-svn: 183738
2013-06-11 11:44:43 +00:00
5129c5e56f
[lsan] Fix the unittest makefiles.
...
llvm-svn: 183735
2013-06-11 09:52:02 +00:00
bc1c6714f2
[Sanitizer] add file forgotten in r183730
...
llvm-svn: 183732
2013-06-11 08:14:24 +00:00
c8e7364763
[Sanitizer] support running external llvm-symbolizer on Mac
...
llvm-svn: 183730
2013-06-11 08:13:36 +00:00
79de34f75c
tsan: fix lit test failures
...
llvm-svn: 183674
2013-06-10 16:06:21 +00:00
b08e72913a
tsan: add system tests for suppressions
...
llvm-svn: 183673
2013-06-10 15:39:28 +00:00
315bb0e687
tsan: allows to suppress races on global variables
...
llvm-svn: 183672
2013-06-10 15:38:44 +00:00
152f7edf24
[ASan] Fix unset-insert-libraries-on-exec.cc on 32-bit Darwin.
...
The test used to execute a 64-bit /bin/bash binary and preload a 32-bit dynamic library into it.
Now the arch-specific version of echo-env is executed instead.
llvm-svn: 183662
2013-06-10 14:47:43 +00:00
f67191b4c3
[ASan] mark ioctl test as xfailing on darwin. remove redundant semicolons
...
llvm-svn: 183655
2013-06-10 14:17:08 +00:00
02062becea
[asan] fix Android build (mark asan_malloc_usable_size as an interface function)
...
llvm-svn: 183651
2013-06-10 13:28:33 +00:00
b19a26b852
tsan: disable getaddrinfo() interceptor for tsan (causes recursion)
...
llvm-svn: 183649
2013-06-10 11:35:08 +00:00
7e4a18c4fb
tsan: fix merge bug
...
llvm-svn: 183648
2013-06-10 11:11:29 +00:00
e71982d589
[asan] fix the bug with memalign and malloc_usable_size ( http://code.google.com/p/address-sanitizer/issues/detail?id=193 ); also fix lint
...
llvm-svn: 183647
2013-06-10 10:46:27 +00:00
b278f1235f
tsan: fix windows crash (incorrect stack boundaries)
...
llvm-svn: 183646
2013-06-10 10:30:54 +00:00
ddb0294dd8
tsan: fix old gcc warnings
...
llvm-svn: 183645
2013-06-10 10:30:19 +00:00
e979c5467c
tsan: fix windows mingw build
...
llvm-svn: 183644
2013-06-10 10:02:02 +00:00
8794772337
tsan: more detailed trace for atomic operations (include address and memory ordering)
...
llvm-svn: 183643
2013-06-10 10:01:31 +00:00
50ef53ebfc
tsan: fix lint warnings
...
llvm-svn: 183642
2013-06-10 10:00:54 +00:00
dd489a4e15
[MSan] don't add msan unit tests to check-msan command if libcxx is not checked out
...
llvm-svn: 183641
2013-06-10 09:09:40 +00:00
4c0ea93725
[ASan] don't use -m{32,64} flag in test case, as it can be run in both 32- and 64-bit modes
...
llvm-svn: 183638
2013-06-10 07:55:12 +00:00
658fb53b7e
Reverting r183529:
...
This is causing the following error on Darwin:
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:282:1: error: 'assertion_failed__282' declared as an array with a negative size
CHECK_TYPE_SIZE(ifconf);
^~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:223:3: note: expanded from macro 'CHECK_TYPE_SIZE'
COMPILER_CHECK(sizeof(__sanitizer_##TYPE) == sizeof(TYPE))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:239:30: note: expanded from macro 'COMPILER_CHECK'
#define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:245:57: note: expanded from macro 'IMPL_COMPILER_ASSERT'
typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
^~~~~~~~~~~~~~~
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:284:1: error: 'assertion_failed__284' declared as an array with a negative size
CHECK_SIZE_AND_OFFSET(ifconf, ifc_ifcu);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:228:3: note: expanded from macro 'CHECK_SIZE_AND_OFFSET'
COMPILER_CHECK(offsetof(__sanitizer_##CLASS, MEMBER) == \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:239:30: note: expanded from macro 'COMPILER_CHECK'
#define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Sandbox/llvm-clean.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:245:57: note: expanded from macro 'IMPL_COMPILER_ASSERT'
typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
^~~~~~~~~~~~~~~
llvm-svn: 183557
2013-06-07 20:28:29 +00:00
cead69d4a3
[sanitizer] Handle SIOCGIFCONF ioctl.
...
llvm-svn: 183529
2013-06-07 15:49:38 +00:00
4fdf8d66a9
[ASan] fix test case to use absolute paths
...
llvm-svn: 183527
2013-06-07 15:44:21 +00:00
6af3fce55e
[ASan] An early return from InitializeAsanInterceptors() on Mac has been considered unobvious.
...
Remove it and replace ASAN_INTERCEPT_FUNC with a no-op if SANITIZER_MAC==1.
llvm-svn: 183524
2013-06-07 15:10:02 +00:00
c24e13e7bb
[sanitizer] Fix Android build.
...
llvm-svn: 183523
2013-06-07 14:56:54 +00:00
74dcb1a8de
[sanitizer] Fix windows build.
...
llvm-svn: 183518
2013-06-07 13:19:33 +00:00
0b1f41b6f4
[sanitizer] ioctl interceptor.
...
ASan: disabled by default
MSan: enabled by default
TSan: disabled
llvm-svn: 183517
2013-06-07 13:00:47 +00:00
Alexander Potapenko