3 Commits

Author	SHA1	Message	Date
Nathan	c3d20fd472	[clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions ... Summary: Typically most main functions have the signature: ``` int main(int argc, char *argv[]) ``` To stick with convention when renaming parameters we should ignore the `argc` and `argv` names even if the parameter style says they should be renamed. This patch addresses this by checking all ParmVarDecls if they form part of a function with a signature that matches main `int name(int argc, char * argv[], (optional char *env[]))` Reviewers: aaron.ballman, JonasToth, alexfh, hokein Reviewed By: aaron.ballman Subscribers: Mordante, merge_guards_bot, xazax.hun, kristof.beyls, cfe-commits Tags: #clang, #clang-tools-extra Differential Revision: https://reviews.llvm.org/D73098	2020-01-27 23:47:51 +00:00
Shoaib Meenai	c72a6ac4b6	Revert "[clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions" ... This reverts commit 27e3671ff4. This was an accidental push, and the author requested a revert on IRC as their local branch is in a bad state.	2020-01-27 11:50:25 -08:00
Nathan	27e3671ff4	[clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions ... Summary: Typically most main functions have the signature: ``` int main(int argc, char *argv[]) ``` To stick with convention when renaming parameters we should ignore the `argc` and `argv` names even if the parameter style says they should be renamed. This patch addresses this by checking all ParmVarDecls if they form part of a function with a signature that matches main `int name(int argc, char * argv[], (optional char *env[]))` Reviewers: aaron.ballman, JonasToth, alexfh, hokein Reviewed By: aaron.ballman Subscribers: Mordante, merge_guards_bot, xazax.hun, kristof.beyls, cfe-commits Tags: #clang, #clang-tools-extra Differential Revision: https://reviews.llvm.org/D73098	2020-01-27 19:23:21 +00:00