4 Commits

Author	SHA1	Message	Date
Jordan Rose	7660f78fb9	Now that -Wobjc-literal-compare is a warning, put the fixit on a note. ... Recovering as if the user had actually called -isEqual: is a bit too far from the semantics of the program as written, /even though/ it's probably what they intended. llvm-svn: 160377	2012-07-17 17:46:40 +00:00
Jordan Rose	f919803001	Downgrade the "direct comparison" error for ObjC literals to a warning. ... Chris pointed out that while the comparison is certainly problematic and does not have well-defined behavior, it isn't any worse than some of the other abuses that we merely warn about and doesn't need to make the compilation fail. Revert the release notes change (r159766) now that this is just a new warning. llvm-svn: 159939	2012-07-09 16:54:44 +00:00
Jordan Rose	d49a33e86c	Disallow using ObjC literals in direct comparisons (== and friends). ... Objective-C literals conceptually always create new objects, but may be optimized by the compiler or runtime (constant folding, singletons, etc). Comparing addresses of these objects is relying on this optimization behavior, which is really an implementation detail. In the case of == and !=, offer a fixit to a call to -isEqual:, if the method is available. This fixit is directly on the error so that it is automatically applied. Most of the time, this is really a newbie mistake, hence the fixit. llvm-svn: 158230	2012-06-08 21:14:25 +00:00
Ted Kremenek	77006f6875	And libclang cursor/indexing support for new Objective-C NSArray/NSDictionary/NSNumber literals. ... llvm-svn: 152138	2012-03-06 20:06:06 +00:00