57fc9582f9
Make -Wstring-plus-int warns even if when the result is not out of bounds
...
Summary: Patch by Arnaud Bienner
Reviewers: sylvestre.ledru, thakis, serge-sans-paille
Reviewed By: thakis
Subscribers: arphaman, dyung, anemet, llvm-commits, cfe-commits
Differential Revision: https://reviews.llvm.org/D55382
llvm-svn: 350335
2019-01-03 17:45:28 +00:00
cbb8aa196b
Revert "Make -Wstring-plus-int warns even if when the result is not out of bounds"
...
This reverts commit r349054.
It's causing:
FAILED: tools/clang/bindings/python/tests/CMakeFiles/check-clang-python
FAIL: test_diagnostic_range (tests.cindex.test_diagnostics.TestDiagnostics)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/buildslave/jenkins/workspace/clang-stage1-configure-RA/llvm/tools/clang/bindings/python/tests/cindex/test_diagnostics.py",
line 55, in test_diagnostic_range
self.assertEqual(len(tu.diagnostics), 1)
AssertionError: 2 != 1
======================================================================
FAIL: test_diagnostic_warning (tests.cindex.test_diagnostics.TestDiagnostics)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/buildslave/jenkins/workspace/clang-stage1-configure-RA/llvm/tools/clang/bindings/python/tests/cindex/test_diagnostics.py",
line 18, in test_diagnostic_warning
self.assertEqual(len(tu.diagnostics), 2)
AssertionError: 1 != 2
llvm-svn: 349117
2018-12-14 00:43:34 +00:00
8523c085e7
Make -Wstring-plus-int warns even if when the result is not out of bounds
...
Summary: Patch by Arnaud Bienner
Reviewers: sylvestre.ledru, thakis
Reviewed By: thakis
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D55382
llvm-svn: 349054
2018-12-13 16:06:23 +00:00
7e21745e22
Sema: Don't diagnose string + int if the int is value dependent
...
Don't send a value dependent expression into the expression evaluator,
HandleSizeof would crash. Making HandleSizeof handle dependent types
would noisily warn about the operation even if everything turns out OK
after instantiation.
This fixes PR21848.
llvm-svn: 224240
2014-12-15 10:00:35 +00:00
9b9ebfc090
Add a test for the -Wstring-plus-int fixit note.
...
llvm-svn: 151951
2012-03-02 23:01:20 +00:00
ccec40d9b7
Add -Wstring-plus-int, which warns on "str" + int and int + "str".
...
It doesn't warn if the integer is known at compile time and within
the bounds of the string.
Discussion: http://comments.gmane.org/gmane.comp.compilers.clang.scm/47203
llvm-svn: 151943
2012-03-02 22:01:22 +00:00
Arnaud Bienner