7 Commits

Author	SHA1	Message	Date
Nico Weber	b28ffd8f35	driver: Don't warn about assembler flags being unused when not assembling; different approach ... This morally relands r365703 (and r365714), originally reviewed at https://reviews.llvm.org/D64527, but with a different implementation. Relanding the same approach with a fix for the revert reason got a bit involved (see https://reviews.llvm.org/D65108) so use a simpler approach with a more localized implementation (that in return duplicates code a bit more). This approach also doesn't validate flags for the integrated assembler if the assembler step doesn't run. Fixes PR42066. Differential Revision: https://reviews.llvm.org/D65233 llvm-svn: 367165	2019-07-27 01:13:00 +00:00
Reid Kleckner	a3aa67b7f9	Revert driver: Don't warn about assembler flags being unused when not assembling ... This reverts r365703 (git commit 101c1afdfd) and r365714. This broke some autoconf-style assembler flags checks in the Linux build: https://github.com/ClangBuiltLinux/linux/issues/598 llvm-svn: 365956	2019-07-12 20:44:57 +00:00
Nico Weber	3daf58faa2	Attempt to fix bots after r365703 ... llvm-svn: 365714	2019-07-10 23:50:16 +00:00
Nico Weber	101c1afdfd	driver: Don't warn about assembler flags being unused when not assembling ... clang currently warns when passing flags for the assembler (e.g. -Wa,-mbig-obj) to an invocation that doesn't run the assembler (e.g. -E). At first sight, that makes sense -- the flag really is unused. But many other flags don't have an effect if no assembler runs (e.g. -fno-integrated-as, -ffunction-sections, and many others), and those currently don't warn. So this seems more like a side effect of how CollectArgsForIntegratedAssembler() is implemented than like an intentional feature. Since it's a bit inconvenient when debugging builds and adding -E, always call CollectArgsForIntegratedAssembler() to make sure assembler args always get claimed. Currently, this affects only these flags: -mincremental-linker-compatible, -mimplicit-it= (on ARM), -Wa, -Xassembler It does have the side effect that assembler options now need to be valid even if -E is passed. Previously, `-Wa,-mbig-obj` would error for non-coff output only if the assembler ran, now it always errors. This too makes assembler flags more consistent with all the other flags and seems like a progression. Fixes PR42066. Differential Revision: https://reviews.llvm.org/D64527 llvm-svn: 365703	2019-07-10 22:29:35 +00:00
Renato Golin	a74bbc7b36	Pass -I options to integrates and external assemblers ... Fixes PR21000. Patch by Artem Belevich. llvm-svn: 242904	2015-07-22 15:32:36 +00:00
Artem Belevich	c3e2fd7bea	Revert "PR21000: pass -I options to assembler" as the test was failing on hexagon. ... llvm-svn: 235919	2015-04-27 21:11:08 +00:00
Artem Belevich	8fe8ed56ee	PR21000: pass -I options to assembler ... Pass -I options to assembly so it can find files included with .include. Differential Revision: http://reviews.llvm.org/D7472 llvm-svn: 235915	2015-04-27 20:51:44 +00:00