maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLDB][Clang Integration][NFC] Remove redundant condition 

Condition `omit_empty_base_classes` is checked both in an outer and
in an inner `if` statement in `TypeSystemClang::GetNumBaseClasses()`.
This patch removes the redundant inner check.

The issue was found using `clang-tidy` check under review
`misc-redundant-condition`. See https://reviews.llvm.org/D81272.

Differential Revision: https://reviews.llvm.org/D82559
This commit is contained in:
Adam Balogh 2020-06-25 16:20:29 +02:00
parent 1b2d2d70e1
commit ff2d09148c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
View File

@ -1729,10 +1729,8 @@ TypeSystemClang::GetNumBaseClasses(const CXXRecordDecl *cxx_record_decl,
base_class_end = cxx_record_decl->bases_end();
base_class != base_class_end; ++base_class) {
// Skip empty base classes
if (omit_empty_base_classes) {
if (BaseSpecifierIsEmpty(base_class))
continue;
}
if (BaseSpecifierIsEmpty(base_class))
continue;
++num_bases;
}
} else