Factor out parsing and allocation of IdentifierLoc objects.

llvm-svn: 189833

clang/include/clang/Parse/Parser.h

@@ -1891,6 +1891,7 @@ private:
                              IdentifierInfo *ScopeName,
                              SourceLocation ScopeLoc,
                              AttributeList::Syntax Syntax);
+  IdentifierLoc *ParseIdentifierLoc();
 
   void MaybeParseCXX11Attributes(Declarator &D) {
     if (getLangOpts().CPlusPlus11 && isCXX11AttributeSpecifier()) {

clang/include/clang/Sema/AttributeList.h

@@ -46,10 +46,12 @@ struct AvailabilityChange {
 };
 
 /// \brief Wraps an identifier and optional source location for the identifier.
-/// It is expected that these will be created from the ASTContext memory pool.
 struct IdentifierLoc {
   SourceLocation Loc;
   IdentifierInfo *Ident;
+
+  static IdentifierLoc *create(ASTContext &Ctx, SourceLocation Loc,
+                               IdentifierInfo *Ident);
 };
 
 /// \brief A union of the various pointer types that can be passed to an

clang/lib/Parse/ParseDecl.cpp

@@ -13,7 +13,6 @@
 
 #include "clang/Parse/Parser.h"
 #include "RAIIObjectsForParser.h"
-#include "clang/AST/ASTContext.h"
 #include "clang/AST/DeclTemplate.h"
 #include "clang/Basic/AddressSpaces.h"
 #include "clang/Basic/CharInfo.h"
@@ -187,6 +186,15 @@ static bool attributeHasExprArgs(const IdentifierInfo &II) {
            .Default(false);
 }
 
+IdentifierLoc *Parser::ParseIdentifierLoc() {
+  assert(Tok.is(tok::identifier) && "expected an identifier");
+  IdentifierLoc *IL = IdentifierLoc::create(Actions.Context,
+                                            Tok.getLocation(),
+                                            Tok.getIdentifierInfo());
+  ConsumeToken();
+  return IL;
+}
+
 /// Parse the arguments to a parameterized GNU attribute or
 /// a C++11 attribute in "gnu" namespace.
 void Parser::ParseGNUAttributeArgs(IdentifierInfo *AttrName,
@@ -259,10 +267,7 @@ void Parser::ParseGNUAttributeArgs(IdentifierInfo *AttrName,
     if (attributeHasExprArgs(*AttrName))
       break;
 
-    IdentifierLoc *Param = ::new (Actions.Context) IdentifierLoc;
+    ArgExprs.push_back(ParseIdentifierLoc());
-    Param->Ident = Tok.getIdentifierInfo();
-    Param->Loc = ConsumeToken();
-    ArgExprs.push_back(Param);
   } break;
 
   default:
@@ -828,10 +833,7 @@ void Parser::ParseAvailabilityAttribute(IdentifierInfo &Availability,
     SkipUntil(tok::r_paren);
     return;
   }
-
+  IdentifierLoc *Platform = ParseIdentifierLoc();
-  IdentifierLoc *Platform = new (Actions.Context) IdentifierLoc;
-  Platform->Ident = Tok.getIdentifierInfo();
-  Platform->Loc = ConsumeToken();
 
   // Parse the ',' following the platform name.
   if (ExpectAndConsume(tok::comma, diag::err_expected_comma, "", tok::r_paren))
@@ -1202,9 +1204,7 @@ void Parser::ParseTypeTagForDatatypeAttribute(IdentifierInfo &AttrName,
     T.skipToEnd();
     return;
   }
-  IdentifierLoc *ArgumentKind = new (Actions.Context) IdentifierLoc;
+  IdentifierLoc *ArgumentKind = ParseIdentifierLoc();
-  ArgumentKind->Ident = Tok.getIdentifierInfo();
-  ArgumentKind->Loc = ConsumeToken();
 
   if (Tok.isNot(tok::comma)) {
     Diag(Tok, diag::err_expected_comma);

clang/lib/Sema/AttributeList.cpp

@@ -19,6 +19,14 @@
 #include "llvm/ADT/StringSwitch.h"
 using namespace clang;
 
+IdentifierLoc *IdentifierLoc::create(ASTContext &Ctx, SourceLocation Loc,
+                                     IdentifierInfo *Ident) {
+  IdentifierLoc *Result = new (Ctx) IdentifierLoc;
+  Result->Loc = Loc;
+  Result->Ident = Ident;
+  return Result;
+}
+
 size_t AttributeList::allocated_size() const {
   if (IsAvailability) return AttributeFactory::AvailabilityAllocSize;
   else if (IsTypeTagForDatatype)