maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Some more cleanup of the ValueObjectConstResultImpl code. NFC. 

llvm-svn: 224160
This commit is contained in:
Enrico Granata 2014-12-12 22:37:44 +00:00
parent a604d6c84d
commit fea9039511
4 changed files with 2 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lldb/include/lldb/Core/ValueObjectChild.h
View File

@ -106,6 +106,7 @@ protected:
protected:
friend class ValueObject;
friend class ValueObjectConstResult;
friend class ValueObjectConstResultImpl;
ValueObjectChild (ValueObject &parent,
const ClangASTType &clang_type,
const ConstString &name,

10
lldb/include/lldb/Core/ValueObjectConstResultImpl.h
View File

@ -47,13 +47,6 @@ public:
lldb::ValueObjectSP
AddressOf (Error &error);
bool
NeedsDerefOnTarget()
{
m_impl_backend->UpdateValueIfNeeded(false);
return (m_impl_backend->GetValue().GetValueType() == Value::eValueTypeHostAddress);
}
lldb::addr_t
GetLiveAddress()
{
@ -68,9 +61,6 @@ public:
m_live_address_type = address_type;
}
lldb::ValueObjectSP
DerefOnTarget();
virtual lldb::addr_t
GetAddressOf (bool scalar_is_load_address = true,
AddressType *address_type = NULL);

17
lldb/source/Core/ValueObjectConstResultImpl.cpp
View File

@ -40,23 +40,6 @@ ValueObjectConstResultImpl::ValueObjectConstResultImpl (ValueObject* valobj,
{
}
lldb::ValueObjectSP
ValueObjectConstResultImpl::DerefOnTarget()
{
if (m_load_addr_backend.get() == NULL)
{
lldb::addr_t tgt_address = m_impl_backend->GetPointerValue();
ExecutionContext exe_ctx (m_impl_backend->GetExecutionContextRef());
m_load_addr_backend = ValueObjectConstResult::Create (exe_ctx.GetBestExecutionContextScope(),
m_impl_backend->GetClangType(),
m_impl_backend->GetName(),
tgt_address,
eAddressTypeLoad,
exe_ctx.GetAddressByteSize());
}
return m_load_addr_backend;
}
lldb::ValueObjectSP
ValueObjectConstResultImpl::Dereference (Error &error)
{

2
lldb/test/expression_command/formatters/TestFormatters.py
View File

@ -128,7 +128,7 @@ class ExprFormattersTestCase(TestBase):
self.runCmd("type summary add -F formatters.foo_SummaryProvider foo")
self.expect("expression $" + object_name,
substrs = ['(foo) $', 'a = 121','a_ptr = ', ' -> 122','i = 242', 'i_ptr = ', ' -> 8888', 'h = 245','k = 247'])
substrs = ['(foo) $', 'a = 121','a_ptr = ', ' -> 122','i = 242', 'i_ptr = ', ' -> 8888','k = 247'])
process = self.dbg.GetSelectedTarget().GetProcess()
thread = process.GetThreadAtIndex(0)