maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Send error message on failed attach from debugerserver. 

Instead of using a magic return error code from debugserver to
indicate that an attach failed because of SIP being enabled in
RNBRemote::HandlePacket_v, use the extended error reporting that
Pavel added to lldb/lldb-server in https://reviews.llvm.org/D45573


<rdar://problem/39398385> 

llvm-svn: 369990
This commit is contained in:
Jason Molenda 2019-08-27 00:08:27 +00:00
parent 2f858c2e91
commit fe64323fd5
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lldb/tools/debugserver/source/RNBRemote.cpp
View File

@ -2667,6 +2667,17 @@ void append_hex_value(std::ostream &ostrm, const void *buf, size_t buf_size,
}
}
std::string cstring_to_asciihex_string(const char *str) {
std::string hex_str;
hex_str.reserve (strlen (str) * 2);
while (str && *str) {
char hexbuf[5];
snprintf (hexbuf, sizeof(hexbuf), "%02x", *str++);
hex_str += hexbuf;
}
return hex_str;
}
void append_hexified_string(std::ostream &ostrm, const std::string &string) {
size_t string_size = string.size();
const char *string_buf = string.c_str();
@ -3818,8 +3829,13 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
}
}
if (attach_failed_due_to_sip) {
SendPacket("E87"); // E87 is the magic value which says that we are
// not allowed to attach
std::string return_message = "E96;";
return_message += cstring_to_asciihex_string(
"Process attach denied, possibly because "
"System Integrity Protection is enabled and "
"process does not allow attaching.");
SendPacket(return_message.c_str());
DNBLogError("Attach failed because process does not allow "
"attaching: \"%s\".",
err_str);