maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

The pass manager is not able to schedule -loop-deletion -loop-index-split. 

The loop-deletion pass does not preserve dom frontier, which is required by
loop-index-split. When the PM checks dom frontier for loop-index-split, it has
already verified that lcssa is availalble. However, new dom frontier forces new
loop pass manager, which does not  have lcssa yet.

The PM should recheck availability of required analysis passes in such cases.

llvm-svn: 54805
This commit is contained in:
Devang Patel 2008-08-14 23:07:48 +00:00
parent 861bec78f8
commit fdee7034b3
2 changed files with 33 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
llvm/lib/VMCore/PassManager.cpp
View File

@ -463,6 +463,10 @@ void PMTopLevelManager::schedulePass(Pass *P) {
AnalysisUsage *AnUsage = findAnalysisUsage(P);
bool checkAnalysis = true;
while (checkAnalysis) {
checkAnalysis = false;
const AnalysisUsage::VectorType &RequiredSet = AnUsage->getRequiredSet();
for (AnalysisUsage::VectorType::const_iterator I = RequiredSet.begin(),
E = RequiredSet.end(); I != E; ++I) {
@ -470,15 +474,25 @@ void PMTopLevelManager::schedulePass(Pass *P) {
Pass *AnalysisPass = findAnalysisPass(*I);
if (!AnalysisPass) {
AnalysisPass = (*I)->createPass();
// Schedule this analysis run first only if it is not a lower level
// analysis pass. Lower level analsyis passes are run on the fly.
if (P->getPotentialPassManagerType () >=
if (P->getPotentialPassManagerType () ==
AnalysisPass->getPotentialPassManagerType())
// Schedule analysis pass that is managed by the same pass manager.
schedulePass(AnalysisPass);
else if (P->getPotentialPassManagerType () >
AnalysisPass->getPotentialPassManagerType()) {
// Schedule analysis pass that is managed by a new manager.
schedulePass(AnalysisPass);
// Recheck analysis passes to ensure that required analysises that
// are already checked are still available.
checkAnalysis = true;
}
else
// Do not schedule this analysis. Lower level analsyis
// passes are run on the fly.
delete AnalysisPass;
}
}
}
// Now all required passes are available.
addTopLevelPass(P);

5
llvm/test/Other/2008-08-14-PassManager.ll Normal file
View File

@ -0,0 +1,5 @@
; RUN: llvm-as < %s | opt -loop-deletion -loop-index-split -disable-output
; PR 2640
define i32 @test1() {
ret i32 0;
}