maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Attributor] Verify `checkForAllUses` return value properly 

Also do not emit more than one remark after Heap2Stack failed.
This commit is contained in:
Johannes Doerfert 2021-07-27 17:30:53 -05:00
parent ed7ec860f0
commit fd520e75f1
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
View File

@ -6163,7 +6163,8 @@ ChangeStatus AAHeapToStackFunction::updateImpl(Attributor &A) {
"parameter as `__attribute__((noescape))` to override.";
};
if (AI.LibraryFunctionId == LibFunc___kmpc_alloc_shared)
if (ValidUsesOnly &&
AI.LibraryFunctionId == LibFunc___kmpc_alloc_shared)
A.emitRemark<OptimizationRemarkMissed>(AI.CB, "OMP113", Remark);
LLVM_DEBUG(dbgs() << "[H2S] Bad user: " << *UserI << "\n");
@ -6183,7 +6184,8 @@ ChangeStatus AAHeapToStackFunction::updateImpl(Attributor &A) {
ValidUsesOnly = false;
return true;
};
A.checkForAllUses(Pred, *this, *AI.CB);
if (!A.checkForAllUses(Pred, *this, *AI.CB))
return false;
return ValidUsesOnly;
};