From fcffa7c201c6c2d703a69dc6443caac68a224427 Mon Sep 17 00:00:00 2001 From: David Bolvansky Date: Thu, 11 Jul 2019 20:14:22 +0000 Subject: [PATCH] [UpdateTestChecks] Emit warning when invalid test paths Summary: Recently I ran into the following issue: ./update_test_checks.py /path/not-existing-file.ll The script was silent and I was suprised why the real test file hadn't been updated. Solution: Emit warning if we detect this problem. Reviewers: lebedev.ri, spatel, jdoerfert, nikic Reviewed By: lebedev.ri, spatel, jdoerfert, nikic Subscribers: jdoerfert, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D64572 llvm-svn: 365818 --- llvm/utils/update_test_checks.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/llvm/utils/update_test_checks.py b/llvm/utils/update_test_checks.py index de2900a4ab6e..92ce0535a109 100755 --- a/llvm/utils/update_test_checks.py +++ b/llvm/utils/update_test_checks.py @@ -73,7 +73,13 @@ def main(): sys.exit(1) opt_basename = 'opt' - test_paths = [test for pattern in args.tests for test in glob.glob(pattern)] + test_paths = [] + for test in args.tests: + if not glob.glob(test): + print('WARNING: Test file \'%s\' was not found. Ignoring it.' % (test,), file=sys.stderr) + continue + test_paths.append(test) + for test in test_paths: if args.verbose: print('Scanning for RUN lines in test file: %s' % (test,), file=sys.stderr)