[clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D73619

clang-tools-extra/clangd/ClangdServer.h

@@ -165,12 +165,6 @@ public:
                const FileSystemProvider &FSProvider, const Options &Opts,
                Callbacks *Callbacks = nullptr);
 
-  // FIXME: remove this compatibility alias.
-  ClangdServer(const GlobalCompilationDatabase &CDB,
-               const FileSystemProvider &FSProvider, Callbacks &Callbacks,
-               const Options &Opts)
-      : ClangdServer(CDB, FSProvider, Opts, &Callbacks) {}
-
   /// Add a \p File to the list of tracked C++ files or update the contents if
   /// \p File is already tracked. Also schedules parsing of the AST for it on a
   /// separate thread. When the parsing is complete, DiagConsumer passed in
@@ -359,9 +353,6 @@ private:
   TUScheduler WorkScheduler;
 };
 
-// FIXME: Remove this compatibility alias.
-using DiagnosticsConsumer = ClangdServer::Callbacks;
-
 } // namespace clangd
 } // namespace clang