From fc6c3e73cdc9005035612c0264ea7ccf85383403 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Fri, 16 Jul 2010 16:54:17 +0000 Subject: [PATCH] When performing template name lookup for a dependent member access expression such as the "foo" in "this->blah.foo<1, 2>", and we can't look into the type of "this->blah" (e.g., because it is dependent), look into the local scope of a template of the same name. Fixes . llvm-svn: 108531 --- clang/lib/Sema/SemaTemplate.cpp | 10 +++++----- .../member-template-access-expr.cpp | 19 +++++++++++++++++++ 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp index f121954eed6e..c654e008b502 100644 --- a/clang/lib/Sema/SemaTemplate.cpp +++ b/clang/lib/Sema/SemaTemplate.cpp @@ -238,13 +238,10 @@ void Sema::LookupTemplateName(LookupResult &Found, // expression. If the identifier is not found, it is then looked up in // the context of the entire postfix-expression and shall name a class // or function template. - // - // FIXME: When we're instantiating a template, do we actually have to - // look in the scope of the template? Seems fishy... if (S) LookupName(Found, S); ObjectTypeSearchedInScope = true; } - } else if (isDependent) { + } else if (isDependent && (!S || ObjectType.isNull())) { // We cannot look into a dependent object type or nested nme // specifier. MemberOfUnknownSpecialization = true; @@ -282,8 +279,11 @@ void Sema::LookupTemplateName(LookupResult &Found, } FilterAcceptableTemplateNames(Context, Found); - if (Found.empty()) + if (Found.empty()) { + if (isDependent) + MemberOfUnknownSpecialization = true; return; + } if (S && !ObjectType.isNull() && !ObjectTypeSearchedInScope) { // C++ [basic.lookup.classref]p1: diff --git a/clang/test/SemaTemplate/member-template-access-expr.cpp b/clang/test/SemaTemplate/member-template-access-expr.cpp index ea17cdbb5864..dbd27c456c51 100644 --- a/clang/test/SemaTemplate/member-template-access-expr.cpp +++ b/clang/test/SemaTemplate/member-template-access-expr.cpp @@ -123,3 +123,22 @@ namespace PR6021 { }; }; } + +namespace rdar8198511 { + template + struct Base { + void f(); + }; + + template + struct X0 : Base<1, T> { }; + + template + struct X1 { + X0 x0; + + void f() { + this->x0.Base<1, int>::f(); + } + }; +}