maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

DebugInfo: Remove CompileUnit::constructTypeDIEImpl now that it's just a simple wrapper again. 

r195698 moved the type unit checking up into getOrCreateTypeDIE so
remove the redundant check and fold the functions back together again.

llvm-svn: 195700
This commit is contained in:
David Blaikie 2013-11-26 00:35:04 +00:00
parent 0decd7da5a
commit fbd29eb3b6
2 changed files with 2 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
View File

@ -923,7 +923,7 @@ DIE *CompileUnit::createTypeDIE(DICompositeType Ty) {
// Create new type. // Create new type.
TyDIE = createAndAddDIE(Ty.getTag(), *ContextDIE, Ty); TyDIE = createAndAddDIE(Ty.getTag(), *ContextDIE, Ty);
constructTypeDIEImpl(*TyDIE, Ty); constructTypeDIE(*TyDIE, Ty);
updateAcceleratorTables(Context, Ty, TyDIE); updateAcceleratorTables(Context, Ty, TyDIE);
return TyDIE; return TyDIE;
@ -994,7 +994,7 @@ DIE *CompileUnit::getOrCreateTypeDIE(const MDNode *TyNode) {
// Skip updating the accellerator tables since this is not the full type // Skip updating the accellerator tables since this is not the full type
return TyDIE; return TyDIE;
} }
constructTypeDIEImpl(*TyDIE, CTy); constructTypeDIE(*TyDIE, CTy);
} else { } else {
assert(Ty.isDerivedType() && "Unknown kind of DIType"); assert(Ty.isDerivedType() && "Unknown kind of DIType");
constructTypeDIE(*TyDIE, DIDerivedType(Ty)); constructTypeDIE(*TyDIE, DIDerivedType(Ty));
@ -1169,15 +1169,6 @@ void CompileUnit::constructTypeDIE(DIE &Buffer, DIDerivedType DTy) {
/// constructTypeDIE - Construct type DIE from DICompositeType. /// constructTypeDIE - Construct type DIE from DICompositeType.
void CompileUnit::constructTypeDIE(DIE &Buffer, DICompositeType CTy) { void CompileUnit::constructTypeDIE(DIE &Buffer, DICompositeType CTy) {
// If this is a type applicable to a type unit it then add it to the
// list of types we'll compute a hash for later.
if (shouldCreateTypeUnit(CTy, DD))
DD->addTypeUnitType(&Buffer, CTy);
else
constructTypeDIEImpl(Buffer, CTy);
}
void CompileUnit::constructTypeDIEImpl(DIE &Buffer, DICompositeType CTy) {
// Add name if not anonymous or intermediate type. // Add name if not anonymous or intermediate type.
StringRef Name = CTy.getName(); StringRef Name = CTy.getName();

4
llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
View File

@ -327,10 +327,6 @@ public:
DIE *createAndAddDIE(unsigned Tag, DIE &Parent, DIE *createAndAddDIE(unsigned Tag, DIE &Parent,
DIDescriptor N = DIDescriptor()); DIDescriptor N = DIDescriptor());
/// constructTypeDIEImpl - Construct type DIE that is not a type unit
/// reference from a DICompositeType.
void constructTypeDIEImpl(DIE &Buffer, DICompositeType CTy);
/// Compute the size of a header for this unit, not including the initial /// Compute the size of a header for this unit, not including the initial
/// length field. /// length field.
unsigned getHeaderSize() const { unsigned getHeaderSize() const {