diff --git a/llvm/lib/CodeGen/VirtRegMap.cpp b/llvm/lib/CodeGen/VirtRegMap.cpp index aae13d8da614..0e00f7827bdc 100644 --- a/llvm/lib/CodeGen/VirtRegMap.cpp +++ b/llvm/lib/CodeGen/VirtRegMap.cpp @@ -1317,23 +1317,6 @@ void LocalSpiller::TransferDeadness(MachineBasicBlock *MBB, unsigned CurDist, } } -/// hasLaterNon2AddrUse - If the MI has another use of the specified virtual -/// register later and it's not a two-address, return true. That means it's -/// safe to mark the current use at 'i' isKill. -static bool hasLaterNon2AddrUse(MachineInstr &MI, unsigned i, unsigned VirtReg){ - const TargetInstrDesc &TID = MI.getDesc(); - - ++i; - for (unsigned e = TID.getNumOperands(); i != e; ++i) { - const MachineOperand &MO = MI.getOperand(i); - if (!MO.isReg() || MO.getReg() != VirtReg) - continue; - if (TID.getOperandConstraint(i, TOI::TIED_TO) == -1) - return true; - } - return false; -} - /// rewriteMBB - Keep track of which spills are available even after the /// register allocator is done with them. If possible, avid reloading vregs. void LocalSpiller::RewriteMBB(MachineBasicBlock &MBB, VirtRegMap &VRM, @@ -1357,6 +1340,7 @@ void LocalSpiller::RewriteMBB(MachineBasicBlock &MBB, VirtRegMap &VRM, SmallSet ReMatDefs; // Clear kill info. + SmallSet KilledMIRegs; RegKills.reset(); KillOps.clear(); KillOps.resize(TRI->getNumRegs(), NULL); @@ -1539,6 +1523,7 @@ void LocalSpiller::RewriteMBB(MachineBasicBlock &MBB, VirtRegMap &VRM, // Process all of the spilled uses and all non spilled reg references. SmallVector PotentialDeadStoreSlots; + KilledMIRegs.clear(); for (unsigned j = 0, e = VirtUseOps.size(); j != e; ++j) { unsigned i = VirtUseOps[j]; MachineOperand &MO = MI.getOperand(i); @@ -1655,8 +1640,11 @@ void LocalSpiller::RewriteMBB(MachineBasicBlock &MBB, VirtRegMap &VRM, // Mark is isKill if it's there no other uses of the same virtual // register and it's not a two-address operand. IsKill will be // unset if reg is reused. - if (ti == -1 && !hasLaterNon2AddrUse(MI, i, VirtReg)) + if (ti == -1 && KilledMIRegs.count(VirtReg) == 0) { MI.getOperand(i).setIsKill(); + KilledMIRegs.insert(VirtReg); + } + continue; } // CanReuse @@ -1751,8 +1739,11 @@ void LocalSpiller::RewriteMBB(MachineBasicBlock &MBB, VirtRegMap &VRM, Spills.addAvailable(SSorRMId, PhysReg); // Assumes this is the last use. IsKill will be unset if reg is reused // unless it's a two-address operand. - if (TID.getOperandConstraint(i, TOI::TIED_TO) == -1) + if (TID.getOperandConstraint(i, TOI::TIED_TO) == -1 && + KilledMIRegs.count(VirtReg) == 0) { MI.getOperand(i).setIsKill(); + KilledMIRegs.insert(VirtReg); + } unsigned RReg = SubIdx ? TRI->getSubReg(PhysReg, SubIdx) : PhysReg; MI.getOperand(i).setReg(RReg); UpdateKills(*prior(MII), RegKills, KillOps, TRI); diff --git a/llvm/test/CodeGen/X86/2009-03-09-SpillerBug.ll b/llvm/test/CodeGen/X86/2009-03-09-SpillerBug.ll new file mode 100644 index 000000000000..14bdcc302775 --- /dev/null +++ b/llvm/test/CodeGen/X86/2009-03-09-SpillerBug.ll @@ -0,0 +1,18 @@ +; RUN: llvm-as < %s | llc -mtriple=i386-pc-linux-gnu +; PR3706 + +define void @__mulxc3(x86_fp80 %b) nounwind { +entry: + %call = call x86_fp80 @y(x86_fp80* null, x86_fp80* null) ; [#uses=0] + %cmp = fcmp ord x86_fp80 %b, 0xK00000000000000000000 ; [#uses=1] + %sub = sub x86_fp80 %b, %b ; [#uses=1] + %cmp7 = fcmp uno x86_fp80 %sub, 0xK00000000000000000000 ; [#uses=1] + %and12 = and i1 %cmp7, %cmp ; [#uses=1] + %and = zext i1 %and12 to i32 ; [#uses=1] + %conv9 = sitofp i32 %and to x86_fp80 ; [#uses=1] + store x86_fp80 %conv9, x86_fp80* null + store x86_fp80 %b, x86_fp80* null + ret void +} + +declare x86_fp80 @y(x86_fp80*, x86_fp80*)