maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix ASTMatchersNodeTest to work on Windows. 

It was failing because it had an explicit check for whether we're on
Windows.

There are a few other similar explicit checks in this file which I
didn't remove because they serve as reasonable documentation that the
test doesn't work with a Windows triple.

llvm-svn: 274269
This commit is contained in:
Justin Lebar 2016-06-30 20:29:29 +00:00
parent 3629343d2b
commit fb2efeb804
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp
View File

@ -82,13 +82,11 @@ TEST(NameableDeclaration, REMatchesVariousDecls) {
TEST(DeclarationMatcher, MatchClass) { TEST(DeclarationMatcher, MatchClass) {
DeclarationMatcher ClassMatcher(recordDecl()); DeclarationMatcher ClassMatcher(recordDecl());
llvm::Triple Triple(llvm::sys::getDefaultTargetTriple());
if (Triple.getOS() != llvm::Triple::Win32 || // This passes on Windows only because we explicitly pass -target
Triple.getEnvironment() != llvm::Triple::MSVC) // i386-unknown-unknown. If we were to compile with the default target
// triple, we'd want to EXPECT_TRUE if it's Win32 or MSVC.
EXPECT_FALSE(matches("", ClassMatcher)); EXPECT_FALSE(matches("", ClassMatcher));
else
// Matches class type_info.
EXPECT_TRUE(matches("", ClassMatcher));
DeclarationMatcher ClassX = recordDecl(recordDecl(hasName("X"))); DeclarationMatcher ClassX = recordDecl(recordDecl(hasName("X")));
EXPECT_TRUE(matches("class X;", ClassX)); EXPECT_TRUE(matches("class X;", ClassX));