maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLDB][Python] warning fix for LLDBSwigPythonBreakpointCallbackFunction 

This is a quick followup to this commit:

https://reviews.llvm.org/rGa69bbe02a2352271e8b14542073f177e24c499c1

In that, I #pragma-squelch this warning in `ScriptInterpreterPython.cpp`
but we get the same warning in `PythonTestSuite.cpp`.

This patch squelches the same warning in the same way as the
reviweed commit.   I'm submitting it without review under the
"obviously correct" rule.

At least if this is incorrect the main commit was also incorrect.

By the way, as far as I can tell, these functions are extern "C" because
SWIG does that to everything, not because they particularly need to be.
This commit is contained in:
Lawrence D'Anna 2019-10-29 20:07:08 -07:00
parent 3071ebf7b3
commit fb01c01bf3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp
View File

@ -59,6 +59,9 @@ extern "C" void init_lldb(void) {}
#define LLDBSwigPyInit init_lldb #define LLDBSwigPyInit init_lldb
#endif #endif
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wreturn-type-c-linkage"
extern "C" llvm::Expected<bool> LLDBSwigPythonBreakpointCallbackFunction( extern "C" llvm::Expected<bool> LLDBSwigPythonBreakpointCallbackFunction(
const char *python_function_name, const char *session_dictionary_name, const char *python_function_name, const char *session_dictionary_name,
const lldb::StackFrameSP &sb_frame, const lldb::StackFrameSP &sb_frame,
@ -67,6 +70,8 @@ extern "C" llvm::Expected<bool> LLDBSwigPythonBreakpointCallbackFunction(
return false; return false;
} }
#pragma clang diagnostic pop
extern "C" bool LLDBSwigPythonWatchpointCallbackFunction( extern "C" bool LLDBSwigPythonWatchpointCallbackFunction(
const char *python_function_name, const char *session_dictionary_name, const char *python_function_name, const char *session_dictionary_name,
const lldb::StackFrameSP &sb_frame, const lldb::WatchpointSP &sb_wp) { const lldb::StackFrameSP &sb_frame, const lldb::WatchpointSP &sb_wp) {