diff --git a/clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp index 17ed692a6c18..f3f169b4e0a9 100644 --- a/clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp @@ -31,6 +31,8 @@ class CallAndMessageChecker check::PreCall > { mutable OwningPtr BT_call_null; mutable OwningPtr BT_call_undef; + mutable OwningPtr BT_cxx_call_null; + mutable OwningPtr BT_cxx_call_undef; mutable OwningPtr BT_call_arg; mutable OwningPtr BT_msg_undef; mutable OwningPtr BT_objc_prop_undef; @@ -239,14 +241,35 @@ void CallAndMessageChecker::checkPreStmt(const CallExpr *CE, void CallAndMessageChecker::checkPreCall(const CallEvent &Call, CheckerContext &C) const { + // If this is a call to a C++ method, check if the callee is null or + // undefined. + // FIXME: Generalize this to CXXInstanceCall once it supports + // getCXXThisVal(). + if (const CXXMemberCall *CC = dyn_cast(&Call)) { + SVal V = CC->getCXXThisVal(); + if (V.isUndef()) { + if (!BT_cxx_call_undef) + BT_cxx_call_undef.reset(new BuiltinBug("Called C++ object pointer is " + "uninitialized")); + EmitBadCall(BT_cxx_call_undef.get(), C, CC->getOriginExpr()); + return; + } + if (V.isZeroConstant()) { + if (!BT_cxx_call_null) + BT_cxx_call_null.reset(new BuiltinBug("Called C++ object pointer " + "is null")); + EmitBadCall(BT_cxx_call_null.get(), C, CC->getOriginExpr()); + return; + } + } + // Don't check for uninitialized field values in arguments if the // caller has a body that is available and we have the chance to inline it. // This is a hack, but is a reasonable compromise betweens sometimes warning // and sometimes not depending on if we decide to inline a function. const Decl *D = Call.getDecl(); const bool checkUninitFields = - !(C.getAnalysisManager().shouldInlineCall() && - (D && D->getBody())); + !(C.getAnalysisManager().shouldInlineCall() && (D && D->getBody())); OwningPtr *BT; if (isa(Call)) diff --git a/clang/test/Analysis/misc-ps-cxx0x.cpp b/clang/test/Analysis/misc-ps-cxx0x.cpp index 7712bb8dc3b7..e1c78ed07236 100644 --- a/clang/test/Analysis/misc-ps-cxx0x.cpp +++ b/clang/test/Analysis/misc-ps-cxx0x.cpp @@ -87,4 +87,25 @@ void rdar11817693::operator=(const rdar11817693& src) { operator=(dynamic_cast(src)); } +// Test warning about null or uninitialized pointer values used as instance member +// calls. +class TestInstanceCall { +public: + void foo() {} +}; + +void test_ic() { + TestInstanceCall *p; + p->foo(); // expected-warning {{Called C++ object pointer is uninitialized}} +} + +void test_ic_null() { + TestInstanceCall *p = 0; + p->foo(); // expected-warning {{Called C++ object pointer is null}} +} + +void test_ic_null(TestInstanceCall *p) { + if (!p) + p->foo(); // expected-warning {{Called C++ object pointer is null}} +}