From fae03d8add5d92e21affd8abc455bcd4df3389f8 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Sun, 3 Mar 2019 20:17:53 +0000 Subject: [PATCH] Modules: Document that ReadASTCore exits its final loop via `return`, NFC The final loop never breaks. Document that by following it with llvm_unreachable. llvm-svn: 355294 --- clang/lib/Serialization/ASTReader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp index 9626418f6862..5ad21604f4e7 100644 --- a/clang/lib/Serialization/ASTReader.cpp +++ b/clang/lib/Serialization/ASTReader.cpp @@ -4257,7 +4257,7 @@ ASTReader::ReadASTCore(StringRef FileName, } } - return Success; + llvm_unreachable("unexpected break; expected return"); } ASTReader::ASTReadResult