From fa69c71dce481176b64546b5fbc098c967164575 Mon Sep 17 00:00:00 2001 From: Erich Keane Date: Fri, 9 Feb 2018 00:13:49 +0000 Subject: [PATCH] Fix UBSan issue with PPC::isValidCPUName Apparently storing the pointer to a StringLiteral as a StringRef caused this section of code to issue a ubsan warning. This will hopefully fix that. llvm-svn: 324687 --- clang/lib/Basic/Targets/PPC.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang/lib/Basic/Targets/PPC.cpp b/clang/lib/Basic/Targets/PPC.cpp index 40211dba28ec..3516a7380989 100644 --- a/clang/lib/Basic/Targets/PPC.cpp +++ b/clang/lib/Basic/Targets/PPC.cpp @@ -493,8 +493,7 @@ static constexpr llvm::StringLiteral ValidCPUNames[] = { }; bool PPCTargetInfo::isValidCPUName(StringRef Name) const { - const StringRef *FoundName = llvm::find(ValidCPUNames, Name); - return FoundName != std::end(ValidCPUNames); + return llvm::find(ValidCPUNames, Name) != std::end(ValidCPUNames); } void PPCTargetInfo::fillValidCPUList(SmallVectorImpl &Values) const {