From fa592908afe6f5459f05ee82f8908869a66e12cc Mon Sep 17 00:00:00 2001 From: Nicolas Vasilache Date: Thu, 22 Aug 2019 09:38:16 -0700 Subject: [PATCH] Let LLVMOpLowering specify a PatternBenefit - NFC Currently the benefit is always set to 1 which limits the ability to do A->B->C lowering PiperOrigin-RevId: 264854146 --- .../mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h | 2 +- .../lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h b/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h index d5c4c1192b99..2f413de8ec33 100644 --- a/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h +++ b/mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h @@ -116,7 +116,7 @@ private: class LLVMOpLowering : public ConversionPattern { public: LLVMOpLowering(StringRef rootOpName, MLIRContext *context, - LLVMTypeConverter &lowering); + LLVMTypeConverter &lowering, PatternBenefit benefit = 1); protected: // Back-reference to the lowering class, used to call type and function diff --git a/mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp b/mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp index 5e9c8787b673..779aa27d9cef 100644 --- a/mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp +++ b/mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp @@ -193,9 +193,9 @@ static Type getMemRefElementPtrType(MemRefType t, LLVMTypeConverter &lowering) { } LLVMOpLowering::LLVMOpLowering(StringRef rootOpName, MLIRContext *context, - LLVMTypeConverter &lowering_) - : ConversionPattern(rootOpName, /*benefit=*/1, context), - lowering(lowering_) {} + LLVMTypeConverter &lowering_, + PatternBenefit benefit) + : ConversionPattern(rootOpName, benefit, context), lowering(lowering_) {} namespace { // Base class for Standard to LLVM IR op conversions. Matches the Op type