maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLDB][NFC] Reliability Fixes for FormatEntity 

- Remove dead code
 - Fix incorrect null-reference check

Differential Revision: https://reviews.llvm.org/D131850
This commit is contained in:
Slava Gurevich 2022-08-13 23:46:21 -07:00
parent 1081bb08cc
commit fa5124327a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lldb/source/Core/FormatEntity.cpp
View File

@ -711,9 +711,6 @@ static bool DumpValue(Stream &s, const SymbolContext *sc,
return false;
}
if (valobj == nullptr)
return false;
ValueObject::ExpressionPathAftermath what_next =
(do_deref_pointer ? ValueObject::eExpressionPathAftermathDereference
: ValueObject::eExpressionPathAftermathNothing);
@ -1695,7 +1692,7 @@ bool FormatEntity::Format(const Entry &entry, Stream &s,
llvm::StringRef var_representation;
const char *var_name = var_value_sp->GetName().GetCString();
if (var_value_sp->GetCompilerType().IsValid()) {
if (var_value_sp && exe_scope->CalculateTarget())
if (exe_scope && exe_scope->CalculateTarget())
var_value_sp =
var_value_sp->GetQualifiedRepresentationIfAvailable(
exe_scope->CalculateTarget()