Revert rGd5d8569df14e95e2c53d167bd1b37995bcbec565 "Fix static analysis warnings about classes with virtual methods not having virtual destructors"

This reverts commit d5d8569df1.

llvm/include/llvm/ADT/FoldingSet.h

@@ -126,7 +126,7 @@ protected:
   explicit FoldingSetBase(unsigned Log2InitSize = 6);
   FoldingSetBase(FoldingSetBase &&Arg);
   FoldingSetBase &operator=(FoldingSetBase &&RHS);
-  virtual ~FoldingSetBase();
+  ~FoldingSetBase();
 
 public:
   //===--------------------------------------------------------------------===//

llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h

@@ -46,7 +46,7 @@ public:
     Entry(Entry &&) = default;
     Entry &operator=(const Entry &) = default;
     Entry &operator=(Entry &&) = default;
-    virtual ~Entry() = default;
+    ~Entry() = default;
 
 
   public:

llvm/include/llvm/MC/MCSection.h

@@ -104,7 +104,7 @@ protected:
   SectionKind Kind;
 
   MCSection(SectionVariant V, SectionKind K, MCSymbol *Begin);
-  virtual ~MCSection() = default;
+  ~MCSection();
 
 public:
   MCSection(const MCSection &) = delete;

llvm/include/llvm/Support/CommandLine.h

@@ -518,7 +518,7 @@ protected:
   GenericOptionValue() = default;
   GenericOptionValue(const GenericOptionValue&) = default;
   GenericOptionValue &operator=(const GenericOptionValue &) = default;
-  virtual ~GenericOptionValue() = default;
+  ~GenericOptionValue() = default;
 
 private:
   virtual void anchor();

llvm/include/llvm/Support/YAMLParser.h

@@ -175,7 +175,7 @@ protected:
   std::unique_ptr<Document> &Doc;
   SMRange SourceRange;
 
-  virtual ~Node() = default;
+  ~Node() = default;
 
 private:
   unsigned int TypeID;

llvm/include/llvm/Transforms/Utils/ValueMapper.h

@@ -54,7 +54,7 @@ protected:
   ValueMaterializer() = default;
   ValueMaterializer(const ValueMaterializer &) = default;
   ValueMaterializer &operator=(const ValueMaterializer &) = default;
-  virtual ~ValueMaterializer() = default;
+  ~ValueMaterializer() = default;
 
 public:
   /// This method can be implemented to generate a mapped Value on demand. For

llvm/lib/MC/MCSection.cpp

@@ -32,6 +32,8 @@ MCSymbol *MCSection::getEndSymbol(MCContext &Ctx) {
 
 bool MCSection::hasEnded() const { return End && End->isInSection(); }
 
+MCSection::~MCSection() = default;
+
 void MCSection::setBundleLockState(BundleLockStateType NewState) {
   if (NewState == NotBundleLocked) {
     if (BundleLockNestingDepth == 0) {