From f8bf4c213ae62aa4dc1e6fa431d510f2f4547918 Mon Sep 17 00:00:00 2001 From: Frits van Bommel Date: Fri, 15 Jul 2011 11:05:37 +0000 Subject: [PATCH] In Twine::str(), if the Twine stores only a std::string, just return a direct copy of that instead of first copying to a SmallString and converting that to a std::string. Also fix some indentation. llvm-svn: 135267 --- llvm/lib/Support/Twine.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/llvm/lib/Support/Twine.cpp b/llvm/lib/Support/Twine.cpp index 75cea2961a9d..d62123cc985e 100644 --- a/llvm/lib/Support/Twine.cpp +++ b/llvm/lib/Support/Twine.cpp @@ -14,6 +14,11 @@ using namespace llvm; std::string Twine::str() const { + // If we're storing only a std::string, just return it. + if (LHSKind == StdStringKind && RHSKind == EmptyKind) + return *static_cast(LHS); + + // Otherwise, flatten and copy the contents first. SmallString<256> Vec; return toStringRef(Vec).str(); } @@ -37,9 +42,9 @@ StringRef Twine::toNullTerminatedStringRef(SmallVectorImpl &Out) const { // Already null terminated, yay! return StringRef(static_cast(LHS)); case StdStringKind: { - const std::string *str = static_cast(LHS); - return StringRef(str->c_str(), str->size()); - } + const std::string *str = static_cast(LHS); + return StringRef(str->c_str(), str->size()); + } default: break; }