maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Changed XXX to FIXME, and added comment to the README file 

llvm-svn: 43359
This commit is contained in:
Bill Wendling 2007-10-25 19:49:32 +00:00
parent a83e6bc246
commit f73340efb9
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/CodeGen/BranchFolding.cpp
View File

@ -272,7 +272,7 @@ static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1,
while (I1 != MBB1->begin() && I2 != MBB2->begin()) { while (I1 != MBB1->begin() && I2 != MBB2->begin()) {
--I1; --I2; --I1; --I2;
if (!I1->isIdenticalTo(I2) || if (!I1->isIdenticalTo(I2) ||
// XXX: This check is dubious. It's used to get around a problem where // FIXME: This check is dubious. It's used to get around a problem where
// people incorrectly expect inline asm directives to remain in the same // people incorrectly expect inline asm directives to remain in the same
// relative order. This is untenable because normal compiler // relative order. This is untenable because normal compiler
// optimizations (like this one) may reorder and/or merge these // optimizations (like this one) may reorder and/or merge these

8
llvm/lib/CodeGen/README.txt
View File

@ -179,3 +179,11 @@ work.
The ocaml frametable structure supports liveness information. It would be good The ocaml frametable structure supports liveness information. It would be good
to support it. to support it.
//===---------------------------------------------------------------------===//
The FIXME in ComputeCommonTailLength in BranchFolding.cpp needs to be
revisited. The check is there to work around a misuse of directives in inline
assembly.
//===---------------------------------------------------------------------===//